Bug 1496893
| Summary: | Fail host deploy process if ovirt-host-deploy role is not found | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | eraviv | ||||||
| Component: | BLL.Infra | Assignee: | Ondra Machacek <omachace> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavol Brilla <pbrilla> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 4.2.0 | CC: | bugs, danken, eraviv, lsvaty, mperina, omachace | ||||||
| Target Milestone: | ovirt-4.2.0 | Flags: | rule-engine:
ovirt-4.2+
|
||||||
| Target Release: | 4.2.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-02-12 10:10:50 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
eraviv
2017-09-28 17:53:15 UTC
As far as I understand such a use case isn't possible when installing oVirt properly. Am I right? Perhaps the Dev environment Readme should be improved to make sure you install new required packages. on a clean 4.2 customer installation, I believe that ovirt-ansible would be installed, and this precise bug would not be seen. I am less sure about upgrades. However, if Ansible fails for whatever reason, add-host should report a failure. Currently it is failing silently. The Dev Readme is now up to date. Attaching relevant logs 2017-09-27 13:34:32,049+03 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.EE-ManagedThreadFactory-engine-Thread-1) [7379abf9] EVENT_ID: VDS_ANSIBLE_INSTALL_STARTED(560), Ansible host-deploy playbook execution has started on host h-local-1. 2017-09-27 13:34:32,050+03 WARN [org.ovirt.engine.core.common.utils.ansible.AnsibleExecutor] (org.ovirt.thread.EE-ManagedThreadFactory-engine-Thread-1) [7379abf9] Playbook '/home/eraviv/ov/dep/ovirt-engine-1/share/ovirt-engine/../ovirt-ansible-roles/playbooks/ovirt-host-deploy.yml' does not exists. Playbook won't be executed. 2017-09-27 13:34:32,054+03 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.EE-ManagedThreadFactory-engine-Thread-1) [7379abf9] EVENT_ID: VDS_ANSIBLE_INSTALL_FINISHED(561), Ansible host-deploy playbook execution has successfully finished on host h-local-1. Created attachment 1333177 [details]
engine log
Created attachment 1333178 [details]
host deploy log
ovirt-engine depends on ovirt-ansible-roles package, so in RPM installation the ovirt-host-deploy role should always be present, but you are right, we should fail the host deploy process if the role is for example removed by accident. Playbooks became part of ovirt-engine-tools.rpm and it depends on main ovirt-engine.rpm Not an issue anymore Playbooks became part of ovirt-engine-tools.rpm and it depends on main ovirt-engine.rpm Not an issue anymore This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |