Bug 1497912
| Summary: | Provisioning multiple VMs using service dialogs do not honour quotas | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Sachin <sacpatil> |
| Component: | Automate | Assignee: | William Fitzgerald <wfitzger> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Vatsal Parekh <vparekh> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.7.0 | CC: | akarol, cpelland, greartes, igortiunov, jhardy, mkanoor, obarenbo, sacpatil, simaishi, smallamp, tfitzger, vparekh, wfitzger |
| Target Milestone: | GA | ||
| Target Release: | 5.8.3 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | quota:service | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-17 20:19:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1489507 | ||
|
Description
Sachin
2017-10-03 06:11:51 UTC
Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set it to Low/Low. Vatsal, Can you reproduce this issue and send us the appliance information? Thanks Billy Vatsal, I changed your dialog field name to option_0_number_of_vms. I changed tenant quota to Allocated Number of Virtual Machines to 1. When I order the service, Quota denies it. This is working for me. Thanks Billy Hi Vatsal, As Billy mentioned in comment 11, he changed the Tenant quota Allocated number of Virtual machines to 1. When we checked your appliance logs, we noticed that there were no quota limits set, so quota was not used. You need to set at least one Tenant quota value to enable quota. Let me know if you have any questions. Thanks, Tina (In reply to William Fitzgerald from comment #11) > Vatsal, > > I changed your dialog field name to option_0_number_of_vms. > > I changed tenant quota to Allocated Number of Virtual Machines to 1. > > When I order the service, Quota denies it. > > This is working for me. > > Thanks > > Billy Can you please let me know on which version it is fixed and shipped for on_qa? Vatsal, It should be fixed on 5.7 also. Billy Closing this BZ, as it is working as expected. New commit detected on ManageIQ/manageiq-content/master: https://github.com/ManageIQ/manageiq-content/commit/53f0acd0d1d32aa339da08d2f2d23b8d9cbefdcc commit 53f0acd0d1d32aa339da08d2f2d23b8d9cbefdcc Author: william fitzgerald <wfitzger> AuthorDate: Wed Oct 25 11:40:49 2017 -0400 Commit: william fitzgerald <wfitzger> CommitDate: Wed Oct 25 11:40:49 2017 -0400 Calculate quota using service dialogs overrides. Changed requested method to use dialog overrides in quota calculations. Modified requested method to calculate quota based on dialog values for: number_of_sockets, cores_per_socket, number_of_cpus, vm_memory and storage. This can be tested by using service dialogs using these values. https://bugzilla.redhat.com/show_bug.cgi?id=1497912 Testing Create a service using service dialog overrides values for the above values. You can use one or more override values. Order the service, change some values and run. Note: We are honoring number_of_vms in a service dialog but not using number_of_vms in quota calculations. Doing quota calculations for number_of_vms in a service dialog will be in a followup PR. I am including screenshots of a dialog using some values. content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/requested.rb | 35 +- spec/automation/unit/method_validation/calculate_requested_spec.rb | 83 + 2 files changed, 116 insertions(+), 2 deletions(-) |