Bug 1465087 - Service template provisioning request do not honour quotas [NEEDINFO]
Service template provisioning request do not honour quotas
Status: ON_DEV
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate (Show other bugs)
5.7.0
Unspecified Unspecified
medium Severity high
: GA
: 5.8.2
Assigned To: William Fitzgerald
Aziza Karol
quota:service
: ZStream
Depends On: 1455844 1488313
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-26 11:48 EDT by Satoe Imaishi
Modified: 2017-09-22 10:00 EDT (History)
9 users (show)

See Also:
Fixed In Version: 5.8.2.0
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1455844
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wfitzger: needinfo? (akarol)


Attachments (Terms of Use)
provisioning from lifecycle (106.06 KB, image/png)
2017-09-05 07:03 EDT, Aziza Karol
no flags Details
service provisioning (106.96 KB, image/png)
2017-09-05 07:05 EDT, Aziza Karol
no flags Details
service provisioning with user as quota source (177.39 KB, image/png)
2017-09-05 08:31 EDT, Aziza Karol
no flags Details

  None (edit)
Comment 2 CFME Bot 2017-08-04 09:58:01 EDT
New commit detected on ManageIQ/manageiq-content/fine:
https://github.com/ManageIQ/manageiq-content/commit/30bba6f72010eb612e03e7cc254bd6e602bc69e6

commit 30bba6f72010eb612e03e7cc254bd6e602bc69e6
Author:     Greg McCullough <gmccullo@redhat.com>
AuthorDate: Wed Jun 21 15:07:27 2017 -0400
Commit:     Satoe Imaishi <simaishi@redhat.com>
CommitDate: Fri Aug 4 09:56:42 2017 -0400

    Merge pull request #128 from billfitzgerald0120/requested_number_of_vms
    
    Fixed quota calculations for multiple vms in requested method.
    (cherry picked from commit 85dd4414d6d6c4a8bc3b726bac5625974c7caad3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1465087

 .../QuotaMethods.class/__methods__/requested.rb    | 33 +++++++++++-----------
 .../method_validation/calculate_requested_spec.rb  | 18 ++++++++++++
 2 files changed, 35 insertions(+), 16 deletions(-)
Comment 3 Aziza Karol 2017-09-05 07:01:23 EDT
Wrong quota calculations for multiple vms when provision via services.

Observations:

1.When you provision an instance Using: Lifecycle -> Provision instances with  number of instances:25 flavor: m1.tiny the quota calculation message 
shows "Request exceeds maximum allowed for the following: (storage - Used: 5 GB plus requested: 25 GB exceeds quota: 4 GB)

Note:number of instance count is considered in quota calculations.


2.When you provision using services catalogs with same number of instances:25 & flavor: m1.tiny the quota calculation message 
shows "Request exceeds maximum allowed for the following: (storage - Used: 5 GB plus requested: 1 GB exceeds quota: 4 GB)

Note:No of instance is not considered in quota calculation as the requested shows only 1GB instead of 25GB.

Quota calculations when provisioning via services should be fixed.


My appliance for reference: https://10.8.197.134.
Screenshots attached.

Version:5.8.2.0.20170824192913_b09a5f8
Comment 4 Aziza Karol 2017-09-05 07:03 EDT
Created attachment 1322163 [details]
provisioning from lifecycle
Comment 5 Aziza Karol 2017-09-05 07:05 EDT
Created attachment 1322164 [details]
service provisioning
Comment 7 Aziza Karol 2017-09-05 08:31 EDT
Created attachment 1322190 [details]
service provisioning with user as quota source
Comment 8 William Fitzgerald 2017-09-05 15:05:32 EDT
Aziza,

Is is ok for me to use your appliance ?
Comment 9 Aziza Karol 2017-09-06 00:47:23 EDT
William,

Sure, you can use it.

Thanks,
Aziza
Comment 10 William Fitzgerald 2017-09-06 15:11:14 EDT
Aziza,

  If you look at https://bugzilla.redhat.com/show_bug.cgi?id=1488313, it will explain  how to select a flavor (instance_type in your dialog).  The error is coming because your dialog doesn't work.  You can change your dialog to use a drop down list or the extra code in the BZ above. 

This is not a bug.

Let me know if you have questions ...

Thanks

Billy
Comment 11 William Fitzgerald 2017-09-14 15:56:15 EDT
Aziza,

  If you look at https://bugzilla.redhat.com/show_bug.cgi?id=1488313, it will explain  how to select a flavor (instance_type in your dialog).  The error is coming because your dialog doesn't work.  You can change your dialog to use a drop down list or the extra code in the BZ above. 

This is not a bug.

Let me know if you have questions ...

Thanks

Billy
Comment 13 William Fitzgerald 2017-09-18 10:50:29 EDT
Aziza,


I tried your appliance on Friday and today and I can't logon.  Can you re-create?

Thanks

Billy
Comment 15 William Fitzgerald 2017-09-21 10:50:31 EDT
Aziza,

I checked your appliance.  If you want to select the flavor/instance, you will have to build a dynamic dialog.  These values can't be text values.  You will need to write a method that looks up the flavor and returns that value.  I was looking around for a sample but couldn't find one for you.

Hope this helps ...

Billy
Comment 16 William Fitzgerald 2017-09-21 17:16:31 EDT
Aziza,

 I found a sample dynamic method, modified your dialog and it works.  I added a Billy domain with the method. Let me know if you have any questions.

Thanks

Billy
Comment 17 Aziza Karol 2017-09-22 07:08:13 EDT
Hey Billy,

I tried provisioning with your dynamic method on the same applaince.I am not getting `root_disk_size' error but it is still not honoring quotas. I selected  m1.xlarge flavor while provisioning but did not get any quota exceeded msg.
Can you please check?

Also, Do we have to build the dynamic dialog for number of instances as well?.

Thanks,
Aziza
Comment 18 William Fitzgerald 2017-09-22 10:00:28 EDT
Aziza,

You don't need a dynamic dialog for instances.  I tried asking for 6 vms and it didn't work.  I changed your dialog value for number_of_vms to option_0_number_of_vms and it works. 

Can you try it now ?

Let me know how it works.

Thanks

Billy

Note You need to log in before you can comment on or make changes to this bug.