Bug 1499109

Summary:	Review Request: perl-Log-Journald - perl Log::Journald module for faster logging to journald
Product:	[Fedora] Fedora	Reporter:	Madison Kelly <mkelly>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jplesnik, lkundrak, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-17 00:45:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Madison Kelly 2017-10-06 05:08:06 UTC

Spec URL: https://www.alteeve.com/an-repo/files/packages/perl-Log-Journald.spec
SRPM URL: https://www.alteeve.com/an-repo/files/packages/perl-Log-Journald-0.20-2.fc26.src.rpm
Description: Log::Journald perl module (see: http://search.cpan.org/~lkundrak/Log-Journald/lib/Log/Journald.pm)
Fedora Account System Username: digimer

Comment 1 Lubomir Rintel 2017-10-09 17:57:47 UTC

1.) The SPEC file needs some modernizing, in particular removal of obsolete bits:

> -BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BuildRoot tag is no longer used.

> -Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

I don't think MODULE_COMPAT makes sense anymore -- libperl now has a properly versioned SONAME and thus a sufficient dependency gets generated.

>  %install
> -rm -rf $RPM_BUILD_ROOT

The buildroot shouldn't be cleaned anymore.

> -%clean
> -rm -rf $RPM_BUILD_ROOT

The %clean section is no longer used.

> -%defattr(-,root,root,-)

%defattr is for making the files owned by root is not needed anymore.

2.) The source file you've bundled with your src.rpm does nor correspond to the upstream source.

Please turn the changes into a Patch file and apply it with %patch macro.

Comment 2 Package Review 2020-07-10 00:56:14 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Package Review 2020-11-13 00:46:56 UTC

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 4 Jitka Plesnikova 2020-11-16 11:03:15 UTC

Do you want to finish the review? 

If yes, please use the latest version of the module and update the spec due to new guidelines.

Comment 5 Package Review 2020-12-17 00:45:23 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.