Bug 1499109 - Review Request: perl-Log-Journald - perl Log::Journald module for faster logging to journald
Summary: Review Request: perl-Log-Journald - perl Log::Journald module for faster logg...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-10-06 05:08 UTC by Madison Kelly
Modified: 2020-12-17 00:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-17 00:45:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Lubomir Rintel 2017-10-09 17:57:47 UTC
1.) The SPEC file needs some modernizing, in particular removal of obsolete bits:

> -BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BuildRoot tag is no longer used.

> -Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

I don't think MODULE_COMPAT makes sense anymore -- libperl now has a properly versioned SONAME and thus a sufficient dependency gets generated.

>  %install
> -rm -rf $RPM_BUILD_ROOT

The buildroot shouldn't be cleaned anymore.

> -%clean
> -rm -rf $RPM_BUILD_ROOT

The %clean section is no longer used.

> -%defattr(-,root,root,-)

%defattr is for making the files owned by root is not needed anymore.

2.) The source file you've bundled with your src.rpm does nor correspond to the upstream source.

Please turn the changes into a Patch file and apply it with %patch macro.

Comment 2 Package Review 2020-07-10 00:56:14 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Package Review 2020-11-13 00:46:56 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 4 Jitka Plesnikova 2020-11-16 11:03:15 UTC
Do you want to finish the review? 

If yes, please use the latest version of the module and update the spec due to new guidelines.

Comment 5 Package Review 2020-12-17 00:45:23 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.