Bug 1500574
| Summary: | Review Request: golang-github-alecthomas-chroma - A general purpose syntax highlighter in pure Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-11 02:55:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1500571, 1500573, 1500831 | ||
| Bug Blocks: | |||
|
Description
Athos Ribeiro
2017-10-11 04:42:06 UTC
This package is missing: DEBUG util.py:458: No matching package to install: 'golang(github.com/aymerick/douceur/css)' DEBUG util.py:458: No matching package to install: 'golang(github.com/aymerick/douceur/parser)' I guess you need to package golang-github-aymerick-douceur too. Thanks for the input, Robert! This added a few new dependencies in the dependency chain I've got an error trying to build thee package:
+ go build -buildmode pie -compiler gc -tags=rpm_crashtraceback -ldflags ' -B 0xc83cd7cc0cef861d84a31cb3d1223c0778855af3 -extldflags '\''-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'\''' -a -v -x -o bin/css2style github.com/alecthomas/chroma/css2style
WORK=/tmp/go-build802240568
can't load package: package github.com/alecthomas/chroma/css2style: cannot find package "github.com/alecthomas/chroma/css2style" in any of:
/usr/lib/golang/src/github.com/alecthomas/chroma/css2style (from $GOROOT)
/builddir/build/BUILD/chroma-bc2d6680e4f0f640898b2564c3d479d5cb9023f3/src/github.com/alecthomas/chroma/css2style (from $GOPATH)
/usr/share/gocode/src/github.com/alecthomas/chroma/css2style
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.KWjMzW (%build)
Bad exit status from /var/tmp/rpm-tmp.KWjMzW (%build)
I solved this by modifying:
%gobuild -o bin/css2style %{import_path}/css2style
%gobuild -o bin/exercise %{import_path}/exercise
into:
%gobuild -o bin/css2style %{import_path}/_tools/css2style
%gobuild -o bin/exercise %{import_path}/_tools/exercise
But then I've got another error:
+ go build -buildmode pie -compiler gc -tags=rpm_crashtraceback -ldflags ' -B 0x629aebb49a981394444d4eb5e4869b940e646646 -extldflags '\''-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'\''' -a -v -x -o bin/css2style github.com/alecthomas/chroma/_tools/css2style
WORK=/tmp/go-build398625459
src/github.com/alecthomas/chroma/_tools/css2style/main.go:11:2: cannot find package "gopkg.in/alecthomas/kingpin.v3-unstable" in any of:
/usr/lib/golang/src/gopkg.in/alecthomas/kingpin.v3-unstable (from $GOROOT)
/builddir/build/BUILD/chroma-bc2d6680e4f0f640898b2564c3d479d5cb9023f3/src/gopkg.in/alecthomas/kingpin.v3-unstable (from $GOPATH)
/usr/share/gocode/src/gopkg.in/alecthomas/kingpin.v3-unstable
It seems css2style requires yet another dependency: http://gopkg.in/alecthomas/kingpin.v3-unstable
Hi Robert, Thanks for the input! The gopkg.in page for kingpin [1] says it is an unstable version, which should not be used in production. In upstream repository [2] it is clear that version 3 is not out yet. I am thinking of not shipping the command line tools with chroma until the tools start requiring a stable version of kingpin. Note that kingpin is already packaged in fedora [3] and it does provide the gopkg.in namespace for v2 [4]. Any thoughts? New sources: Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-alecthomas-chroma.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-alecthomas-chroma-0.1.1-2.fc26.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22448390 [1] http://gopkg.in/alecthomas/kingpin.v3-unstable [3] https://github.com/alecthomas/kingpin [3] https://koji.fedoraproject.org/koji/packageinfo?packageID=24649 [4] https://src.fedoraproject.org/rpms/golang-github-alecthomas-kingpin/blob/master/f/golang-github-alecthomas-kingpin.spec#_10 It's your choice, either you package Kingpin unstable, or you do not include the tools in this package, the library will probably work just fine. OK! The last sources reflect those changes (I added a with_build macro, which is deactivated). this is great, package is accepted. Thanks for all the reviews on these packages in hugo dependency tree, Robert!!! (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-chroma golang-github-alecthomas-chroma-0.1.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9fbb121513 golang-github-alecthomas-chroma-0.1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9fbb121513 golang-github-alecthomas-chroma-0.1.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |