Bug 1501114
| Summary: | Custom Button icon is not disabled when button is disabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Anurag <ansinha> | ||||||
| Component: | UI - OPS | Assignee: | Dávid Halász <dhalasz> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Anurag <ansinha> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.9.0 | CC: | dhalasz, hkataria, jhardy, mpovolny, obarenbo, rblanco, simaishi | ||||||
| Target Milestone: | GA | ||||||||
| Target Release: | 5.10.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | ui:custom | ||||||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-02-07 23:02:54 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | Bug | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
I have noticed that the coloured icon are not disabled where as black icons are disabled. Created attachment 1337547 [details]
Black button is disabled
New commits detected on ManageIQ/ui-components/master: https://github.com/ManageIQ/ui-components/commit/bd2552af572addcff07ebc3acb1762a51c1061cf commit bd2552af572addcff07ebc3acb1762a51c1061cf Author: Dávid Halász <dhalasz> AuthorDate: Fri Apr 20 09:03:03 2018 -0400 Commit: Dávid Halász <dhalasz> CommitDate: Fri Apr 20 09:03:03 2018 -0400 Add a new angular filter for adjusting the opacity of a hex color https://bugzilla.redhat.com/show_bug.cgi?id=1501114 src/common/filters/adjustColorFilter.spec.ts | 15 + src/common/filters/adjustColorFilter.ts | 16 + src/common/filters/index.ts | 2 + 3 files changed, 33 insertions(+) https://github.com/ManageIQ/ui-components/commit/036a80ff389629b7eb4a29b655f57f2c7bdea269 commit 036a80ff389629b7eb4a29b655f57f2c7bdea269 Author: Dávid Halász <dhalasz> AuthorDate: Fri Apr 20 09:03:22 2018 -0400 Commit: Dávid Halász <dhalasz> CommitDate: Fri Apr 20 09:03:22 2018 -0400 Adjust the opacity of custom colored icons when they are disabled Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1501114 src/common/filters/abbrNumberFilter.spec.ts | 2 +- src/common/filters/adjustColorFilter.spec.ts | 6 +- src/toolbar/components/toolbar-menu/toolbar-button.html | 4 +- src/toolbar/components/toolbar-menu/toolbar-list.html | 4 +- src/toolbar/components/toolbar-menu/toolbar-view.html | 2 +- src/toolbar/index.ts | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) Hi Team, I have verified this issue on version: 5.10.0.2.20180626170006_40dc459 and it's been resolved and working correctly. Hence changing the status from on_qa to verified. Thanks for resolving this issue. Thanks, -Anurag Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0212 |
Created attachment 1337543 [details] Icon of custom button is not disabled Description of problem: When the custom button is disabled, then the icon of the button is not disabled. Version-Release number of selected component (if applicable): Version 5.9.0.2.20171010190026_0413a06 How reproducible: 100% Steps to Reproduce: 1.Goto Automation-->Automate-->Customization 2.Select the Button accordion 3.Click on Configuration-->"Add a new Button" 4.Fill all the information, Add an expression to disable it(Enablement) 4.Add it to a Button Group 5.Go to the page Where Button Group is Added 6.Click on Button Group Actual results: Icon is enabled and text is disabled. Expected results: The Icon should be disabled along with the text. Additional info: