Bug 1501114 - Custom Button icon is not disabled when button is disabled
Summary: Custom Button icon is not disabled when button is disabled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: GA
: 5.10.0
Assignee: Dávid Halász
QA Contact: Anurag
URL:
Whiteboard: ui:custom
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-12 06:41 UTC by Anurag
Modified: 2019-02-07 23:03 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-07 23:02:54 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Icon of custom button is not disabled (210.80 KB, image/png)
2017-10-12 06:41 UTC, Anurag
no flags Details
Black button is disabled (205.72 KB, image/png)
2017-10-12 07:02 UTC, Anurag
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:0212 0 None None None 2019-02-07 23:03:07 UTC

Description Anurag 2017-10-12 06:41:51 UTC
Created attachment 1337543 [details]
Icon of custom button is not disabled

Description of problem:

When the custom button is disabled, then the icon of the button is not disabled.


Version-Release number of selected component (if applicable):

Version 5.9.0.2.20171010190026_0413a06 


How reproducible:

100%


Steps to Reproduce:

1.Goto Automation-->Automate-->Customization
2.Select the Button accordion
3.Click on Configuration-->"Add a new Button"
4.Fill all the information, Add an expression to disable it(Enablement)
4.Add it to a Button Group
5.Go to the page Where Button Group is Added
6.Click on Button Group

Actual results:
Icon is enabled and text is disabled.



Expected results:
The Icon should be disabled along with the text.



Additional info:

Comment 1 Anurag 2017-10-12 07:01:14 UTC
I have noticed that the coloured icon are not disabled where as black icons are disabled.

Comment 2 Anurag 2017-10-12 07:02:43 UTC
Created attachment 1337547 [details]
Black button is disabled

Comment 4 CFME Bot 2018-04-24 08:35:30 UTC
New commits detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/bd2552af572addcff07ebc3acb1762a51c1061cf
commit bd2552af572addcff07ebc3acb1762a51c1061cf
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Apr 20 09:03:03 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Apr 20 09:03:03 2018 -0400

    Add a new angular filter for adjusting the opacity of a hex color

    https://bugzilla.redhat.com/show_bug.cgi?id=1501114

 src/common/filters/adjustColorFilter.spec.ts | 15 +
 src/common/filters/adjustColorFilter.ts | 16 +
 src/common/filters/index.ts | 2 +
 3 files changed, 33 insertions(+)


https://github.com/ManageIQ/ui-components/commit/036a80ff389629b7eb4a29b655f57f2c7bdea269
commit 036a80ff389629b7eb4a29b655f57f2c7bdea269
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Apr 20 09:03:22 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Apr 20 09:03:22 2018 -0400

    Adjust the opacity of custom colored icons when they are disabled

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1501114

 src/common/filters/abbrNumberFilter.spec.ts | 2 +-
 src/common/filters/adjustColorFilter.spec.ts | 6 +-
 src/toolbar/components/toolbar-menu/toolbar-button.html | 4 +-
 src/toolbar/components/toolbar-menu/toolbar-list.html | 4 +-
 src/toolbar/components/toolbar-menu/toolbar-view.html | 2 +-
 src/toolbar/index.ts | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

Comment 7 Anurag 2018-07-02 10:08:37 UTC
Hi Team, 

I have verified this issue on version: 5.10.0.2.20180626170006_40dc459 and it's been resolved and working correctly. Hence changing the status from on_qa to verified. Thanks for resolving this issue.

Thanks,
-Anurag

Comment 8 errata-xmlrpc 2019-02-07 23:02:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0212


Note You need to log in before you can comment on or make changes to this bug.