Bug 1501322

Summary: Flash message should be shown instead of error dialogue box
Product: Red Hat CloudForms Management Engine Reporter: Anurag <ansinha>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Anurag <ansinha>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: akarve, hkataria, jhardy, jocarter, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: FutureFeature, TestOnly
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:custom
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1511078 (view as bug list) Environment:
Last Closed: 2018-06-21 20:55:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1511078    
Attachments:
Description Flags
Error Message dialogue box none

Description Anurag 2017-10-12 11:29:29 UTC
Created attachment 1337713 [details]
Error Message dialogue box

Description of problem:

When we are adding a generic object with the same name as already existing, then there is an error dialogue box instead of a which a flash message should be shown.


Version-Release number of selected component (if applicable):

Version 5.9.0.2.20171010190026_0413a06 


How reproducible:
100%

Steps to Reproduce:
1.Go to Autmation-->Automate-->Generic Object
2.Create a generic object with name and description as "test"
3.Try to create another generic object with same name and description "test"
4.Click on Add button


Actual results:
Error dialogue box appears


Expected results:
Error Flash message should be shown


Additional info:

Comment 5 CFME Bot 2017-11-08 07:43:33 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/ce3ccea70dc9d87eac56d9dd8850b1add10d12d2

commit ce3ccea70dc9d87eac56d9dd8850b1add10d12d2
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 2 12:28:15 2017 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Nov 7 18:47:46 2017 +0000

    Generic Object - don't error modal on validation errors
    
    When the server responds with an error-like response, we're showing the error modal, since https://github.com/ManageIQ/manageiq-ui-classic/pull/1976 .
    
    That is wrong when the error is a 400 validation error.
    
    Using the mechanism introduced in https://github.com/ManageIQ/manageiq-ui-classic/pull/2075 to skip the error modal in such cases.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1501322

 .../components/generic_object/generic-object-definition-component.js  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)