Bug 1501322 - Flash message should be shown instead of error dialogue box
Summary: Flash message should be shown instead of error dialogue box
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Martin Hradil
QA Contact: Anurag
URL:
Whiteboard: ui:custom
Depends On:
Blocks: 1511078
TreeView+ depends on / blocked
 
Reported: 2017-10-12 11:29 UTC by Anurag
Modified: 2018-06-21 20:55 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1511078 (view as bug list)
Environment:
Last Closed: 2018-06-21 20:55:18 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Error Message dialogue box (103.48 KB, image/png)
2017-10-12 11:29 UTC, Anurag
no flags Details

Description Anurag 2017-10-12 11:29:29 UTC
Created attachment 1337713 [details]
Error Message dialogue box

Description of problem:

When we are adding a generic object with the same name as already existing, then there is an error dialogue box instead of a which a flash message should be shown.


Version-Release number of selected component (if applicable):

Version 5.9.0.2.20171010190026_0413a06 


How reproducible:
100%

Steps to Reproduce:
1.Go to Autmation-->Automate-->Generic Object
2.Create a generic object with name and description as "test"
3.Try to create another generic object with same name and description "test"
4.Click on Add button


Actual results:
Error dialogue box appears


Expected results:
Error Flash message should be shown


Additional info:

Comment 5 CFME Bot 2017-11-08 07:43:33 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/ce3ccea70dc9d87eac56d9dd8850b1add10d12d2

commit ce3ccea70dc9d87eac56d9dd8850b1add10d12d2
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 2 12:28:15 2017 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Nov 7 18:47:46 2017 +0000

    Generic Object - don't error modal on validation errors
    
    When the server responds with an error-like response, we're showing the error modal, since https://github.com/ManageIQ/manageiq-ui-classic/pull/1976 .
    
    That is wrong when the error is a 400 validation error.
    
    Using the mechanism introduced in https://github.com/ManageIQ/manageiq-ui-classic/pull/2075 to skip the error modal in such cases.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1501322

 .../components/generic_object/generic-object-definition-component.js  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


Note You need to log in before you can comment on or make changes to this bug.