Bug 1502016 (deepin-picker)

Summary:	Review Request: deepin-picker - color picker tool for Deepin
Product:	[Fedora] Fedora	Reporter:	sensor.wen
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-22 13:32:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1465889

Description sensor.wen 2017-10-13 17:45:29 UTC

Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00630215-deepin-picker/deepin-picker.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00630215-deepin-picker/deepin-picker-0.4-1.fc26.src.rpm

Description: color picker tool for Deepin

Fedora Account System Username: mosquito

Comment 1 sensor.wen 2017-10-13 18:04:51 UTC

Today, Deepin have a new little project. Could you have free time to review it? @zebob

Comment 2 Robert-André Mauchin 🐧 2017-10-13 18:36:11 UTC

Hello mosquito,

 - update-desktop-database is not needed anymore in Fedora 25 or later. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#desktop-database

  Just use:

%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

%postun
if [ $1 -eq 0 ] ; then
    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

 - I don't think this dependency should be so strict:

BuildRequires:  pkgconfig(dtkwidget) = 2.0

Maybe use >=.

 - You must validate the .desktop file:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - You must add the followinq Require for icons:

Requires:       hicolor-icon-theme

Comment 3 sensor.wen 2017-10-14 10:16:19 UTC

https://koji.fedoraproject.org/koji/taskinfo?taskID=22440296

Thank you for your work. I fixed.

Comment 4 Robert-André Mauchin 🐧 2017-10-14 11:51:38 UTC

All ok, package accepted.

Comment 5 Gwyn Ciesla 2017-10-16 13:42:16 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-picker

Comment 6 Zamir SUN 2018-07-22 13:32:17 UTC

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.