Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00630215-deepin-picker/deepin-picker.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00630215-deepin-picker/deepin-picker-0.4-1.fc26.src.rpm Description: color picker tool for Deepin Fedora Account System Username: mosquito
Today, Deepin have a new little project. Could you have free time to review it? @zebob
Hello mosquito, - update-desktop-database is not needed anymore in Fedora 25 or later. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#desktop-database Just use: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - I don't think this dependency should be so strict: BuildRequires: pkgconfig(dtkwidget) = 2.0 Maybe use >=. - You must validate the .desktop file: desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop - You must add the followinq Require for icons: Requires: hicolor-icon-theme
https://koji.fedoraproject.org/koji/taskinfo?taskID=22440296 Thank you for your work. I fixed.
All ok, package accepted.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-picker
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.