Bug 1503203
| Summary: | cri-o plugins path: set to /usr/libexec/cni | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ed Santiago <santiago> |
| Component: | cri-o | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | amurdaca, dwalsh, fkluknav, lsm5 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | cri-o-1.0.1-1.git64a30e1.fc26 cri-o-1.0.0-6.gita636972.fc27 cri-o-1.0.1-2.git64a30e1.fc27 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-01 00:08:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Man page should be fixed not sure of the --config /dev/null though. Is upstream cri-o gonna use /opt/cni/bin by default? Just checking if the manpage change should be upstream or in fedora rpm only. I know of no distro that encourages use of /opt.
My suggestion would be to change it upstream, to a safely autoconf-able or otherwise refactorable value. I believe it is important that the following files be consistent:
docs/crio.8.md docs/crio.conf.5.md
libkpod/config.go libkpod/testdata/config.toml
test/helpers.bash
vendor/github.com/cri-o/ocicni/pkg/ocicni/types.go
That seems too unwieldy to do by patching.
Yes lets change the defaults to be /usr/lib/libexec or /usr/lib/cni (Which is more Ubuntu and SUSE friendly, I believe) cri-o-1.0.0-6.gita636972.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-79bd32c01d cri-o-1.0.0-6.gita636972.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b43079883b cri-o-1.0.0-6.gita636972.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b43079883b cri-o-1.0.0-6.gita636972.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-79bd32c01d cri-o-1.0.0-6.gita636972.fc28.x86_64 and cri-o-1.0.0-6.gita636972.fc27.x86_64 : no joy.
# for i in crio crio.conf;do man $i|grep plugin.*default;done
CNI plugin binaries directory (default: "/opt/cni/bin/")
Path to CNI plugin binaries (default: "/opt/cni/bin/")
# crio --config /dev/null config |tail -1
plugin_dir = "/opt/cni/bin/"
cri-o-1.0.1-1.git64a30e1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-28a4b68ae4 cri-o-1.0.1-1.git64a30e1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a76e145110 cri-o-1.0.1-1.git64a30e1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-28a4b68ae4 cri-o-1.0.1-2.git64a30e1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a76e145110 cri-o-1.0.1-2.git64a30e1.fc27.x86_64 : See comment 9. cri-o-1.0.1-1.git64a30e1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. cri-o-1.0.0-6.gita636972.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. cri-o-1.0.1-2.git64a30e1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |
cri-o-1.0.0-4.gitcd1bac5.fc28 updates /etc/crio/crio.conf such that plugins_dir is /usr/libexec/cni . I believe more is needed. First: man pages crio(8) and crio.conf(5) still reference /opt/cni/bin Second: libkpod/config.go and vendor/github.com/cri-o/ocicni/pkg/ocicni/types.go still define DefaultCNIDir as /opt/cni/bin, so this command produces a misleading config: # crio --config /dev/null config |tail -1 plugin_dir = "/opt/cni/bin/"