Bug 1503203 - cri-o plugins path: set to /usr/libexec/cni
Summary: cri-o plugins path: set to /usr/libexec/cni
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cri-o
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-17 14:34 UTC by Ed Santiago
Modified: 2017-11-11 03:05 UTC (History)
4 users (show)

Fixed In Version: cri-o-1.0.1-1.git64a30e1.fc26 cri-o-1.0.0-6.gita636972.fc27 cri-o-1.0.1-2.git64a30e1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-01 00:08:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ed Santiago 2017-10-17 14:34:47 UTC
cri-o-1.0.0-4.gitcd1bac5.fc28 updates /etc/crio/crio.conf such that plugins_dir is /usr/libexec/cni . I believe more is needed.

First: man pages crio(8) and crio.conf(5) still reference /opt/cni/bin

Second: libkpod/config.go and vendor/github.com/cri-o/ocicni/pkg/ocicni/types.go still define DefaultCNIDir as /opt/cni/bin, so this command produces a misleading config:

    # crio --config /dev/null config |tail -1
    plugin_dir = "/opt/cni/bin/"

Comment 1 Daniel Walsh 2017-10-17 16:52:25 UTC
Man page should be fixed not sure of the --config /dev/null though.

Comment 2 Lokesh Mandvekar 2017-10-17 19:29:17 UTC
Is upstream cri-o gonna use /opt/cni/bin by default? Just checking if the manpage change should be upstream or in fedora rpm only.

Comment 3 Ed Santiago 2017-10-17 19:37:58 UTC
I know of no distro that encourages use of /opt.

My suggestion would be to change it upstream, to a safely autoconf-able or otherwise refactorable value. I believe it is important that the following files be consistent:

    docs/crio.8.md     docs/crio.conf.5.md
    libkpod/config.go  libkpod/testdata/config.toml
    test/helpers.bash
    vendor/github.com/cri-o/ocicni/pkg/ocicni/types.go

That seems too unwieldy to do by patching.

Comment 4 Daniel Walsh 2017-10-17 19:54:05 UTC
Yes lets change the defaults to be /usr/lib/libexec or /usr/lib/cni (Which is more Ubuntu and SUSE friendly, I believe)

Comment 5 Fedora Update System 2017-10-19 17:45:19 UTC
cri-o-1.0.0-6.gita636972.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-79bd32c01d

Comment 6 Fedora Update System 2017-10-19 17:45:28 UTC
cri-o-1.0.0-6.gita636972.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b43079883b

Comment 7 Fedora Update System 2017-10-21 19:26:52 UTC
cri-o-1.0.0-6.gita636972.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b43079883b

Comment 8 Fedora Update System 2017-10-22 02:22:44 UTC
cri-o-1.0.0-6.gita636972.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-79bd32c01d

Comment 9 Ed Santiago 2017-10-23 17:25:44 UTC
cri-o-1.0.0-6.gita636972.fc28.x86_64 and cri-o-1.0.0-6.gita636972.fc27.x86_64 : no  joy.

   # for i in crio crio.conf;do man $i|grep plugin.*default;done                                                 
         CNI plugin binaries directory (default: "/opt/cni/bin/")                                                                  
         Path to CNI plugin binaries (default: "/opt/cni/bin/")                                                                    

   # crio --config /dev/null config |tail -1                                                                    
   plugin_dir = "/opt/cni/bin/"

Comment 10 Fedora Update System 2017-10-25 18:26:27 UTC
cri-o-1.0.1-1.git64a30e1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-28a4b68ae4

Comment 11 Fedora Update System 2017-10-25 18:26:37 UTC
cri-o-1.0.1-1.git64a30e1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a76e145110

Comment 12 Fedora Update System 2017-10-26 01:34:15 UTC
cri-o-1.0.1-1.git64a30e1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-28a4b68ae4

Comment 13 Fedora Update System 2017-10-27 18:48:27 UTC
cri-o-1.0.1-2.git64a30e1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a76e145110

Comment 14 Ed Santiago 2017-10-30 17:53:44 UTC
cri-o-1.0.1-2.git64a30e1.fc27.x86_64 : See comment 9.

Comment 15 Fedora Update System 2017-11-01 00:08:46 UTC
cri-o-1.0.1-1.git64a30e1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-11-11 02:57:39 UTC
cri-o-1.0.0-6.gita636972.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2017-11-11 03:05:35 UTC
cri-o-1.0.1-2.git64a30e1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.