Bug 1504512

Summary:	Review Request: classifier - Organize files in your current directory, by classifying them into folders of music, pdfs, images, etc.
Product:	[Fedora] Fedora	Reporter:	Omar Berroteran <omarberroteranlkf>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dsupriadi, eclipseo, package-review, williamjmorenor
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-02 00:45:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Omar Berroteran 2017-10-20 05:02:39 UTC

Spec URL: https://lkf.fedorapeople.org/classifier.spec
SRPM URL: https://lkf.fedorapeople.org/classifier-2.0-1.fc26.src.rpm
Description: Organize files in your current directory, by classifying them into folders of music, pdfs, images, etc.
Fedora Account System Username: lkf

Comment 1 Robert-André Mauchin 🐧 2017-10-22 16:31:59 UTC

Hello,

 - I don't think you should provide both python2 and python3 versions: this is a binary, not a library. Remove the subpackages and keep the main to compile with Python 3.

 - You mustn't include a license file if upstream hasn't provided one. What you could do is extract the LICENSE from the README:

sed -e '0,/^## The MIT License/d' README.md > LICENSE

 - Split your description to stay below 80 characters per line

 - You must add the version in the %changelog:

* Fri Sep 15 2017 Nadie LKF Omar Berroteran Silva <omarberroteranlkf> - 2.0-1

 - Use:

Source0:       https://github.com/bhrigu123/classifier/archive/%{commit}/%{name}-%{version}.tar.gz 

 - You should probably report the failing tests upstream.

Comment 2 William Moreno 2018-03-16 19:54:35 UTC

Fedora review run fine with this package. will upload results soon.

Comment 3 Package Review 2021-04-25 00:45:32 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Package Review 2021-06-04 00:46:09 UTC

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 5 Package Review 2021-10-02 00:45:51 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.