Description of problem:
Backport "Do not build with -Winline" to avoid unnecessary warnings.
We need to backport this patch.
commit ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802
Author: Florian Weimer <fweimer>
Date: Fri Apr 24 11:10:24 2015 +0200
Do not build with -Winline
-Winline causes architecture- and optimization-dependent build failures
due to -Werror. -Winline warns about inlining decisions based on
branch hints, in effect preventing the use of inline functions in
header files (because they might be called on unlikely branches, leading
to a decision not to inline).
The option was apparently added to the glibc build at a time when GCC
did not support the always_inline attribute. With current GCC versions,
inlining failure for functions declared always_inline will receive a
warning under -Wattributes, which is enabled by default, so -Winline
appears unnecessary.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
(In reply to Florian Weimer from comment #1)
> Should we backport -Werror? I already added
> -Werror=implicit-function-declaration a while back.
This is an internal request, and it has some value to us, but given we have some upstream goals we want to accomplish, I'd say the value would have to be high and it would have to be straight forward for us to do it in the upcoming release.
How much work do you estimate this is?
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2018:3092
Description of problem: Backport "Do not build with -Winline" to avoid unnecessary warnings. We need to backport this patch. commit ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802 Author: Florian Weimer <fweimer> Date: Fri Apr 24 11:10:24 2015 +0200 Do not build with -Winline -Winline causes architecture- and optimization-dependent build failures due to -Werror. -Winline warns about inlining decisions based on branch hints, in effect preventing the use of inline functions in header files (because they might be called on unlikely branches, leading to a decision not to inline). The option was apparently added to the glibc build at a time when GCC did not support the always_inline attribute. With current GCC versions, inlining failure for functions declared always_inline will receive a warning under -Wattributes, which is enabled by default, so -Winline appears unnecessary. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: