Hide Forgot
glibc-rh1268008-19.patch has a crucial difference compared to upstream: - strcpy(s1, L("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrs")); - strcpy(s2, L("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkLMNOPQRSTUV")); + STRCPY(s1, L("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrs")); + STRCPY(s2, L("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkLMNOPQRSTUV")); This results in a compile-time type error: In file included from test-wcsncmp.c:2:0: ../string/test-strncmp.c: In function 'check1': ../string/test-strncmp.c:362:3: warning: passing argument 1 of 'strcpy' from incompatible pointer type [enabled by default] strcpy(s1, L("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrs")); ^ As a result, test coverage is reduced. We need to fix this before we can enable -Werror.
It turns out the patch set for bug 1268008 has more such issues.
Just to be clear: This is a test-only fix. But it is probably a good idea to re-run the tests on z13 s390x hardware nevertheless.
Created attachment 1419302 [details] Further fixes in string/wcsmbs tests compared to upstream version ------- Comment on attachment From STLI@de.ibm.com 2018-04-09 09:31 EDT------- Indeed. In the tests/benchtests are several issues. I've applied the attached patch on top of glibc-2.17-222.el7.src.rpm. Now I don't see those warnings anymore. I've build the patched src-rpm on 31/64bit on a z14 machine (Note: there are no specific z14 variants, thus the z13 string functions are used). The string/wcsmbs tests are clean.
------- Comment From mgrf@de.ibm.com 2018-07-31 08:38 EDT------- Closing on IBM side - received confirmation that this is verified ok on RHEL 7.6 alpha .... installed RHEL 7.6 Alpha 1 and rebuild the RPM packages to check whether the corresponding string tests run without fails. Please set the status to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3092