Bug 1505533

Summary: Review Request: rubygem-oj - The fastest JSON parser and object serializer.
Product: [Community] RDO Reporter: Martin Magr <mmagr>
Component: Package ReviewAssignee: Matthias Runge <mrunge>
Status: CLOSED CURRENTRELEASE QA Contact: hguemar
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: trunkCC: mrunge
Target Milestone: ---Flags: mrunge: rdo-review+
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-21 10:29:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1505536    

Description Martin Magr 2017-10-23 19:43:56 UTC 
Spec URL: https://github.com/centos-opstools/rubygem-oj/blob/master/rubygem-oj.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-oj/2.18.1/1.el7/src/rubygem-oj-2.18.1-1.el7.src.rpm
Description: A fast JSON parser and Object marshaller as a Ruby gem.
Comment 1 Matthias Runge 2017-10-24 07:09:21 UTC 
SPEC: https://raw.githubusercontent.com/centos-opstools/rubygem-oj/master/rubygem-oj.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-oj/2.18.1/1.el7/src/rubygem-oj-2.18.1-1.el7.src.rpm
Comment 2 Matthias Runge 2017-10-24 08:59:19 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Pure Ruby package must be built as noarch
- Header files in -devel subpackage, if present.
  Note: rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/buf.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/cache8.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/circarray.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/encode.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/err.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/hash.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/odd.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/oj.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/parse.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/reader.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/resolve.h
  rubygem-oj-debugsource : /usr/src/debug/rubygem-
  oj-2.18.1-1.fc28.x86_64/usr/share/gems/gems/oj-2.18.1/ext/oj/val_stack.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package contains Requires: ruby(release).


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated".
     79 files have unknown license. Detailed output of licensecheck in
     /home/mrunge/fedora/1505533-rubygem-oj/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gems,
     /usr/share/gems/doc
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id(kde-
     platform-plugin, libmad, libhbalinux, cups-client, efivar-libs,
     netcdf, rsyslog, xml-security-c, policycoreutils-python-utils, qemu-
     block-gluster, rpm-plugin-selinux, abrt, libmediaart, neomutt,
     libimagequant, giflib, libreoffice-graphicfilter, perl-GSSAPI,
     trousers, dirac-libs, nethogs, libdb-utils, tracker-miners, xorg-x11
     -font-utils, PackageKit-command-not-found, OpenEXR-libs, libcom_err,
     libseccomp, double-conversion, icoutils, p11-kit, fcgi, libabw,
     gtkspell, libvirt-daemon-driver-storage-iscsi, libid3tag, libmodman,
     telepathy-gabble, cfitsio, argyllcms, parted, gnome-disk-utility,
     libdvdread, zstd, kwin, bluez-libs, gnome-power-manager, texlive-
     xetex-bin, libwebp, libxslt, boost-python, netty-tcnative, system-
     config-printer-udev, perl-Encode, elfutils, python2-cryptography,
     kf5-kdeclarative, libevdev, libgpg-error, lvm2-libs, kf5-sonnet-core,
     perl-Digest-SHA, perl-Params-Classify, libmicrohttpd, libsodium,
     kf5-solid, libzstd, wxBase, xdg-desktop-portal-gtk,
     python3-sqlalchemy, symlinks, python3-simplejson, libzip,
     b43-fwcutter, e2fsprogs-libs, pulseaudio-libs, lcms2, docker-rhel-
     push-plugin, qemu-guest-agent, ntfs-3g, libxcb, freexl, libyubikey,
     gnome-photos, python3-pycurl, python3-brlapi, openconnect, rtkit, xcb-
     util-keysyms, angelscript, m4, libgsystem, sushi, libgphoto2, autogen,
     rubygem-unf_ext, perl-Moose, tinyxml, xcb-util, libwmf-lite, boost-
     fiber, kdepimlibs-gpgme, python3-coverage, rawtherapee, weechat,
     anaconda-widgets, dleyna-renderer, http-parser, file-roller-nautilus,
     perl-Sub-Identify, calligra-sheets-libs, kf5-kdelibs4support-libs,
     texlive-pdftex-bin, pyorbit, libeot, ImageMagick-c++, oci-register-
     machine, uniconvertor, kf5-kpackage, perl-JSON-XS, kf5-kfilemetadata,
     perl-Ref-Util-XS, gperf, perl-Time-Piece, dbusmenu-qt, qca-qt5,
     ncurses-libs, libidn2, ldns, perl-Sys-Syslog, gnome-color-manager,
     fcoe-utils, xorg-x11-xkb-utils, ibus-hangul, perl-IO-Tty,
     NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, freerdp-
     libs, xmlrpc-c-client, cheese, libwpg, libwpd, libdc1394, libvirt-
     daemon-driver-qemu, perl-Time-HiRes, qemu-block-ssh, libwps, gssdp,
     cln, clucene-contribs-lib, gnome-calendar, kactivitymanagerd, libacl,
     gnutls-utils, uwsgi-plugin-cache, xorg-x11-drv-ati, kf5-solid-libs,
     gedit-plugin-wordcompletion, libSM, policycoreutils, mcelog, abrt-
     plugin-bodhi, libgdiplus, libmusicbrainz5, pptp, caribou,
     libXxf86misc, foomatic, minizip, colord-gtk, libsoup, konsole5-part,
     libicu-devel, gloox, rpm-build, libvirt-daemon-driver-storage-
     sheepdog, libglvnd-gles, redhat-lsb-core, setroubleshoot, zerofree,
     freeglut, gstreamer1, bsdtar, gom, msgpack, unbound, freeciv, gmime30,
     libtomcrypt, ccache, sshpass, libreoffice-gtk3, libreoffice-gtk2,
     librtmp, cairo-gobject, gnome-screenshot, gutenprint, openal-soft,
     usermode, libfbclient2, qpdf-libs, linux-atm-libs, pyparted, libedit,
     calligra-words-libs, java-1.8.0-openjdk-devel, ceph-fuse, subversion-
     libs, atk, python3-cairo, accountsservice, isl, hfsplus-tools,
     ImageMagick, perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-btrfs,
     libatomic_ops, opencv-core, libmpcdec, rubygem-io-console, qpid-cpp-
     client, gnome-python2-canvas, kf5-kxmlgui, python3-iscsi-initiator-
     utils, evince-browser-plugin, libvirt-daemon-driver-interface,
     NetworkManager, libkate, liblangtag, NetworkManager-glib, libdatrie,
     tmate, glade-libs, setuptool, libiscsi, libcryptui, kscreenlocker,
     guile, pcre-utf16, tree, python33, gvfs-goa, pipewire, glusterfs-libs,
     gnupg, python34, cronie-anacron, libserf, xfsprogs, libhbaapi, boost-
     timer, libcroco, python2-zmq, qt5-qtsensors, spice-server, telepathy-
     glib, plymouth-plugin-label, wildmidi-libs, colord-libs, aalib-libs,
     perl-Unicode-Collate, efivar, gpgmepp, libgcab1, gvnc, librsync, perl-
     Unicode-LineBreak, libtranslit-m17n, hypervfcopyd, cronie,
     libexttextcat, libjpeg-turbo-utils, kdelibs, authconfig,
     qt5-qtquickcontrols, gsl, nettle, libcacard, qdbm, colord,
     libpipeline, pkcs11-helper, accountsservice-libs, postgresql-server,
     ufraw, gtk-sharp2, gnome-system-monitor, findutils, popt, plasma-
     desktop, qt5-qtx11extras, libsss_idmap, posterazor, libraw1394, boost-
     atomic, perl-Data-UUID, folks, gcc-c++, python3-dbus, iproute-tc,
     libipa_hbac, gamin, kreport, spice-glib, python2-numpy, dotconf,
     luajit, libXfont, libtimezonemap, PackageKit-glib, patch, sqlite-libs,
     lttng-ust, xcb-util-cursor, enchant, kf5-plasma, libXxf86dga, rhash,
     xdg-user-dirs-gtk, texlive-makeindex-bin, libwayland-client, kf5-kio-
     file-widgets, libsmbios, gstreamer-plugins-bad-nonfree, libipt, mdadm,
     openblas-threads, python2-zope-interface, python2-msgpack, device-
     mapper, ldns-utils, python2-librepo, libXtst, xapian-core-libs, uwsgi-
     plugin-python, kf5-kbookmarks, perl-Text-Soundex, gnome-terminal,
     GeoIP, GraphicsMagick, libsigc++20, python2-talloc, libXrandr, newt,
     liba52, hplip, mariadb-common, qt5-qtwebsockets, intel-cmt-cat, crda,
     libical, sheepdog, qt5-qtdeclarative, 0ad, vo-amrwbenc,
     qt5-qtquickcontrols2, libofa, libXfont2, libblockdev-loop, libmfx,
     libssh2, NetworkManager-adsl, open-vm-tools-desktop, samba-dc-libs,
     dbusmenu-qt5, libXcursor, iio-sensor-proxy, lua-lpeg, webkitgtk4
     -plugin-process-gtk2, procps-ng, plymouth-core-libs, telnet, simple-
     scan, libXpm, phonon-backend-gstreamer, xorg-x11-drv-nouveau, texlive-
     gsftopk-bin, bluez-obexd, zlib, libpeas, pam_krb5, gutenprint-cups,
     PackageKit-gstreamer-plugin, avahi, libselinux, libotf, ncurses-
     compat-libs, libassuan, nodejs, onesixtyone, expat, cups-filters, iw,
     clutter-gtk, python2-psycopg2, userspace-rcu, libblockdev-utils,
     wavpack, libbsd, ibus-libpinyin, setroubleshoot-server, calligra-
     stage-libs, make, python3-markupsafe, texlive-bibtex-bin, libnice,
     libcdr, tracker, perl-Pango, jxrlib, glusterfs-api, i3, fuse, perl-
     Net-SSLeay, perl-Filter, ImageMagick-perl, cups-libs, calligra-words,
     libappstream-glib, libsepol, totem-pl-parser, gzip, autogen-libopts,
     keyutils, isomd5sum, goocanvas, libfdisk, libdmx, qt5-qtscript,
     openssl-libs, corosynclib, python2-wsaccel, dconf-editor, libreport-
     plugin-reportuploader, python-dmidecode, libguestfs-tools-c, gavl,
     gnome-packagekit-common, ipset, boost-chrono, libselinux-python3,
     kf5-kcoreaddons, unique, keybinder3, deltarpm, kf5-kjsembed, fuse-
     libs, kf5-attica, xorg-x11-xauth, libglvnd-glx, gvfs-smb, gtkspell3,
     libcue, libXrender, json-glib, kf5-kglobalaccel, libX11-xcb,
     libfontenc, libicu, libgsf, xorg-x11-drv-vmware, NetworkManager-
     openconnect, libgtop2, btrfs-progs, bind99-libs, python3-mistune,
     wvdial, mokutil, protobuf-c, xerces-c, mesa-libglapi, glx-utils,
     libtommath, postgresql, evolution-data-server, PackageKit,
     kf5-kemoticons, perl-MIME-Base64, mbrowse, polkit-qt5-1, libass,
     boost-math, wpa_supplicant, texlive-lib, perl-Sub-Name, setools-
     python3, git, uwsgi-plugin-common, libcrystalhd, perl-Sane, jack-
     audio-connection-kit, mpg123-libs, opus, libselinux-python, ctags,
     git-core, libreport-python, traceroute, PackageKit-gtk3-module, kde-
     style-breeze, libblockdev-crypto, kf5-karchive, libreoffice-pdfimport,
     rp-pppoe, qqwing-libs, kf5-threadweaver, attr, mtr, libblockdev-part,
     pugixml, plymouth, libcanberra-gtk3, kf5-ki18n, boost-program-options,
     gstreamer1-plugins-bad-free-gtk, mtdev, mailx, libmspack, systemd-
     udev, golang, fftw-libs-single, libXvMC, python3-pygpgme, jsoncpp,
     llvm, cheese-libs, kdepimlibs-kxmlrpcclient, tix, python2-pillow,
     libXmu, python2-crypto, texlive-dvipng-bin, libconfuse, jasper-libs,
     python-mistune, gnome-python2-gnomekeyring, librbd1, device-mapper-
     libs, xorg-x11-xinit, gnome-initial-setup, libffi, libGLEW, pcre-
     utf32, python2-hawkey, diffutils, libgnomecanvas, gedit-plugin-
     bookmarks, time, checkpolicy, glibc, mpfr, telepathy-mission-control,
     kf5-knotifyconfig, SuperLU43, cyrus-sasl-md5, iputils, kate4-part,
     numactl-libs, libvirt-daemon-driver-nwfilter, gvfs-fuse, tigervnc-
     server-minimal, gpgme, hypervvssd, polari, xorg-x11-drv-openchrome,
     libcapsimage, libmcpp, libibverbs, devhelp-libs, mpg123, gdb-headless,
     dleyna-core, qemu-block-nfs, libgovirt, libqmi-utils, libmbim-utils,
     psacct, ldc-druntime, lame-libs, pycryptopp, gnome-bluetooth-libs,
     bijiben, usbredir, libtirpc, iptables-libs, fftw, cryptsetup-libs,
     syslinux-extlinux, bind-libs, pygobject2, boost-type_erasure, mesa-
     libwayland-egl, ghostscript-x11, lua-posix, libinput, kf5-syntax-
     highlighting, xcb-util-xrm, libreport-cli, libpkgconf, mono-core,
     python3-dmidecode, abrt-gui-libs, boost-test, gegl,
     qt5-qtconnectivity, libosinfo, libabigail, corosync, qt5-qtsvg,
     libreoffice-calc, sni-qt, libqmi, gawk, dmraid-events, pcsc-lite-libs,
     adwaita-gtk2-theme, libbasicobjects, plasma-integration, kdelibs-
     webkit, hdf5, sane-backends-drivers-cameras, baobab, rdma-core,
     libgnomeui, vte291, libgweather, nmap, libspatialite, libgrss, gedit-
     plugin-findinfiles, httpd, libsmbclient, pulseaudio-utils,
     python2-reportlab, sane-backends-daemon, libvdpau, compat-openssl10,
     perl-Guard, texlive-metafont-bin, opencore-amr, recordmydesktop, dbus-
     python, abrt-addon-kerneloops, gnome-system-log, gnome-maps, libgta,
     tilix, kf5-kidletime, perl-Email-Address-XS, openCOLLADA, xcb-util-
     renderutil, libwinpr, qt5-qtserialport, gpsd-libs, python2-Bottleneck,
     libpinyin, freetype, logrotate, rdist, libkadm5, libdnet, ntfsprogs,
     appstream-qt, abrt-libs, protobuf, efibootmgr, emacs-nox, libgdither,
     boost-signals, systemd-bootchart, samba-common-libs, libfdt, libpsl,
     wxGTK, mpg123-plugins-pulseaudio, zeitgeist-libs, python2-rjsmin,
     python3-rpm, librcc, nautilus-sendto, tali, fwupdate-libs, jimtcl,
     libuser, lz4-libs, graphviz, abrt-retrace-client, geos-python, boost-
     date-time, anjuta, mythes, libglade2, satyr, gts, pixman, gnome-font-
     viewer, kf5-kparts, perl-Cairo, xorg-x11-drv-vesa, libbluray,
     python2-coverage, brltty, net-snmp-utils, libstdc++, libbabeltrace,
     mjpegtools-libs, vpnc, psmisc, net-snmp-libs, ppp, xorg-x11-drv-
     libinput, libiodbc, libblockdev-mpath, ed, libgit2-glib, libgcc,
     gdisk, ilmbase, perl-Compress-Bzip2, python3-zmq, poppler, pocl,
     libstemmer, djvulibre-libs, gnome-online-accounts, uwsgi, fftw-libs-
     double, avahi-gobject, net-tools, ModemManager, abrt-gui, ibus-m17n,
     qemu-img, qt5-qtbase-gui, python2-sysv_ipc, sgpio, orc, perl-Compress-
     Raw-Bzip2, polkit, qt-devel, libuuid, faad2-libs, libarchive,
     libfreehand, ibus-gtk3, ibus-gtk2, xorg-x11-server-Xvfb, cryptsetup,
     udisks2, rxtx, paps-libs, tcp_wrappers, xz, libXcomposite, vconfig,
     mtools, pygtk2, criu, vim-minimal, harfbuzz-icu, evolution, libplist,
     gstreamer-tools, libmimic, xdg-user-dirs, libdap, kwin-common, perl-
     Glib, hwloc-libs, python3-lazy-object-proxy, libreport-plugin-logger,
     gdk-pixbuf2, gupnp, libreport, libevent, redland, python2-cccolutils,
     tcpdump, gnome-characters, postfix, yubikey-personalization-gui,
     control-center, opencv-contrib, libxklavier, libblockdev, librdmacm,
     lua-socket, dconf, xz-libs, dbus-glib, cyrus-sasl-plain, bash, libmpc,
     libdvdnav, libcap, libvirt-daemon-driver-storage-zfs, libspnav,
     libwbclient, kmod, kf5-kio-widgets-libs, libvirt-daemon-driver-
     storage-gluster, numad, libbonobo, mod_http2, eclipse-platform,
     libthai, perl-NKF, gnome-code-assistance, fakeroot, gnome-session,
     ibus-chewing, libini_config, nss-tools, kf5-kglobalaccel-libs, ORBit2,
     gdal-libs, iproute, python2-simplejson, python2-gpg, libsmartcols,
     gsound, konsole5, fakeroot-libs, oci-systemd-hook, mariadb-devel,
     leptonica, python3-hawkey, os-prober, libtheora, ethtool,
     libreofficekit, texlive-mfware-bin, devhelp, libfprint, systemd-libs,
     cpio, clang, notmuch, util-linux, xmountains, krb5-libs, bison,
     libconfig, kf5-kjobwidgets, chrony, enca, freeimage, python3-qt5,
     collectd, gtksourceview3, libpciaccess, clucene-core, compiler-rt,
     NetworkManager-ssh-gnome, libxml++, NetworkManager-pptp, libetonyek,
     libcanberra-gtk2, uwsgi-plugin-gevent, rubygem-ruby-libvirt, libgnome,
     gnome-user-share, sssd-client, libgxps, systemd, kf5-kiconthemes, js,
     libpagemaker, libreport-plugin-bugzilla, kf5-kitemviews, CharLS,
     libxkbcommon, miniupnpc, device-mapper-multipath-libs, perl-XML-
     LibXML, yajl, lockdev, kdesu, cups-filters-libs, kf5-knotifications,
     geocode-glib, lpsolve, gnome-terminal-nautilus, qt5-qdbusviewer,
     xorg-x11-server-utils, gnupg2, gocr, pypy-libs, cracklib, evince-libs,
     python2-tkinter, libdnf, kdiagram, ruby, libgdl, abrt-addon-
     pstoreoops, gnome-keyring, perl-Encode-JIS2K, pulseaudio-libs-glib2,
     rubygem-nokogiri, libnice-gstreamer1, netpbm, qtsoap, nm-connection-
     editor, python-xpyb, python3-pyparted, libudisks2, gstreamer1-plugins-
     bad-free, clutter, kf5-kholidays, zenity, qconf, chkconfig, libgnome-
     keyring, hostname, iscsi-initiator-utils, check, gparted, librados2,
     libvirt-daemon-driver-storage-mpath, libcdaudio, subunit, pam,
     python2-cffi, unixODBC, sane-backends-drivers-scanners, libkscreen-
     qt5, openldap, zziplib, evince-nautilus, kf5-ktexteditor, ipcalc, SDL,
     speex, libvirt-daemon-driver-storage-logical, ibus-wayland, neon,
     rest, libsamplerate, python2-lxml, ldc-phobos, newt-python3, samba-
     libs, boost-iostreams, poppler-utils, abrt-addon-xorg, pakchois,
     lapack, subversion, zfs-fuse, libusbmuxd, gnome-packagekit-installer,
     perl-Unicode-Normalize, gperftools-libs, libimobiledevice, lzop,
     NetworkManager-wwan, libreport-python3, polkit-pkla-compat, moc,
     boost-numpy, libmtp, cyrus-sasl-lib, librevenge, hexchat, nspr, gjs,
     python3-gobject-base, perl-Gtk2, perl-Bit-Vector, gnome-settings-
     daemon, gnupg2-smime, dnsmasq, geoclue2-libs, libXfixes, libblkid,
     qemu-block-rbd, libcdio, gnome-music, qpid-proton-c, rsync, rpm,
     webkitgtk4-jsc, redis, lua-libs, abrt-addon-coredump-helper,
     soundtouch, xorg-x11-drv-evdev, libpeas-gtk, libXinerama, khotkeys,
     libteam, vim-enhanced, libcmis, qt5-qttools, elfutils-libs, osm-gps-
     map, pcmciautils, perl-Image-Sane, acl, cyrus-sasl-scram, libogg,
     xorg-x11-apps, gupnp-igd, kf5-kinit, gstreamer-plugins-base,
     kf5-khtml, libgee, libXxf86vm, mesa-libEGL, perl-Gtk2-ImageView, rpm-
     plugin-systemd-inhibit, systemd-pam, python2-libvirt, emacs, perl-
     Storable, perl-Digest-MD5, libreoffice-ogltrans, libshout, soprano,
     gnome-python2-bonobo, perl-Sort-Key, libvirt-daemon-driver-storage-
     rbd, libnfsidmap, nss-util, libsemanage, marisa, arpack, mozjs52,
     systemd-container, libcomps, libaec, at, file, libdca, libblockdev-fs,
     java-1.8.0-openjdk-headless, ncdu, libnma, gettext, soxr, espeak, oci-
     umount, libverto-tevent, python-cheetah, libutempter, libmetalink,
     java-1.8.0-openjdk, libref_array, gnome-keyring-pam, cryptopp,
     usbutils, e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp,
     libksba, kdecoration, libwayland-server, virglrenderer, dracut, gdbm,
     osinfo-db-tools, libsndfile, perl-Encode-EUCJPASCII, deja-dup,
     libproxy-mozjs, tk, ruby-libs, bzip2-libs, dbus-libs, teckit,
     qt5-qtxmlpatterns, boost-log, gnutls, ncftp, jack-audio-connection-
     kit-example-clients, boost-wave, kf5-kpeople, SuperLU, device-mapper-
     persistent-data, telepathy-idle, ykpers, sofia-sip-glib, libselinux-
     utils, perl-Scalar-List-Utils, kf5-networkmanager-qt, dosfstools, rng-
     tools, perl-Sys-Guestfs, gnome-abrt, libspectre, gstreamer-plugins-
     bad-free-extras, compat-openssl10-pkcs11-helper, keyutils-libs, gdal-
     python, libproxy, libreoffice-math, memcached, audit-libs-python3,
     perl-Data-Dumper, glusterfs-fuse, kf5-kpty, vala, python-rgw,
     kf5-kded, gstreamer-ffmpeg, jffi-native, anaconda-core,
     python2-sqlalchemy, perl-Goo-Canvas, qt5-qttools-libs-help,
     libkworkspace5, tesseract, plasma-pa, glusterfs-client-xlators,
     libatasmart, perl-XML-Parser, mlocate, tmux, file-libs, grub2-tools,
     perl-Locale-gettext, avahi-glib, python2-pandas, libva, libblockdev-
     swap, libnetfilter_conntrack, python3-gobject, libev, qca, frei0r-
     plugins, python2-netifaces, fprintd-pam, libgepub, libusbx, polkit-
     gnome, NetworkManager-openvpn-gnome, qrencode-libs, NetworkManager-
     ssh, libICE, libgexiv2, drpm, xsane, createrepo_c-libs, kf5-kio-core,
     grilo, perl-Compress-Raw-Zlib, speexdsp, upower, openssh, dee,
     libreoffice-x11, nautilus, xcb-util-wm, openssl, socat, gnome-vfs2,
     rhythmbox, PackageKit-Qt5, alsa-lib, gitg-libs, libwnck3, x264-libs,
     python2-gobject, gtkmm24, PyYAML, libvirt-daemon-driver-storage-disk,
     brasero-libs, mpage, mesa-dri-drivers, pyliblzma, python3-abrt,
     libffado, suitesparse, python-cephfs, fribidi, libgnomekbd,
     libblockdev-kbd, ibus-rawcode, powertop, pciutils, qt5-qttools-libs-
     designer, openssh-clients, blosc, texstudio, libX11, celt051, beignet,
     htop, kyotocabinet-libs, python3-pwquality, gvfs-mtp,
     python3-cryptography, kdialog, gnome-bluetooth, kwrited, eclipse-
     pydev, libnl3, gimp-libs, libmikmod, gstreamer-plugin-crystalhd,
     libnatpmp, libidn, source-highlight, grubby, openjpeg-libs, epiphany-
     runtime, libbytesize, libmpeg2, powerdevil, python3-systemd,
     libnl3-cli, ibus-libs, gupnp-av, python2-libcomps, kmenuedit, audit-
     libs, bluez, libtiff-tools, gettext-libs, liborcus,
     kf5-kwidgetsaddons, NetworkManager-bluetooth, gvfs-afp, chrpath, gvfs-
     afc, switcheroo-control, fwupd, raptor2, gtk-update-icon-cache,
     plasma-workspace-geolocation, libcrypt-nss, plymouth-plugin-two-step,
     sbc, qt-x11, libsane-hpaio, libhangul, SDL_mixer, python2-tables,
     libbonoboui, ocl-icd, poppler-glib, potrace, libgpod, seahorse,
     environment-modules, perl-autovivification, libblockdev-lvm,
     libopenraw, lvm2, harfbuzz, lash-libs, cups, dmraid, libradosstriper1,
     tokyocabinet, python3-wrapt, gvfs-client, NetworkManager-libnm,
     urlview, python2-libs, ibus-qt, gnome-boxes, gnome-python2-gnome,
     python2-scipy, pulseaudio, lrzsz, libglvnd-egl, libunwind, unbound-
     libs, dhcp-libs, dpkg, libtalloc, calligra-sheets, libtar, ffmpeg,
     dtc, libepoxy, kf5-baloo-libs, kf5-kdelibs4support, perl-Variable-
     Magic, man-db, gedit, fluidsynth, libvirt-daemon-driver-storage-core,
     libzapojit, compat-ImageMagick693-libs, python2-deltarpm, gnome-
     desktop3, liblogging-stdlog, timedatex, fltk, xdg-desktop-portal,
     qt5-qtenginio, kf5-bluez-qt, rasqal, wireless-tools, libdb, plasma-
     workspace-drkonqi, passwd, ImageMagick-djvu, cups-pk-helper, quota,
     kmod-libs, NetworkManager-team, libdv, gutenprint-libs, libreoffice-
     writer, desktop-file-utils, libXdamage, python-libxml2, texlive-tex-
     bin, libmwaw, libusal, sombok, gcc-gdb-plugin, plasma-workspace,
     dleyna-connector-dbus, gtkmm30, libsemanage-python, libgit2,
     qt5-qtmultimedia, stunnel, gobject-introspection, unpaper,
     libpwquality, kf5-knewstuff, fontconfig, patchutils, libblockdev-dm,
     kf5-kservice, python3-sip, meanwhile, protobuf-compiler, evince-djvu,
     a52dec, grep, libdaemon, hypervkvpd, python-gssapi, tcl, rpm-build-
     libs, flatpak, python3-librepo, pkgconf, python2-snappy, vino, json-c,
     kf5-kauth, sed, pygtk2-libglade, jemalloc, perl-threads-shared, gnome-
     python2-gconf, glib-networking, saslwrapper, blas, NetworkManager-
     vpnc-gnome, wol, python3-qt5-base, kpartx, libpng, ghostscript-core,
     sane-backends-libs, python3-pillow, util-linux-user, python35, cyrus-
     sasl, hardlink, libcollection, libgcrypt, cairomm, perl-Unicode-UTF8,
     lash, lasi, python3-numpy, lsof, binutils, libreoffice-impress, gnome-
     online-miners, twolame-libs, gucharmap, adwaita-qt4, avahi-ui-gtk3,
     gnome-shell, xorg-x11-server-Xorg, usbmuxd, libmbim, python2-lz4,
     plasma-workspace-libs, perl-IO, libverto, glibmm24, libXScrnSaver,
     realmd, libmspub, python2-abrt, ncurses, libkml, nfs-utils, graphite2,
     python3-kerberos, perl-List-MoreUtils-XS, perl-version, imlib2,
     libreport-plugin-kerneloops, libde265, libpng12, gstreamer-plugins-
     bad-free, gmp, uriparser, volume_key-libs, cdparanoia-libs, python-
     wrapt, ffmpeg-libs, poppler-qt, alsa-plugins-pulseaudio, perl-
     interpreter, powerline, ebook-tools-libs, libksysguard-common, bluez-
     cups, gimp, rubygem-ffi, libcurl, libsemanage-python3, kf5-kcrash,
     coreutils, python-krbV, libcap-ng, gvfs, dbus-x11, mod_wsgi, deja-dup-
     nautilus, pinentry, libvirt-daemon-driver-storage-scsi, plasma-
     workspace-geolocation-libs, librepo, shapelib, nautilus-extensions,
     kde-cli-tools, qemu-common, docker, gsm, libuv, boost-filesystem,
     libtevent, vte3, kf5-sonnet-ui, libchamplain, libglvnd, gnome-
     documents-libs, texlive-kpathsea-bin, gobject-introspection-devel,
     openttd, boost-system, libpcap, openblas-threads64_, qemu-block-iscsi,
     snappy, libgadu, clutter-gst2, clutter-gst3, libdrm, genisoimage,
     rubygem-bigdecimal, pcre2, shotwell, xmlrpc-c, herqq, perl-
     TermReadKey, qt5-qtwebkit, cogl, rygel, collectd-python, libpng-devel,
     python3-PyYAML, attica, libqhull, eclipse-swt, telepathy-logger,
     gstreamer1-libav, python-subprocess32, libssh, inkscape,
     qt5-qtimageformats, GConf2, newt-python, plasma-milou, proj, pdfpc,
     ttmkfdir, flatpak-libs, fipscheck, mactel-boot, bc, gtk-vnc2, gnome-
     calculator, gnome-packagekit-updater, wget, libqhull_r, libvisio,
     boost-regex, zip, i3status, libreport-web, libgomp, libexif, libvirt-
     daemon-driver-secret, gstreamer1-plugins-bad-freeworld, libgusb,
     glib2, qemu-system-x86-core, ImageMagick-libs, libwmf, pcre2-utf16,
     libmnl, calligra-core, libzmf, perl-FCGI, libmng, nss, pcre,
     libchamplain-gtk, sane-frontends, tcp_wrappers-libs, sane-backends,
     gstreamer1-plugins-base, spax, speech-dispatcher, etcd, qhull, libmpd,
     pciutils-libs, libiptcdata, xorg-x11-utils, libXi, file-roller,
     openjpeg2, flac-libs, libXt, libXv, rubygem-openssl, rpm-libs, info,
     libnfnetlink, polkit-qt, libiec61883, gstreamer, gnome-sudoku, faac,
     boost-context, device-mapper-event, vtable-dumper, gthumb, highlight,
     fftw-libs-quad, lua-filesystem, qt5-qtbase, libguess, marble-astro,
     libpskc, perl-forks, ibus, jwhois, qemu-block-dmg, curl, yelp-libs,
     cmake, gnutls-dane, libdmapsharing, rubygem-json, perl-Tk, fipscheck-
     lib, hivex, scrub, pyxattr, python2-pycurl, dos2unix, paps, python-
     posix_ipc, abrt-tui, ustr, phonon, libdhash, gucharmap-libs, gedit-
     plugin-drawspaces, kf5-frameworkintegration-libs, qpid-cpp-server,
     totem, gedit-code-assistance, gd, gc, gtkd, python3-cups,
     libxshmfence, qemu-block-curl, uboot-tools, libreport-plugin-systemd-
     journal, gstreamer1-plugins-ugly-free, atlas, libcephfs2, unzip, gtk2,
     gtk3, perl-Encode-HanExtra, libv4l, atkmm, npth, perl-Params-Util,
     audit-libs-python, libyaml, ceph-common, plasma-breeze, gspell, kf5
     -kconfig-gui, xcb-util-image, m17n-lib, mozjs17, texlive-xdvi-bin,
     libblockdev-mdraid, glusterfs, exiv2-libs, lensfun, python2-pynacl,
     libunistring, postgresql-libs, gstreamer1-plugins-good-extras, rxvt-
     unicode, dleyna-server, gstreamer1-plugins-good, gmpc, python2-rpm,
     libasyncns, perl-Sys-Virt, python2-pygpgme, device-mapper-multipath,
     c-ares, xmlsec1-openssl, pulseaudio-module-x11, python2-cairo,
     qrencode, gfbgraph, NetworkManager-pptp-gnome, jansson, bind-utils,
     gedit-plugin-zeitgeist, librsvg2, firefox, apr, libsss_nss_idmap,
     gupnp-dlna, trousers-lib, dzen2, webrtc-audio-processing, bcache-
     tools, startup-notification, four-in-a-row, libgeotiff, rfkill,
     libXevie, babl, libstaroffice, pinfo, vinagre, armadillo,
     libqalculate, libtranslit, bubblewrap, perl-Devel-CallChecker, ggz-
     base-libs, gnome-clocks, libtasn1, jbigkit-libs, perl-libintl-perl,
     libe-book, freerdp1.2, alsa-utils, sqlite, tar, sudo, speech-
     dispatcher-espeak, dhcp-client, fprintd, pinentry-gtk, gcc,
     kf5-kcmutils, dwz, xorg-x11-drv-qxl, gcr, python2-psutil, kf5
     -kactivities-libs, ebtables, avahi-libs, qtwebkit, pigz, libquvi,
     sofia-sip, scl-utils, python2-matplotlib-tk, libqb, libao, enet, perl-
     libs, lz4, kbd, perl-hivex, transfig, libreoffice-core, libpath_utils,
     kproperty, libphodav, libwayland-cursor, openvpn, flex, squashfs-
     tools, kf5-kdnssd, gstreamer1-plugins-ugly, xvidcore, libwacom, lzo,
     poppler-qt5, pango, libss, krb5-devel, mod_dnssd, dbus, wdiff, polkit-
     libs, perl-threads, perl-Params-Validate, compat-readline6, pangomm,
     kde-runtime-libs, flickcurl, mpg123-plugins-jack, python-rados, nss-
     sysinit, LibRaw, openni, nss-mdns, geos, python3-cffi, polkit-kde, kf5
     -kio-ntlm, kf5-kwallet-libs, fftw-libs-long, at-spi2-core, libvirt-
     daemon-driver-network, gegl03, kactivities-libs, yum-metadata-parser,
     glibc-common, liblockfile, dmenu, kf5-kcodecs, clang-libs,
     kf5-kwindowsystem, xalan-c, gnome-autoar, lshw, qt5-qtlocation,
     python3-libxml2, libnfs, libgfortran, stoken-libs, gnome-contacts,
     gdm, perl-Text-BibTeX, pypy3, znc, groff-base, python-pwquality, mesa-
     libgbm, libusb, hdparm, openssh-askpass, mesa-libGL, perl-Devel-
     LexAlias, perl-HTML-Parser, abrt-addon-ccpp, libldb, libdfu, python2
     -gobject-base, NetworkManager-vpnc, libmodplug, libvirt-daemon-driver-
     nodedev, libXres, mesa-libOpenCL, libcanberra, kf5-krunner, gvfs-
     archive, kf5-kio-core-libs, grub2-tools-efi, libart_lgpl, libgudev,
     xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba-client-libs,
     perl-Date-Simple, which, x265-libs, samba-client, libaio, lua-expat,
     kio-extras, emacs-common, libquadmath, zbar, texlive-luatex-bin,
     gofed-gofedlib, gvfs-gphoto2, brlapi, strace, thunderbird,
     createrepo_c, python2-markupsafe, python2-ujson, elinks, perl-Proc-
     ProcessTable, libreport-gtk, liboauth, lmdb-libs, kf5-kactivities-
     stats, perl-Template-Toolkit, marble-widget-qt5, xmlsec1, gnome-todo,
     isns-utils-libs, libIDL, libwsman1, openldap-clients, kf5-kitemmodels,
     krb5-workstation, nmap-ncat, woff, libglvnd-opengl, slv2, lksctp-
     tools, libgltf, usb_modeswitch, tbb, pypy, rubygem-psych,
     NetworkManager-wifi, qt, libfastjson, kexec-tools, python-rbd, teamd,
     libvorbis, NetworkManager-openconnect-gnome, rpcbind, pcre-cpp,
     libodfgen, liblouis, kwin-libs, djvulibre, exiv2, iptables, openblas-
     openmp, libestr, qt5-qtwebchannel, lua, perl-PadWalker, zeitgeist,
     qt3, avahi-autoipd, libpeas-loader-python3, llvm-libs, gnome-logs,
     perl-Acme-Damn, ogdi, pulseaudio-module-bluetooth, libvirt-libs,
     kf5-kconfigwidgets, qt5-qtgraphicaleffects, gtkimageview, python-
     saslwrapper, passwdqc, libXft, schroedinger, libattr, gitg, qt5
     -qtbase-devel, perl-DBI, hyphen, python2-matplotlib, gnome-
     python2-gnomevfs, zvbi, webkitgtk4, librcd, gnome-software,
     kf5-kwallet, syslinux, notify-python, caribou-gtk3-module, iptstate,
     glib2-devel, libreport-plugin-ureport, radvd, python3-lxml,
     kf5-kdbusaddons, openpgm, python3-libs, appstream, glusterfs-cli,
     perl-PathTools, ipset-libs, boost-graph, netpbm-progs, wxGTK-gl, kf5
     -kio-widgets, cvs, libksysguard, perl-Devel-Size, plymouth-graphics-
     libs, boost-serialization, mozjs38, gnome-menus, librgw2, libreoffice-
     pyuno, hexedit, libpaper, libxml2, gmime, libreoffice-ure,
     kf5-frameworkintegration, iscsi-initiator-utils-iscsiuio, cyrus-sasl-
     gssapi, libucil, libnm-gtk, mousetweaks, libvirt-daemon, libsecret,
     gtk2-engines, openblas, libnet, p11-kit-trust, dcraw, kf5-kcompletion,
     texlive-dvips-bin, nss-softokn, augeas-libs, libsysfs, pypy3-libs,
     geoclue2, audit, wiiuse, abrt-dbus, boost-locale, gdk-pixbuf2-modules,
     at-spi2-atk, xen-libs, perl-DateTime, nss-pem, vim-common,
     python2-kerberos, less, cifs-utils, libvpx, kf5-baloo, evince, boost-
     coroutine, libnghttp2, python2-systemd, ostree-libs, totem-nautilus,
     libsolv, exempi, libxkbcommon-x11, libmms, libuser-python, libtdb,
     python3-gpg, libXdmcp, origin-clients, perl-Socket, apr-util,
     python2-bcrypt, aspell, libvisual, kf5-kunitconversion, python3,
     python2, kf5-kwayland, minicom, xorg-x11-server-Xwayland, i3lock, nss-
     softokn-freebl, supermin, libftdi, shared-mime-info, httpd-tools,
     SDL2, perl-GD, python2-twisted, libsigsegv, dnssec-trigger, boost-
     thread, perl-Devel-Caller, libunicap, caribou-gtk2-module, grilo-
     plugins, shadow-utils, plasma-systemsettings, boost-random, libcgroup,
     perl-Filesys-Df, libXaw, libXau, netcf-libs, libgdata, phonon-qt5,
     libvirt-client, libspiro, dmidecode, python3-libcomps, phonon-qt5
     -backend-gstreamer, setools-python, libjpeg-turbo, spice-gtk3,
     libmount, spice-vdagent, perl-XML-LibXSLT, xorg-x11-drv-fbdev,
     mariadb-libs, calligra-libs, libavc1394, lldpad, libtiff, ggz-gtk-
     client, samba-common-tools, telepathy-salut, sg3_utils-libs,
     libnotify, kf5-kguiaddons, ima-evm-utils, w3m, mesa-libxatracker,
     slang, cairo, libmx, bind-libs-lite, python3-pygit2, grub2-tools-
     extra, libmp4v2, dbxtool, transmission-common, openssh-server,
     darktable, fluidsynth-libs, mutter, gstreamer-plugins-ugly, taglib,
     libXext, python-qpid-proton, mcpp, ModemManager-glib, bridge-utils,
     ostree, device-mapper-event-libs, kde-runtime, kdelibs-ktexteditor,
     initscripts, hunspell, kf5-kjs, libieee1284, libndp, xorg-x11-drv-
     intel, gstreamer1-plugins-base-tools, libguestfs, telepathy-rakia,
     lsscsi, kf5-ktextwidgets, bzip2, kf5-kconfig-core, kf5-kxmlrpcclient,
     python2-rcssmin, python2-mysql, elfutils-libelf, libchewing, open-vm-
     tools, eclipse-cdt-native, kf5-kdesu, kf5-kdoctools, libavdevice,
     libtool-ltdl, readline, openslp, eog, yelp, libtimidity, supertuxkart,
     abrt-java-connector, passwdqc-lib), /usr/lib/.build-id/6a(libqmi-
     utils, libXres, libxcb, freerdp-libs, opencv-contrib, boost-timer,
     libcroco, ImageMagick-libs, marble-widget-qt5, mtools, perl-
     interpreter, gtkd, policycoreutils-python-utils, nss, djvulibre,
     xorg-x11-apps, systemd, pcre2, notify-python, gnome-software,
     gstreamer1-plugins-base, libvirt-daemon-driver-storage-mpath,
     python2-libs, corosync, iptables, open-vm-tools, libgphoto2, brasero-
     libs, cups, gthumb, plasma-desktop, libnl3-cli, SDL_mixer, perl-
     Filter, kscreenlocker, openal-soft, znc, gnome-keyring, aspell,
     powerdevil, kde-runtime, python33, initscripts, cogl, flatpak,
     python2-gpg, e2fsprogs-libs, glib2, weechat, qt5-qtbase)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Package does not contain Requires: ruby(abi).

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
False positive

[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
     oj-doc , rubygem-oj-debuginfo , rubygem-oj-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[!]: Gem should use %gem_install macro.
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-oj-2.18.1-1.fc28.x86_64.rpm
          rubygem-oj-doc-2.18.1-1.fc28.noarch.rpm
          rubygem-oj-debuginfo-2.18.1-1.fc28.x86_64.rpm
          rubygem-oj-debugsource-2.18.1-1.fc28.x86_64.rpm
          rubygem-oj-2.18.1-1.fc28.src.rpm
rubygem-oj.x86_64: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
rubygem-oj.x86_64: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
rubygem-oj.x86_64: E: useless-provides rubygem(oj)
rubygem-oj.x86_64: W: no-documentation
rubygem-oj.x86_64: E: zero-length /usr/lib64/gems/ruby/oj-2.18.1/gem.build_complete
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_active.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_active_mimic.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_mimic_rails.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/activesupport_datetime_test.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug2.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug3.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug_fast.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug_load.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/crash.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/files.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/foo.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/io.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_after.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_alone.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_as_json.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_before.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_define.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_after.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_before.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_datetime.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_redefine.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/mod.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_compat.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_fast.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_file.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_object.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_saj.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_scp.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_simple.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: non-executable-script /usr/share/gems/gems/oj-2.18.1/test/perf_simple.rb 644 /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_strict.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/rails.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/russian.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/sample.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: non-executable-script /usr/share/gems/gems/oj-2.18.1/test/sample.rb 644 /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/sample_json.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/struct.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_compat.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: script-without-shebang /usr/share/gems/gems/oj-2.18.1/test/test_debian.rb
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_fast.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_file.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_gc.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_hash.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_object.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_saj.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_scp.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_serializer.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_strict.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_various.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_writer.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/write_timebars.rb /usr/bin/env ruby
rubygem-oj-debugsource.x86_64: W: no-documentation
rubygem-oj.src: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
rubygem-oj.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
5 packages and 0 specfiles checked; 54 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: rubygem-oj-debuginfo-2.18.1-1.fc28.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
rubygem-oj-debuginfo.x86_64: W: invalid-url URL: http://www.ohler.com/oj <urlopen error [Errno -2] Name or service not known>
rubygem-oj-doc.noarch: W: invalid-url URL: http://www.ohler.com/oj <urlopen error [Errno -2] Name or service not known>
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_active.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_active_mimic.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/_test_mimic_rails.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/activesupport_datetime_test.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug2.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug3.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug_fast.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/bug_load.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/crash.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/files.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/foo.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/io.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_after.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_alone.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_as_json.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_before.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_define.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_after.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_before.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_rails_datetime.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/isolated/test_mimic_redefine.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/mod.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_compat.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_fast.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_file.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_object.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_saj.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_scp.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_simple.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: non-executable-script /usr/share/gems/gems/oj-2.18.1/test/perf_simple.rb 644 /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/perf_strict.rb /usr/bin/env ruby -wW1
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/rails.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/russian.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/sample.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: non-executable-script /usr/share/gems/gems/oj-2.18.1/test/sample.rb 644 /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/sample_json.rb /usr/bin/env ruby -wW2
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/struct.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_compat.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: script-without-shebang /usr/share/gems/gems/oj-2.18.1/test/test_debian.rb
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_fast.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_file.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_gc.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_hash.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_object.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_saj.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_scp.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_serializer.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_strict.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_various.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/test_writer.rb /usr/bin/env ruby
rubygem-oj-doc.noarch: E: wrong-script-interpreter /usr/share/gems/gems/oj-2.18.1/test/write_timebars.rb /usr/bin/env ruby
rubygem-oj.x86_64: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
rubygem-oj.x86_64: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
rubygem-oj.x86_64: W: invalid-url URL: http://www.ohler.com/oj <urlopen error [Errno -2] Name or service not known>
rubygem-oj.x86_64: E: useless-provides rubygem(oj)
rubygem-oj.x86_64: W: no-documentation
rubygem-oj.x86_64: E: zero-length /usr/lib64/gems/ruby/oj-2.18.1/gem.build_complete
rubygem-oj-debugsource.x86_64: W: invalid-url URL: http://www.ohler.com/oj <urlopen error [Errno -2] Name or service not known>
rubygem-oj-debugsource.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 54 errors, 8 warnings.



Requires
--------
rubygem-oj-debuginfo (rpmlib, GLIBC filtered):

rubygem-oj-doc (rpmlib, GLIBC filtered):
    /usr/bin/env
    rubygem-oj

rubygem-oj (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypt.so.1()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libruby.so.2.4()(64bit)
    rtld(GNU_HASH)
    ruby(rubygems)

rubygem-oj-debugsource (rpmlib, GLIBC filtered):



Provides
--------
rubygem-oj-debuginfo:
    debuginfo(build-id)
    rubygem-oj-debuginfo
    rubygem-oj-debuginfo(x86-64)

rubygem-oj-doc:
    rubygem-oj-doc

rubygem-oj:
    rubygem(oj)
    rubygem-oj
    rubygem-oj(x86-64)

rubygem-oj-debugsource:
    rubygem-oj-debugsource
    rubygem-oj-debugsource(x86-64)



Unversioned so-files
--------------------
rubygem-oj: /usr/lib64/gems/ruby/oj-2.18.1/oj/oj.so

Source checksums
----------------
https://rubygems.org/gems/oj-2.18.1.gem :
  CHECKSUM(SHA256) this package     : aed808e326cf7239d0b7709b394d2c1f763182227bd0a92123c00a887085fc90
  CHECKSUM(SHA256) upstream package : aed808e326cf7239d0b7709b394d2c1f763182227bd0a92123c00a887085fc90


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1505533
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6



Please fix the errors in the review.

Not sure if there's really some value in keeping /usr/lib/debug/.build-id bla bla bla, see here: http://cbs.centos.org/koji/rpminfo?rpmID=114259
Comment 3 Martin Magr 2017-11-02 14:44:59 UTC 
SPEC: https://raw.githubusercontent.com/centos-opstools/rubygem-oj/master/rubygem-oj.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-oj/2.18.1/2.el7/src/rubygem-oj-2.18.1-2.el7.src.rpm
Comment 4 Matthias Runge 2017-11-21 10:29:24 UTC 
all my concerns were addressed.