Bug 150562

Summary: missing return statement
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: bashAssignee: Tim Waugh <twaugh>
Status: CLOSED UPSTREAM QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-03-08 13:25:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2005-03-08 12:33:04 UTC 
Description of problem:

I just tried to compile bash-3.0-29 from Redhat Fedora Core development
tree.

The compiler said

bashline.c(2219): warning #1011: missing return statement at end of
non-void function "bash_directory_expansion"

The source code is

static int
bash_directory_expansion (dirname)
     char **dirname;
{
  char *d;

  d = savestring (*dirname);

  if (rl_directory_rewrite_hook)
    (*rl_directory_rewrite_hook) (&d);

  if (rl_directory_completion_hook && (*rl_directory_completion_hook)
(&d))
    {
      free (*dirname);
      *dirname = d;
    }
}

Suggest either add a return statement, or change the return type of 
the function to void.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Tim Waugh 2005-03-08 13:25:02 UTC 
Reported upstream.