Bug 150562 - missing return statement
Summary: missing return statement
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: bash
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-03-08 12:33 UTC by David Binderman
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-03-08 13:25:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2005-03-08 12:33:04 UTC
Description of problem:

I just tried to compile bash-3.0-29 from Redhat Fedora Core development
tree.

The compiler said

bashline.c(2219): warning #1011: missing return statement at end of
non-void function "bash_directory_expansion"

The source code is

static int
bash_directory_expansion (dirname)
     char **dirname;
{
  char *d;

  d = savestring (*dirname);

  if (rl_directory_rewrite_hook)
    (*rl_directory_rewrite_hook) (&d);

  if (rl_directory_completion_hook && (*rl_directory_completion_hook)
(&d))
    {
      free (*dirname);
      *dirname = d;
    }
}

Suggest either add a return statement, or change the return type of 
the function to void.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Tim Waugh 2005-03-08 13:25:02 UTC
Reported upstream.


Note You need to log in before you can comment on or make changes to this bug.