Bug 1506153

Summary:	URL should support clusterserviceclass instead of serviceclass for parameter
Product:	OpenShift Container Platform	Reporter:	XiaochuanWang <xiaocwan>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	aos-bugs, davmarti, jokerman, mmccomas, yapei
Target Milestone:	---
Target Release:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-01 11:28:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description XiaochuanWang 2017-10-25 09:23:39 UTC

Description of problem:
Login on service-catalog env which has clusterserviceclass. Get id by cluster-admin "oc get clusterserviceclass", pass the id to url and open the console /console/?clusterServiceClass=0e991006d21029e47abe71acc255e807, it does not work.

Version-Release number of selected component (if applicable):
Openshift v3.7.0-0.158.0

How reproducible:
Always

Steps to Reproduce:
1. Cluster admin get clusterserviceclass:
$ oc get clusterserviceclass
NAME                                   
0e991006d21029e47abe71acc255e807        

2. Direct to /console/?serviceClass=0e991006d21029e47abe71acc255e807

3. Direct to /console/?clusterServiceClass=0e991006d21029e47abe71acc255e807

Actual results:
2. Could open the clusterserviceclass wizard panel
3. clusterServiceClass is treated as an invalid parameter, wizard panel is not opened

Expected results:
3. Should open the clusterserviceclass wizard panel

Additional info:

Comment 1 Samuel Padgett 2017-10-25 14:47:55 UTC

I think we need to be looking for service class external name now. In which case, it could be ?serviceClassExternalName=

davmarti -- Would you object to that change? The k8s name is not a UID that is not friendly.

At some point we might want to also support namespaced service classes, so I'm not convinced we should prefix it with cluster.

Comment 2 David Martin 2017-10-25 14:57:30 UTC

This change sounds good to me.
No objections

Comment 3 Samuel Padgett 2017-10-25 15:07:01 UTC

Leaning towards ?serviceExternalName= since it's shorter and the OSB API calls them services.

Comment 4 Samuel Padgett 2017-10-25 15:36:00 UTC

https://github.com/openshift/origin-web-console/pull/2375

Comment 5 openshift-github-bot 2017-10-25 16:53:09 UTC

Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/8afbccbfd45b45a032e467fae0851e9eb4aa891e
Bug 1506153 - Use query param serviceExternalName

Change landing page query parameter to `serviceExternalName` and look
for the human external name rather than k8s name, which is a UID.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506153

https://github.com/openshift/origin-web-console/commit/b8c0244277d865a54f686149622b3c27da44b666
Merge pull request #2375 from spadgett/service-query-param

Automatic merge from submit-queue.

Bug 1506153 - Use query param serviceExternalName

Change landing page query parameter to `serviceExternalName` and look
for the human external name rather than k8s name, which is a UID.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506153

@david-martin 

/assign @jwforres

Comment 6 Samuel Padgett 2017-10-25 16:55:52 UTC

Please note we went with `serviceExternalName` per the comments above. The value should be the same as `spec.externalName` in the ClusterServiceClass resource.

Comment 8 Yadan Pei 2017-11-01 08:34:18 UTC

Checked on v3.7.0-0.188.0

Adding ?serviceExternalName=<ClusterServiceClass.spec.externalName> will launch provision panel.


Move to VERIFIED