Red Hat Bugzilla – Bug 1506153
URL should support clusterserviceclass instead of serviceclass for parameter
Last modified: 2017-11-28 03:28:38 EST
Description of problem: Login on service-catalog env which has clusterserviceclass. Get id by cluster-admin "oc get clusterserviceclass", pass the id to url and open the console /console/?clusterServiceClass=0e991006d21029e47abe71acc255e807, it does not work. Version-Release number of selected component (if applicable): Openshift v3.7.0-0.158.0 How reproducible: Always Steps to Reproduce: 1. Cluster admin get clusterserviceclass: $ oc get clusterserviceclass NAME 0e991006d21029e47abe71acc255e807 2. Direct to /console/?serviceClass=0e991006d21029e47abe71acc255e807 3. Direct to /console/?clusterServiceClass=0e991006d21029e47abe71acc255e807 Actual results: 2. Could open the clusterserviceclass wizard panel 3. clusterServiceClass is treated as an invalid parameter, wizard panel is not opened Expected results: 3. Should open the clusterserviceclass wizard panel Additional info:
I think we need to be looking for service class external name now. In which case, it could be ?serviceClassExternalName= davmarti@redhat.com -- Would you object to that change? The k8s name is not a UID that is not friendly. At some point we might want to also support namespaced service classes, so I'm not convinced we should prefix it with cluster.
This change sounds good to me. No objections
Leaning towards ?serviceExternalName= since it's shorter and the OSB API calls them services.
https://github.com/openshift/origin-web-console/pull/2375
Commits pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/8afbccbfd45b45a032e467fae0851e9eb4aa891e Bug 1506153 - Use query param serviceExternalName Change landing page query parameter to `serviceExternalName` and look for the human external name rather than k8s name, which is a UID. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506153 https://github.com/openshift/origin-web-console/commit/b8c0244277d865a54f686149622b3c27da44b666 Merge pull request #2375 from spadgett/service-query-param Automatic merge from submit-queue. Bug 1506153 - Use query param serviceExternalName Change landing page query parameter to `serviceExternalName` and look for the human external name rather than k8s name, which is a UID. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506153 @david-martin /assign @jwforres
Please note we went with `serviceExternalName` per the comments above. The value should be the same as `spec.externalName` in the ClusterServiceClass resource.
Checked on v3.7.0-0.188.0 Adding ?serviceExternalName=<ClusterServiceClass.spec.externalName> will launch provision panel. Move to VERIFIED