Bug 1506241

Summary: Review request: rubygem-fluent-plugin-elasticsearch
Product: [Community] RDO Reporter: Martin Magr <mmagr>
Component: Package ReviewAssignee: Matthias Runge <mrunge>
Status: CLOSED CURRENTRELEASE QA Contact: hguemar
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: trunkCC: mrunge
Target Milestone: ---Flags: mrunge: rdo-review+
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-12 14:26:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1505841    

Description Martin Magr 2017-10-25 13:27:38 UTC 
SRPM URL: https://raw.githubusercontent.com/paramite/code-review/master/rubygem-fluent-plugin-elasticsearch/rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.src.rpm
Spec URL: https://raw.githubusercontent.com/paramite/code-review/master/rubygem-fluent-plugin-elasticsearch/rubygem-fluent-plugin-elasticsearch.spec
Description: ElasticSearch output plugin for Fluent event collector
Comment 1 Matthias Runge 2017-10-26 14:32:31 UTC 
rpmlint ./rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.src.rpm ./rubygem-fluent-plugin-elasticsearch.spec 
rubygem-fluent-plugin-elasticsearch.src:13: W: macro-in-comment %{gem_name}
rubygem-fluent-plugin-elasticsearch.src:13: W: macro-in-comment %{version}
rubygem-fluent-plugin-elasticsearch.src: E: specfile-error warning: Macro expanded in comment on line 13: %{gem_name}-%{version}.gem
rubygem-fluent-plugin-elasticsearch.src: E: specfile-error 
rubygem-fluent-plugin-elasticsearch.src: E: specfile-error warning: Macro expanded in comment on line 13: %{gem_name}-%{version}.gem
1 packages and 1 specfiles checked; 3 errors, 2 warnings.


The error is caused by putting Source0 in comment (for a old location).

Otherwise, the spec looks good, and license is correct.

Unfortunately, I can not get it building on my machine, but it does fine on centos build system.


Package approved.