SRPM URL: https://raw.githubusercontent.com/paramite/code-review/master/rubygem-fluent-plugin-elasticsearch/rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.src.rpm Spec URL: https://raw.githubusercontent.com/paramite/code-review/master/rubygem-fluent-plugin-elasticsearch/rubygem-fluent-plugin-elasticsearch.spec Description: ElasticSearch output plugin for Fluent event collector
rpmlint ./rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.src.rpm ./rubygem-fluent-plugin-elasticsearch.spec rubygem-fluent-plugin-elasticsearch.src:13: W: macro-in-comment %{gem_name} rubygem-fluent-plugin-elasticsearch.src:13: W: macro-in-comment %{version} rubygem-fluent-plugin-elasticsearch.src: E: specfile-error warning: Macro expanded in comment on line 13: %{gem_name}-%{version}.gem rubygem-fluent-plugin-elasticsearch.src: E: specfile-error rubygem-fluent-plugin-elasticsearch.src: E: specfile-error warning: Macro expanded in comment on line 13: %{gem_name}-%{version}.gem 1 packages and 1 specfiles checked; 3 errors, 2 warnings. The error is caused by putting Source0 in comment (for a old location). Otherwise, the spec looks good, and license is correct. Unfortunately, I can not get it building on my machine, but it does fine on centos build system. Package approved.