Bug 1507235

*** Bug 1368911 has been marked as a duplicate of this bug. ***

A few updates made. New spec/srpm:

Spec URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-20171028git05510bb.fc27.src.rpm

Succesful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22761119

A few more fixes and an F27 scratch build here:

https://koji.fedoraproject.org/koji/taskinfo?taskID=22761458

Hello

 - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Any particular reasons for using a development snapshot?

 - Your Release tag must be prefixed:

Release:        1.20171028git%{shortcommit0}%{?dist}

 - Please include tests in %check: https://github.com/Mic92/python-mpd2#testing

 - The Summary/Description is a bit awkward, just use:

Python library providing a client interface for MPD

   It turns out the test are, pardon my French, a PITA. To help you here what you need:

BuildRequires:  python2-mock
BuildRequires:  python2-tox
BuildRequires:  python2-twisted

   And:

BuildRequires:  python3-mock
BuildRequires:  python3-tox
BuildRequires:  python3-twisted


   And the tests themselves:

%check
TOX_TESTENV_PASSENV=PYTHONPATH TOXENV=py27 %{__python2} setup.py test
%if %{with_python3}
TOX_TESTENV_PASSENV=PYTHONPATH TOXENV=py36 %{__python3} setup.py test
%endif

Thanks for the comments and testing commands!

Here are the updated spec/srpms:

Spec URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-2.fc27.src.rpm

I double checked. It isn't a git snapshot, it is a release on Github, and since I'm using the sources from there, the commit information is needed. I've updated the release string now.

Thanks!

   I don't understand, if it's a Release, just use the Release archive?

Source0:        https://github.com/Mic92/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

   And:

%prep
%autosetup -n %{name}-%{version}

   No need for git commit.


   It's late over here, I'll finish the review tomorrow.

Hrm, I was under the impression that the release archives shouldn't be used because they're liable to change without notice - and so the commit archives should be preferred. I can't find it in the docs, though...

Anyway, updated to use the release tag:

Spec URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-3.fc27.src.rpm


Thanks!

(In reply to Ankur Sinha (FranciscoD) from comment #8)
> Hrm, I was under the impression that the release archives shouldn't be used
> because they're liable to change without notice - and so the commit archives
> should be preferred. I can't find it in the docs, though...
> 

I've never heard about that before, all packages I've been reviewing use the release archives.


Package is accepted.

Thanks for the review. I've gone ahead and requested repos now.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mpd2. You may commit to the branch "f27" in about 10 minutes.

python-mpd2-0.5.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c

mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c

mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c

mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c

mpdris2-0.7-5.20171028git3c3fe12.fc26 python-mpd2-0.5.5-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-865887c093

python-mpd2-0.5.5-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7e3b64193

mpdris2-0.7-5.20171028git3c3fe12.fc26, python-mpd2-0.5.5-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-865887c093

mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c

mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

mpdris2-0.7-5.20171028git3c3fe12.fc26, python-mpd2-0.5.5-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.