Bug 1508787
Summary: | CVE-2017-1000382 vim: Ignores umask when creating a swap file [fedora-all] | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andrej Nemec <anemec> |
Component: | vim | Assignee: | Karsten Hopp <karsten> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 26 | CC: | cbuissar, gchamoul, karsten, zdohnal |
Target Milestone: | --- | Keywords: | Security, SecurityTracking |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Release Note | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-11-30 15:32:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1508786 |
Description
Andrej Nemec
2017-11-02 08:54:18 UTC
Use the following template to for the 'fedpkg update' request to submit an update for this issue as it contains the top-level parent bug(s) as well as this tracking bug. This will ensure that all associated bugs get updated when new packages are pushed to stable. ===== # bugfix, security, enhancement, newpackage (required) type=security # testing, stable request=testing # Bug numbers: 1234,9876 bugs=1508786,1508787 # Description of your update notes=Security fix for [PUT CVEs HERE] # Enable request automation based on the stable/unstable karma thresholds autokarma=True stable_karma=3 unstable_karma=-3 # Automatically close bugs when this marked as stable close_bugs=True # Suggest that users restart after update suggest_reboot=False ====== Additionally, you may opt to use the bodhi web interface to submit updates: https://bodhi.fedoraproject.org/updates/new Upstream replies about this issue on vim_dev mailing list: "This is working as intended, Vim does not use umask this way. Umask is only used by simple commands such as cp, not by long running processes that deal with many files. Problem is with the user expectations." IMHO it is correct behavior - when I take Kurt example from http://www.openwall.com/lists/oss-security/2017/10/31/15 , IMO it makes no sense for swp file to have any permissions or have other permissions then 'read' for 'group' and 'other'. Because only user, which opened file, should have access to write into swp file (that means to write into actual file) - 'read' permission is set for other users/groups, so they can open actual file readonly (if they had 'write' permission, collisions and inconsistencies will be made). If this readonly access can be consider as risk, solution which came to mind is (I wrote upstream about it) to have a way how to set file permissions for swap files. If this feature won't meet upstream expectation, I'll close this issue as WONTFIX, because its fixing will diverge from upstream functionality. Upstream created patch 1263, which changes group of swap. They will not fix umask issue, because it is not applicable to complex apps like VIm. |