Bug 1509033

Summary: All Traces helpers are run as commands, even when some of them are not commands.
Product: Red Hat Satellite Reporter: Perry Gagne <pgagne>
Component: katello-tracerAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Perry Gagne <pgagne>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.3.0CC: bbuckingham, ehelms, nkathole, pcreech, sokeefe, sokeeffe, zhunting
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-21 16:54:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1500536, 1531127    
Bug Blocks: 1392013    
Attachments:
Description Flags
Foreman debug none

Description Perry Gagne 2017-11-02 18:36:19 UTC 
Created attachment 1347097 [details]
Foreman debug

Description of problem: Traces has helps that the user can run to resolve the issues it finds. Most of those helps are commands like "systemctl restart <service>" but some of them content sentence to tell the user what to do. For example:

```
You will have to reboot your computer
```

This text will get run as a Remote execution command 


Version-Release number of selected component (if applicable): Sat 6.3.0 


How reproducible: Always


Steps to Reproduce:
1. On a host with traces error navigate to Content Hosts -> select host -> Traces
2. Run a help that contains anything other than a command. For example "please reboot your computer"


Actual results: A Rex command gets run that is successful, but has an error in the output (see BZ 1508951) 


Expected results: Either the user is instructed to manual perform the task, or the remote execution job reboots the computer. 


Additional info:
Comment 2 Satellite Program 2017-11-30 21:21:08 UTC 
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/21572 has been resolved.
Comment 3 Patrick Creech 2017-12-04 19:49:38 UTC 
Sean,

This didn't cherry-pick cleanly, and I'm not that familiar with the codebase.  Could you do the pick for me?

Thanks,
Patrick
Comment 7 Nikhil Kathole 2018-01-05 07:39:00 UTC 
Version tested:
Satellite 6.3 snap 30

1. Navigated to Content Hosts -> select host -> Traces
2. Restart selected where helper having "You will have to reboot your computer"

The remote execution job performs reboot but the job failed due to BZ 1531127.
Adding the dependency of BZ 1531127.
Comment 8 Satellite Program 2018-02-21 16:54:37 UTC 
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> > 
> > For information on the advisory, and where to find the updated files, follow the link below.
> > 
> > If the solution does not work for you, open a new bug report.
> > 
> > https://access.redhat.com/errata/RHSA-2018:0336
Comment 9 Jonathon Turel 2020-05-11 15:42:47 UTC 
*** Bug 1508951 has been marked as a duplicate of this bug. ***