Bug 1510869

Summary:	Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-08 14:04:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2017-11-08 11:01:34 UTC

Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-1.fc28.src.rpm
Description: Legacy Num library for arbitrary-precision integer and rational arithmetic
Fedora Account System Username: rjones

Comment 1 Robert-André Mauchin 🐧 2017-11-08 12:11:29 UTC

Hello,

 - Use a more meaningful name for your archive:

Source0:        https://github.com/ocaml/num/archive/v%{version}/%{name}-%{version}.tar.gz


No other issue, package accepted.

Comment 2 Richard W.M. Jones 2017-11-08 12:23:35 UTC

Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-2.fc28.src.rpm

FWIW I updated the package with the new suggested Source0 URL ^^

Comment 3 Gwyn Ciesla 2017-11-08 12:34:52 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-num

Comment 4 Richard W.M. Jones 2017-11-08 14:04:14 UTC

Built into the f28-ocaml target:

https://koji.fedoraproject.org/koji/taskinfo?taskID=22993003