Bug 1510869 - Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic
Summary: Review Request: ocaml-num - Legacy Num library for arbitrary-precision intege...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-08 11:01 UTC by Richard W.M. Jones
Modified: 2017-11-08 14:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-08 14:04:29 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Richard W.M. Jones 2017-11-08 11:01:34 UTC
Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-1.fc28.src.rpm
Description: Legacy Num library for arbitrary-precision integer and rational arithmetic
Fedora Account System Username: rjones

Comment 1 Robert-André Mauchin 🐧 2017-11-08 12:11:29 UTC
Hello,

 - Use a more meaningful name for your archive:

Source0:        https://github.com/ocaml/num/archive/v%{version}/%{name}-%{version}.tar.gz


No other issue, package accepted.

Comment 2 Richard W.M. Jones 2017-11-08 12:23:35 UTC
Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-2.fc28.src.rpm

FWIW I updated the package with the new suggested Source0 URL ^^

Comment 3 Gwyn Ciesla 2017-11-08 12:34:52 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-num

Comment 4 Richard W.M. Jones 2017-11-08 14:04:14 UTC
Built into the f28-ocaml target:

https://koji.fedoraproject.org/koji/taskinfo?taskID=22993003


Note You need to log in before you can comment on or make changes to this bug.