Bug 1511435
| Summary: | Review Request: R-httpuv - HTTP and WebSocket Server Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-21 23:29:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Elliott Sales de Andrade
2017-11-09 11:08:37 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23010734 There's a RPMlint error, I'm not sure what it means: R-httpuv.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/R/library/httpuv/libs/httpuv.so missing-call-to-setgroups-before-setuid: This executable is calling setuid and setgid without setgroups or initgroups. There is a high probability this means it didn't relinquish all groups, and this would be a potential security issue to be fixed. Seek POS36-C on the web for details about the problem. I know what the problem is; it's because they're bundling an ancient version of libuv. There's a patch here [1] and it was even the subject of a CVE [2]. I hope no-one's trying to run R setuid in the first place, but I'll apply that patch to fix it. Fortunately, they've already bumped the version that's bundled in git and I'm going to try and convince them to allow building against a system copy so I won't have to worry about this anymore. [1] https://github.com/libuv/libuv/pull/215 [2] https://nvd.nist.gov/vuln/detail/CVE-2015-0278 Spec URL: https://qulogic.fedorapeople.org/R-httpuv.spec SRPM URL: https://qulogic.fedorapeople.org/R-httpuv-1.3.5-2.fc26.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23024210 It would be best indeed to use system libuv to avoid such security issues. Package with the patch is accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-httpuv R-httpuv-1.3.5-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-273d319da1 R-httpuv-1.3.5-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a3f0d4f3b R-httpuv-1.3.5-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a3f0d4f3b R-httpuv-1.3.5-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-273d319da1 R-httpuv-1.3.5-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. R-httpuv-1.3.5-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |