Bug 1511435 - Review Request: R-httpuv - HTTP and WebSocket Server Library
Summary: Review Request: R-httpuv - HTTP and WebSocket Server Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-09 11:08 UTC by Elliott Sales de Andrade
Modified: 2017-11-22 02:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-21 23:29:45 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2017-11-09 11:08:37 UTC
Spec URL: http://qulogic.fedorapeople.org//R-httpuv.spec
SRPM URL: http://qulogic.fedorapeople.org//R-httpuv-1.3.5-1.fc26.src.rpm

Description:
Provides low-level socket and protocol support for handling HTTP and
WebSocket requests directly from within R. It is primarily intended as a
building block for other packages, rather than making it particularly easy
to create complete web applications using httpuv alone. httpuv is built on
top of the libuv and http-parser C libraries, both of which were developed
by Joyent, Inc.

Comment 1 Elliott Sales de Andrade 2017-11-09 11:08:48 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=23010734

Comment 2 Robert-André Mauchin 🐧 2017-11-09 13:36:46 UTC
There's a RPMlint error, I'm not sure what it means:

R-httpuv.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/R/library/httpuv/libs/httpuv.so

missing-call-to-setgroups-before-setuid:
This executable is calling setuid and setgid without setgroups or initgroups.
There is a high probability this means it didn't relinquish all groups, and
this would be a potential security issue to be fixed. Seek POS36-C on the web
for details about the problem.

Comment 3 Elliott Sales de Andrade 2017-11-09 20:22:22 UTC
I know what the problem is; it's because they're bundling an ancient version of libuv. There's a patch here [1] and it was even the subject of a CVE [2].

I hope no-one's trying to run R setuid in the first place, but I'll apply that patch to fix it.

Fortunately, they've already bumped the version that's bundled in git and I'm going to try and convince them to allow building against a system copy so I won't have to worry about this anymore.

[1] https://github.com/libuv/libuv/pull/215
[2] https://nvd.nist.gov/vuln/detail/CVE-2015-0278

Comment 5 Robert-André Mauchin 🐧 2017-11-09 21:43:37 UTC
It would be best indeed to use system libuv to avoid such security issues.

Package with the patch is accepted.

Comment 6 Gwyn Ciesla 2017-11-09 22:40:46 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-httpuv

Comment 7 Fedora Update System 2017-11-09 23:21:05 UTC
R-httpuv-1.3.5-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-273d319da1

Comment 8 Fedora Update System 2017-11-09 23:22:05 UTC
R-httpuv-1.3.5-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a3f0d4f3b

Comment 9 Fedora Update System 2017-11-11 17:30:43 UTC
R-httpuv-1.3.5-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a3f0d4f3b

Comment 10 Fedora Update System 2017-11-12 02:40:15 UTC
R-httpuv-1.3.5-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-273d319da1

Comment 11 Fedora Update System 2017-11-21 23:29:45 UTC
R-httpuv-1.3.5-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2017-11-22 02:27:32 UTC
R-httpuv-1.3.5-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.