Bug 1513920
| Summary: | call_stack_t->groups nullity can crash bricks | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Csaba Henk <csaba> |
| Component: | protocol | Assignee: | Csaba Henk <csaba> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | atumball, bugs, ndevos |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-4.1.3 (or later) | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-08-29 03:35:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
REVIEW: https://review.gluster.org/18790 (protocol/server: refactor gid_resolve()) posted (#1) for review on master by Csaba Henk COMMIT: https://review.gluster.org/18789 "libglusterfs: fix the call_stack_set_group() function" was merged to master and it aims to fix this bug too (as above referred change was merged into this one). This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug. |
Description of problem: In certain code paths gid_resolve() can leave the group list in the call stack zero. If some server side function does then a copy_frame() it will cause a crash. Note: current standard server configurations do not expose this issue, but the crash occurs with certain out of tree xlators loaded on a brick. Steps to Reproduce: 1. Compile the sdfs ("server dentry fop serializer") translator that's currently availabe on the experimental branch (https://review.gluster.org/18082) and add it to the brick configuration. 2. run the test case tests/bug/nfs/bug-1053579.t Actual results: Crash. Expected results: Test case succeeds. Additional info: The issue was brought to attention and discussed in the following experimental branch hotfix: https://review.gluster.org/18151