Bug 1513920 - call_stack_t->groups nullity can crash bricks
Summary: call_stack_t->groups nullity can crash bricks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Csaba Henk
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-16 09:46 UTC by Csaba Henk
Modified: 2018-08-29 03:35 UTC (History)
3 users (show)

Fixed In Version: glusterfs-4.1.3 (or later)
Clone Of:
Environment:
Last Closed: 2018-08-29 03:35:19 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Csaba Henk 2017-11-16 09:46:11 UTC 
Description of problem:

In certain code paths gid_resolve() can leave the group list in the call stack zero. If some server side function does then a copy_frame() it will cause a crash.

Note: current standard server configurations do not expose this issue, but the crash occurs with certain out of tree xlators loaded on a brick.

Steps to Reproduce:

1. Compile the sdfs ("server dentry fop serializer") translator that's currently availabe on the experimental branch (https://review.gluster.org/18082) and add it to the brick configuration.
2. run the test case tests/bug/nfs/bug-1053579.t

Actual results:

Crash.

Expected results:

Test case succeeds.

Additional info:

The issue was brought to attention and discussed in the following experimental branch hotfix: https://review.gluster.org/18151
Comment 1 Worker Ant 2017-11-16 11:09:54 UTC 
REVIEW: https://review.gluster.org/18790 (protocol/server: refactor gid_resolve()) posted (#1) for review on master by Csaba Henk
Comment 2 Csaba Henk 2017-12-03 18:20:42 UTC 
COMMIT: https://review.gluster.org/18789 "libglusterfs: fix the call_stack_set_group() function" was merged to master and it aims to fix this bug too (as above referred change was merged into this one).
Comment 3 Amar Tumballi 2018-08-29 03:35:19 UTC 
This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug.
Note You need to log in before you can comment on or make changes to this bug.