Bug 1515051

Summary:	bug-1247563.t is failing on master
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Nithya Balachandran <nbalacha>
Component:	distribute	Assignee:	Nithya Balachandran <nbalacha>
Status:	CLOSED ERRATA	QA Contact:	Prasad Desala <tdesala>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	bugs, nbalacha, ravishankar, rhinduja, rhs-bugs, storage-qa-internal
Target Milestone:	---
Target Release:	RHGS 3.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.2-2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1514329	Environment:
Last Closed:	2018-09-04 06:39:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1514329
Bug Blocks:	1503137, 1515042, 1515045

Description Nithya Balachandran 2017-11-20 04:00:07 UTC

+++ This bug was initially created as a clone of Bug #1514329 +++

Description of problem:
Please see http://lists.gluster.org/pipermail/maintainers/2017-November/003617.html

--- Additional comment from Nithya Balachandran on 2017-11-17 01:10:27 EST ---

On running prove -fv tests/bugs/distribute/bug-1247563.t:

On my system:

 
getfacl: Removing leading '/' from absolute path names
# file: bricks/brick1/backends/patchy3/dir1/FILE2
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a756e6c6162656c65645f743a733000
trusted.SGI_ACL_FILE=0x0000000500000001ffffffff0006000000000002000000000007000000000004ffffffff0004000000000010ffffffff0007000000000020ffffffff00040000
trusted.gfid=0xb597bb42e7bb4b4a91e464e1b536d6d7
trusted.gfid2path.7de510351b1c8e08=0x65393039386432382d346166612d343030372d396230322d3066316463313961666337312f46494c4532
trusted.glusterfs.dht.linkto=0x7061746368792d636c69656e742d3100
trusted.glusterfs.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a756e6c6162656c65645f743a733000


On Ravi's system where the issue is reproducible:


[root@ravi1 backends]# getfattr -e hex  -m . -d   ./patchy3/dir1/FILE2 ; getfacl ./patchy3/dir1/FILE2 
# file: patchy3/dir1/FILE2
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000
system.posix_acl_access=0x0200000001000600ffffffff020007000000000004000400ffffffff10000700ffffffff20000400ffffffff
trusted.SGI_ACL_FILE=0x0000000500000001ffffffff0006000000000002000000000007000000000004ffffffff0004000000000010ffffffff0007000000000020ffffffff00040000
trusted.gfid=0x4fa885df7204439293c32569310ee747
trusted.gfid2path.9db1d06b9f2b8b0a=0x30623737313037312d323435622d343134372d396233302d3463326466383363633639642f46494c4532
trusted.glusterfs.dht.linkto=0x7061746368792d636c69656e742d3100
trusted.glusterfs.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000


There is an ACL (system.posix_acl_access)set on the file which causes the following test to fail.

#The linkto file should not have any posix acls set                                                                                                                  
COUNT=`getfacl $FPATH2 |grep -c "user:root:rwx"`                                   
EXPECT "0" echo $COUNT 


From Google:

..."the XFS filesystem which stores ACLs  as trusted.SGI_ACL_FILE extended  attribute and generates system.posix_acl_access on the fly."


Assuming that this is not an attribute the user space should set on a file, I am stripping this out from the results of the listxattr call in dht_migrate_file.

--- Additional comment from Worker Ant on 2017-11-17 01:45:31 EST ---

REVIEW: https://review.gluster.org/18794 (cluster/dht: Don't set ACLs on linkto file) posted (#1) for review on master by N Balachandran

--- Additional comment from Worker Ant on 2017-11-18 22:06:43 EST ---

COMMIT: https://review.gluster.org/18794 committed in master by \"N Balachandran\" <nbalacha> with a commit message- cluster/dht: Don't set ACLs on linkto file

The trusted.SGI_ACL_FILE appears to set posix
ACLs on the linkto file that is a target of
file migration. This can mess up file permissions
and cause linkto identification to fail.
Now we remove all ACL xattrs from the results of
the listxattr call on the source before setting them
on the target.

Change-Id: I56802dbaed783a16e3fb90f59f4ce849f8a4a9b4
BUG: 1514329
Signed-off-by: N Balachandran <nbalacha>

Comment 6 Prasad Desala 2018-05-07 17:05:22 UTC

Verified this BZ on glusterfs version 3.12.2-7. 
Ran the same test case for 25 iterations and didn't see the issue mentioned in the description.

Moving this BZ to Verified.

Comment 8 errata-xmlrpc 2018-09-04 06:39:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2607