Bug 1515371

Summary: 400 Bad request error when adding ansible playbook catalog item without role enabled
Product: Red Hat CloudForms Management Engine Reporter: luke couzens <lcouzens>
Component: UI - OPSAssignee: mkanoor
Status: CLOSED CURRENTRELEASE QA Contact: luke couzens <lcouzens>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: abellott, cpelland, gmccullo, hkataria, jhardy, mpovolny, obarenbo, yrudman
Target Milestone: GAKeywords: TestOnly
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ansible_embed
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1520613 (view as bug list) Environment:
Last Closed: 2019-02-11 13:53:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Ansible Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1520613    

Comment 6 Harpreet Kataria 2017-12-01 21:36:57 UTC
UI PR to show unavailable options as disabled in drop down: https://github.com/ManageIQ/manageiq-ui-classic/pull/2908

Comment 7 CFME Bot 2017-12-04 17:04:12 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/449896b08e12fff05b202cf79d5b0ef83e9cb8a1

commit 449896b08e12fff05b202cf79d5b0ef83e9cb8a1
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 1 16:26:22 2017 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Dec 1 16:26:22 2017 -0500

    UI changes to show options as disabled if those are not supported.
    
    This PR uses changes from backend in https://github.com/ManageIQ/manageiq/pull/16559 to determine whether options in the drop down should be available or disabled based upon results returned in hash by backend method.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515371

 app/views/catalog/_st_form.html.haml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2017-12-11 18:17:04 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/aca00ba0f6f69707bbb03942fe7c8456bbae931e

commit aca00ba0f6f69707bbb03942fe7c8456bbae931e
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Wed Nov 29 16:02:32 2017 -0500
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Fri Dec 8 14:23:05 2017 -0500

    Catalog Item type list is dependent on installed providers
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515371
    
    Currently we display all catalog item types irrespective of what
    providers are installed in the appliance. This PR links the catalog
    items to different providers and sets the display attribute based
    on the presence of specific provider(s). This would be used by the
    UI to list the valid catalog item types

 app/models/manageiq/providers/base_manager.rb |  4 ++++
 app/models/service_template.rb                |  9 +++++++++
 spec/models/service_template_spec.rb          | 21 +++++++++++++++++++++
 3 files changed, 34 insertions(+)

Comment 10 luke couzens 2018-06-20 11:12:34 UTC
Verified in 5.10