Bug 1520613 - 400 Bad request error when adding ansible playbook catalog item without role enabled
Summary: 400 Bad request error when adding ansible playbook catalog item without role ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.9.0
Assignee: mkanoor
QA Contact: luke couzens
URL:
Whiteboard: ansible_embed
Depends On: 1515371
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-04 20:26 UTC by Satoe Imaishi
Modified: 2018-03-06 15:29 UTC (History)
9 users (show)

Fixed In Version: 5.9.0.13
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1515371
Environment:
Last Closed: 2018-03-06 15:29:34 UTC
Category: ---
Cloudforms Team: Ansible
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 CFME Bot 2017-12-11 18:52:00 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/1c20502be8c4fed237bc49612a62722d7d1851c6

commit 1c20502be8c4fed237bc49612a62722d7d1851c6
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:06:28 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:50:18 2017 -0500

    Merge pull request #16559 from mkanoor/catalog_item_types
    
    Catalog Item type list is dependent on installed providers
    (cherry picked from commit 0bedb65ae134f00b2f15511ce5270208aa5b6ac3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/base_manager.rb       |  4 ++++
 .../providers/embedded_automation_manager.rb        |  4 ++++
 app/models/service_template.rb                      |  9 +++++++++
 .../embedded_ansible/automation_manager_spec.rb     |  8 ++++++++
 spec/models/service_template_spec.rb                | 21 +++++++++++++++++++++
 5 files changed, 46 insertions(+)

Comment 3 CFME Bot 2017-12-11 18:53:46 UTC
New commit detected on ManageIQ/manageiq-providers-amazon/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-amazon/commit/44e46e8ca1da5eb32f086da0067ec6636f01fa83

commit 44e46e8ca1da5eb32f086da0067ec6636f01fa83
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:01:22 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:53:19 2017 -0500

    Merge pull request #377 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 34eb3c68b2e6c2309e49a4f2dc5c47dfdce95b8e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/amazon/cloud_manager.rb       | 4 ++++
 spec/models/manageiq/providers/amazon/cloud_manager_spec.rb | 5 +++++
 2 files changed, 9 insertions(+)

Comment 4 CFME Bot 2017-12-11 18:54:31 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-classic/commit/6cf7b718e28e84fd55d83067e4f3b9b8b3f28321

commit 6cf7b718e28e84fd55d83067e4f3b9b8b3f28321
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Dec 4 08:58:11 2017 -0800
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:51:57 2017 -0500

    Merge pull request #2908 from h-kataria/use_backend_method_to_show_disabled_catalog_item_types_in_drop_down
    
    UI changes to show options as disabled if those are not supported.
    (cherry picked from commit 19ecd2e91c4387f077ceb3f70f54e162d4b14ed6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/views/catalog/_st_form.html.haml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comment 5 CFME Bot 2017-12-11 18:55:13 UTC
New commit detected on ManageIQ/manageiq-providers-vmware/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-vmware/commit/62fe3970db8a00a699277631bc38463f1ef2aaa3

commit 62fe3970db8a00a699277631bc38463f1ef2aaa3
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:04:11 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:54:37 2017 -0500

    Merge pull request #151 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 5b35b193aaaa3ced4a94b74b843c7c54b6c35eaf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/vmware/cloud_manager.rb       | 4 ++++
 app/models/manageiq/providers/vmware/infra_manager.rb       | 4 ++++
 spec/models/manageiq/providers/vmware/cloud_manager_spec.rb | 4 ++++
 spec/models/manageiq/providers/vmware/infra_manager_spec.rb | 7 +++++++
 4 files changed, 19 insertions(+)

Comment 6 CFME Bot 2017-12-11 19:03:20 UTC
New commit detected on ManageIQ/manageiq-providers-azure/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-azure/commit/d77ecfc219c410abe7dc48fa9173216a04d6cfbf

commit d77ecfc219c410abe7dc48fa9173216a04d6cfbf
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:03:09 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:59:18 2017 -0500

    Merge pull request #185 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 26674f3f7169bdc03c3e462027b2a2d329654bc9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/azure/cloud_manager.rb       | 4 ++++
 spec/models/manageiq/providers/azure/cloud_manager_spec.rb | 8 ++++++++
 2 files changed, 12 insertions(+)

Comment 7 CFME Bot 2017-12-11 19:04:20 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-ovirt/commit/36449cf9fc20ca4c56a841d4595de66c7c003ba5

commit 36449cf9fc20ca4c56a841d4595de66c7c003ba5
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:03:38 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 14:01:50 2017 -0500

    Merge pull request #174 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit a5ae793887a3f828ec64210381550e592c95e3d8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/redhat/infra_manager.rb       | 4 ++++
 spec/models/manageiq/providers/redhat/infra_manager_spec.rb | 8 ++++++++
 2 files changed, 12 insertions(+)

Comment 8 CFME Bot 2017-12-11 19:04:27 UTC
New commit detected on ManageIQ/manageiq-providers-openstack/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-openstack/commit/33d7ca9cb3d9bcda1e17825e6dee324190b1f9d8

commit 33d7ca9cb3d9bcda1e17825e6dee324190b1f9d8
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:02:57 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:58:13 2017 -0500

    Merge pull request #177 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 0f7543068f44feee7881e957c4c8779fe17e8f0c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/openstack/cloud_manager.rb       | 4 ++++
 app/models/manageiq/providers/openstack/infra_manager.rb       | 4 ++++
 spec/models/manageiq/providers/openstack/cloud_manager_spec.rb | 8 ++++++++
 spec/models/manageiq/providers/openstack/infra_manager_spec.rb | 8 ++++++++
 4 files changed, 24 insertions(+)

Comment 9 CFME Bot 2017-12-11 19:04:33 UTC
New commit detected on ManageIQ/manageiq-providers-openshift/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-openshift/commit/48fd8e39cc75ad6ef8b1dffeaab540dbdc609e36

commit 48fd8e39cc75ad6ef8b1dffeaab540dbdc609e36
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:02:08 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:56:01 2017 -0500

    Merge pull request #74 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 89a89365c7d6b9425b830dbfd174bc8d40ea2216)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/openshift/container_manager.rb       | 4 ++++
 spec/models/manageiq/providers/openshift/container_manager_spec.rb | 6 ++++++
 2 files changed, 10 insertions(+)
 create mode 100644 spec/models/manageiq/providers/openshift/container_manager_spec.rb

Comment 10 CFME Bot 2017-12-11 19:04:45 UTC
New commit detected on ManageIQ/manageiq-providers-ansible_tower/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-ansible_tower/commit/de650a0a36d8b27829dcdc39b02014124dd76d36

commit de650a0a36d8b27829dcdc39b02014124dd76d36
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:03:23 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 14:00:27 2017 -0500

    Merge pull request #42 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit f8ba8da6ce37c0283605ec409a391584c6e2e6fc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/ansible_tower/automation_manager.rb | 4 ++++
 .../manageiq/providers/ansible_tower/automation_manager_spec.rb   | 8 ++++++++
 2 files changed, 12 insertions(+)

Comment 11 CFME Bot 2017-12-11 19:04:52 UTC
New commit detected on ManageIQ/manageiq-providers-scvmm/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-scvmm/commit/1a06d729fb5647c31186b155084c990923b9a868

commit 1a06d729fb5647c31186b155084c990923b9a868
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:02:38 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 13:57:13 2017 -0500

    Merge pull request #54 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 1c7ada6b5c0caed8c4a8d61eef5d9e5d9584e794)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/microsoft/infra_manager.rb       | 4 ++++
 spec/models/manageiq/providers/microsoft/infra_manager_spec.rb | 8 ++++++++
 2 files changed, 12 insertions(+)

Comment 12 CFME Bot 2017-12-11 19:04:58 UTC
New commit detected on ManageIQ/manageiq-providers-google/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-google/commit/f51a64d229326ed7429906114c46bee450386125

commit f51a64d229326ed7429906114c46bee450386125
Author:     Adam Grare <agrare>
AuthorDate: Mon Dec 11 13:03:55 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 11 14:02:55 2017 -0500

    Merge pull request #35 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 8288913717c76c1c55663984d0b45af6f4b308db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

 app/models/manageiq/providers/google/cloud_manager.rb       | 4 ++++
 spec/models/manageiq/providers/google/cloud_manager_spec.rb | 8 ++++++++
 2 files changed, 12 insertions(+)

Comment 13 mkanoor 2017-12-12 23:14:20 UTC
Just an FYI if you have the Embedded Ansible Role enabled and then you disable it you would still see the Service Catalog Item for Ansible Playbook, Since this logic is based on the presence of the provider, not just based on role.

Comment 14 luke couzens 2017-12-14 11:51:31 UTC
Verified in 5.9.0.13


Note You need to log in before you can comment on or make changes to this bug.