Bug 151661

How would it be known that these are needed?

um, are you asking me?

Asking anyone who might have an idea, yes. Cc'ing some of the PPC folks.

Maybe
grep -q '^machine.*:.*PowerMac7,[23]' /proc/cpuinfo
?
Note i2c_core doesn't need to be loaded manually, it is a dependency of
both the other modules.
Alternatively, look for /proc/device-tree node where
/proc/device-tree/.../compatible contains fcu\0:
hexdump /proc/device-tree/u3/i2c/fan/compatible
0000000 6663 7500
0000004

BTW, If there is a fan node in device-tree and is */compatible with
adt7460 or adt7467, therm_adt746x module should be used instead.

This noise difference is huge, so FC4 really should have this fixed somehow.

Which of keywest & the thermal module do you need, or both?

Both.

Jakub: are there any fan nodes in the device-tree for the pm72?

Woops, I can't read. Don't mind me.

Note that we don't build therm_adt746x or therm_windtunnel. Should we?

therm_adt745x/therm_pm72 should be handled in kudzu-1.1.112-1/initscripts-8.08-2.

fc4test3 on mac mini doesn't load any therm modules.  In fact, no longer see
therm_pm72, though I don't have any idea which module the mini needs.

[root@mini ~]# lsmod | grep i2c
i2c_keywest            13828  0

[root@mini ~]# dmesg | grep  -i i2c
Found KeyWest i2c on "uni-n", 2 channels, stepping: 4 bits
Found KeyWest i2c on "mac-io", 1 channel, stepping: 4 bits

[root@mini ~]# lsmod | grep therm

[root@mini ~]# find /lib/modules/ -name therm\*.ko
/lib/modules/2.6.11-1.1286_FC4/kernel/drivers/macintosh/therm_adt746x.ko
/lib/modules/2.6.11-1.1286_FC4/kernel/drivers/macintosh/therm_windtunnel.ko

[root@mini ~]# modprobe therm_adt746x
FATAL: Error inserting therm_adt746x
(/lib/modules/2.6.11-1.1286_FC4/kernel/drivers/macintosh/therm_adt746x.ko): No
such device

[root@mini ~]# modprobe therm_windtunnel
FATAL: Error inserting therm_windtunnel
(/lib/modules/2.6.11-1.1286_FC4/kernel/drivers/macintosh/therm_windtunnel.ko):
No such device

[root@mini ~]# ls /lib/modules/2.6.11-1.1286_FC4/kernel/drivers/macintosh/
therm_adt746x.ko  therm_windtunnel.ko

(In reply to comment #11)
> fc4test3 on mac mini doesn't load any therm modules.  In fact, no longer see
> therm_pm72, though I don't have any idea which module the mini needs.
> 
> [root@mini ~]# modprobe therm_adt746x
> [root@mini ~]# modprobe therm_windtunnel
> FATAL: Error inserting therm_windtunnel

None of these will work, that being therm_pm72, therm_adt746x, or
therm_windtunnel on the Mac mini. So kudzu is being right in *not* detecting
them. Please open up another bug for this, thanks

Now, G5 users, does the comment #10 apply, and is there sane fan control now?
cagney, dwmw2, overholt, jakub?

(In reply to comment #12)
> Now, G5 users, does the comment #10 apply, and is there sane fan control now?
> cagney, dwmw2, overholt, jakub?

Not sure. It's working on my G5 but because I set it up manually -- I that
machine is mostly still running FC3 and hasn't been reinstalled since the middle
of last year.

I'm wondering if we should build these into the kernel instead of as modules;
that would make the fans work during the install too.

(In reply to comment #12)
> Now, G5 users, does the comment #10 apply, and is there sane fan control now?
> cagney, dwmw2, overholt, jakub?

I haven't re-installed this machine since test2.  I need to update my iBook G4
so I'll install that and then use that while I re-install this machine (G5).

(In reply to comment #11)
> I'm wondering if we should build these into the kernel instead of as modules;
> that would make the fans work during the install too.

I would like this.

(In reply to comment #14)
> (In reply to comment #11)
> > I'm wondering if we should build these into the kernel instead of as modules;
> > that would make the fans work during the install too.
> 
> I would like this.

As I said to dwmw2 on irc, we don't build ext3 into the kernel, what are our
chances of getting thermal control built in? ;-)

I've just installed FC4 on a brand new G5 2*2.0 (PowerMac7,3) and the bug is
still here.

The i2c_core and i2c_keywest drivers seems to be now in the kernel, but the
therm_pm72 isn't loaded.

Even if I modprobe it, the fans are still crazy.

At boot time I've the following error message :
/u3@0,f8000000/i2c@f8001000: Missing interrupt or address !

I've tried to compile the latest 2.6.12 kernel and I've got the same error and
problem.

Cheers