Bug 1517000

Summary: Review Request: rubygem-notiffany - Notifier library (extracted from Guard project)
Product: [Fedora] Fedora Reporter: Jaroslav Prokop <jar.prokop>
Component: Package ReviewAssignee: Vít Ondruch <vondruch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, vondruch
Target Milestone: ---Flags: vondruch: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-notiffany-0.1.1-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-18 15:27:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jaroslav Prokop 2017-11-23 20:08:43 UTC 
Spec URL: https://gitlab.com/jackorp/rubygem-notiffany/raw/63e0ce06aa54d93afcb17c5f7f93ced67463e90b/rubygem-notiffany.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00678843-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm
Description: Wrapper libray for most popular notification
libraries such as Growl, Libnotify, Notifu.
Fedora Account System Username: jackorp
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23323650
Comment 1 Vít Ondruch 2017-11-28 08:54:29 UTC 
Taking for a review.


* Patch filename and URL
  - I would name the patch by some more explanatory name, e.g.:

    rubygem-notiffany-0.1.1-Fix-uninitialized-constant-Notiffany-VERSION-test-failure.patch

  - I prefer to use the URL, which gives me more context, e.g.

    https://github.com/guard/notiffany/pull/31

    From the URL you provided, I can see the patch, but I can't see the
    associated discussion.


Otherwise the package looks good. Please fix the nit above and I'll approve the package.
Comment 2 Jaroslav Prokop 2017-11-28 21:16:43 UTC 
Updated spec URL: https://gitlab.com/jackorp/rubygem-notiffany/raw/dbfdc4d0ee0b311eac39db7edff1e50df21266d2/rubygem-notiffany.spec

Updated srpm URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00681801-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=23443688
Comment 3 Jaroslav Prokop 2017-11-30 20:31:08 UTC 
Hi, here is version with fixed both patch name and URL

updated spec URL:https://gitlab.com/jackorp/rubygem-notiffany/raw/9d2047a32eebec2e48fd40b7856e3eb437d87fd2/rubygem-notiffany.spec

updated srpm URL:https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00682701-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm
Comment 4 Vít Ondruch 2017-12-14 17:28:37 UTC 
Thx. I can't see any other issue with the package => APPROVED. Please continue with the SCM request, import and build of the package:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
Comment 5 Gwyn Ciesla 2017-12-15 18:18:01 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-notiffany