Spec URL: https://gitlab.com/jackorp/rubygem-notiffany/raw/63e0ce06aa54d93afcb17c5f7f93ced67463e90b/rubygem-notiffany.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00678843-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm Description: Wrapper libray for most popular notification libraries such as Growl, Libnotify, Notifu. Fedora Account System Username: jackorp Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23323650
Taking for a review. * Patch filename and URL - I would name the patch by some more explanatory name, e.g.: rubygem-notiffany-0.1.1-Fix-uninitialized-constant-Notiffany-VERSION-test-failure.patch - I prefer to use the URL, which gives me more context, e.g. https://github.com/guard/notiffany/pull/31 From the URL you provided, I can see the patch, but I can't see the associated discussion. Otherwise the package looks good. Please fix the nit above and I'll approve the package.
Updated spec URL: https://gitlab.com/jackorp/rubygem-notiffany/raw/dbfdc4d0ee0b311eac39db7edff1e50df21266d2/rubygem-notiffany.spec Updated srpm URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00681801-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=23443688
Hi, here is version with fixed both patch name and URL updated spec URL:https://gitlab.com/jackorp/rubygem-notiffany/raw/9d2047a32eebec2e48fd40b7856e3eb437d87fd2/rubygem-notiffany.spec updated srpm URL:https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00682701-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm
Thx. I can't see any other issue with the package => APPROVED. Please continue with the SCM request, import and build of the package: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-notiffany