Bug 1520024
Summary: | Review Request: netatalk - Open Source Apple Filing Protocol (AFP) File Server | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ryan Breaker <ryan> | ||||
Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | alanh, hat, herrold, ngompa13, package-review, sknauss, stevenschlansker, zonexpertconsulting | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2018-12-11 13:54:02 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Ryan Breaker
2017-12-02 04:44:57 UTC
Taking this review. I'll also be sponsoring this packager, (In reply to Neal Gompa from comment #1) > Taking this review. I'll also be sponsoring this packager, Thanks! I did notice the compiled binary RPM has some rpmlint issues which I'm still trying to figure out, and may need some help with. For example: * E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd * E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd Looking through the source for each of these however, the order of the function calls appear to be correct (https://wiki.sei.cmu.edu/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges). I'm still new to RPMs so thank you for your patience. From looking at what rpmlint is doing, it's dumping the external symbols from the executable and assuming that the calls are in the order that they appear in the symbol table. So it's expecting setgid to come before setuid, and it's not in this build. However, I'm not sure that's a valid assumption on rpmlint's part. As long as the code looks okay, I'd say it's safe to call it a false positive. Some of the others are easy. The dir-or-file-in-var-lock error can be fixed by running configure with --with-lockfile=/run/netatalk to move the file to the standard run directory.The %ghost directive should be changed to /run/netatalk I've taken a crack at fixing some of the other issues in the spec file, notably moving /var/lock/netatalk to /run/netatalk, and removing the ownership of /var/lib. Created attachment 1380830 [details]
Updated netatalk.spec
To: Ryan Breaker your spec file: > # Ghost lock dir. > mkdir -p %{buildroot}/var/lock/netatalk > %ghost %dir /var/lock/netatalk The /var/lock/netatalk is file, not directory. To: Alan Hamilton your spec file: > # Ghost lock dir. > mkdir -p %{buildroot}/run/netatalk > %ghost %dir /run/netatalk The /run/netatalk is file, not directory. http://netatalk.sourceforge.net/wiki/index.php/Netatalk_3.1.11_SRPM_for_Fedora_and_CentOS Spec URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk.spec SRPM URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.1.11-1.2.fc29.src.rpm I updated Ryan Breaker's SRPM. pam_ck_connector.so isn't always installed https://bugzilla.redhat.com/show_bug.cgi?id=1520024 require dconf package https://bugzilla.redhat.com/show_bug.cgi?id=1248157 require perl-IO-Socket-INET6 for asip-status.pl script define with_ldap https://bugzilla.redhat.com/show_bug.cgi?id=1249403 The UAM path should be netatalk, not atalk https://bugzilla.redhat.com/show_bug.cgi?id=1249404 fix multilib conflict of tracker-devel https://sourceforge.net/p/netatalk/bugs/637/ Support EL6. Support Fedora 28 and later. However, many problems of rpmlint aren't being corrected. I have been running the discontinued fc26 netatalk, which I uninstalled. I then upgraded the host f27 -> f28. HAT, I was not able to download your SRPM (404) but I did build 3.1.11-1.3.fc28 based on your specfile. I installed it, restored the afp.conf.rpmsave so I had configuration, and am working through a Time Machine backup. Thanks to all of you for picking this package up, looking forward to seeing it in the repos soon. See http://netatalk.sourceforge.net/wiki/index.php/Netatalk_3.1.11_SRPM_for_Fedora_and_CentOS Spec URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk.spec SRPM URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.1.11-1.3.fc29.src.rpm Most of the issues identified in this review appear to have been fixed by HAT, who appears to be upstream developer. Thanks, HAT. Is the original author still interested in completing this review? I am not in the sponsor group, but I can help finish the review if that is what is needed. If not, can this review be closed so that I can create a new review request? Since this review request has not seen any recent activity, I am going to close this out to allow a new request to take its place. I could use a reviewer for the new review request: https://bugzilla.redhat.com/show_bug.cgi?id=1658199 *** This bug has been marked as a duplicate of bug 1658199 *** |