Bug 1658199 - Review Request: netatalk - Open Source Apple Filing Protocol(AFP) File Server
Summary: Review Request: netatalk - Open Source Apple Filing Protocol(AFP) File Server
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Scott Talbert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1520024 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-11 13:52 UTC by Andrew Bauer
Modified: 2019-05-17 01:04 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-23 02:24:27 UTC
Type: ---
Embargoed:
swt: fedora-review+


Attachments (Terms of Use)
licensecheck output (23.85 KB, text/plain)
2019-02-03 01:29 UTC, Scott Talbert
no flags Details

Description Andrew Bauer 2018-12-11 13:52:44 UTC
Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1351/31321351/netatalk-3.1.11-2.fc30.src.rpm

Description:
Netatalk is a freely-available Open Source AFP file server. A *NIX/*BSD
system running Netatalk is capable of serving many Macintosh clients
simultaneously as an AppleShare file server (AFP).

Fedora Account System Username: Kni

RPMLint Output
--------------
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
> Appears to be a false positive. setgid and setuid seem to be in the correct order. 
> Please inspect and confirm:
>[1] https://github.com/Netatalk/Netatalk/blob/branch-netatalk-3-1/etc/afpd/afprun.c#L121
>[2] https://github.com/Netatalk/Netatalk/blob/branch-netatalk-3-1/etc/cnid_dbd/cnid_metad.c#L512

netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755
netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755
> afppasswd functions similar to passwd, which also generates the same message from rpmlint

netatalk.x86_64: W: no-manual-page-for-binary cnid2_create
> confirmed. No man page exists for this binary

NOTES
-----
This specfile is based on the spcfile provided by upstream developer, HAT, shown in this older review request:
https://bugzilla.redhat.com/show_bug.cgi?id=1520024

This spec files uses Epoch for historical reasons, and this seems to be one of those things where, if you start down this path, you never go back.
I am not confident that removing this would not cause any unforseen problems, so I left it in.

I found the way the specfile computes the pkgver and xslver globals to be unusual. See the first few lines of the specfile.
I could try to move these into %build if someone thinks that should be done.

Lastly, this review request is intended for el7 and fedora only. 
I will handle any requests for el6 support, if there are any, later.

Comment 1 Andrew Bauer 2018-12-11 13:54:02 UTC
*** Bug 1520024 has been marked as a duplicate of this bug. ***

Comment 2 Andrew Bauer 2018-12-11 13:57:09 UTC
Un-orphan request has been filed with releng:
https://pagure.io/releng/issue/7984

Comment 3 Neal Gompa 2018-12-12 00:11:50 UTC
Drop the Epoch. It's been out of Fedora long enough that it should be removed.

Comment 4 Andrew Bauer 2018-12-12 02:49:44 UTC
Thanks for the feedback. Epoch has been removed.

Updated Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec
Updated SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5704/31415704/netatalk-3.1.11-2.fc30.src.rpm

Comment 5 Neal Gompa 2018-12-12 02:56:29 UTC
ldconfig scriptlets aren't needed in Fedora, and should be dropped (including the Requires(post,postun) for /sbin/ldconfig) for Fedora and EL8+.

Also, Python 2 is now marked as deprecated, so Python scripts need to be ported to Python 3 for Fedora packages and pointed to Python 3.

Comment 6 Neal Gompa 2018-12-12 02:57:17 UTC
> ldconfig scriptlets aren't needed in Fedora, and should be dropped (including the Requires(post,postun) for /sbin/ldconfig) for Fedora and EL8+.

Note that this is needed for EL7, so if you are targeting that, you'll want to only conditionally drop it.

Comment 7 Andrew Bauer 2018-12-12 18:14:02 UTC
Done.

- call to ldconfig converted to a macro, which only gets defined when rhel <= 7
- python shebang set to /usr/bin/python3 & afpstats patched for python3 compatibility. Pull request sent upstream: 
  https://github.com/Netatalk/Netatalk/pull/113

Updated Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec
Updated SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7071/31427071/netatalk-3.1.11-2.fc30.src.rpm

Comment 8 R P Herrold 2018-12-13 00:46:46 UTC
Doing a non-root build, I am getting a box soliciting the root password, for managing the systemd 

This seems problematic

Comment 9 Andrew Bauer 2018-12-13 01:03:53 UTC
It builds fine for me w/o asking for root password. It also builds fine on the build system.
Please describe the steps you used to build the package. Your build output would be helpful too.

Comment 10 Andrew Bauer 2018-12-13 01:09:59 UTC
Just guessing here, but are you sure it wasn't asking you for the locations of a missing patch file?
The patch files are in the source rpm, and one of them is named: netatalk-systemd-runtimedirectory.patch

Comment 11 Andrew Bauer 2018-12-13 02:12:24 UTC
Found it. systemctl daemon-reload was being called within distrib/initscripts/Makefile.in
This was only an issue in a non-chroot build environment, and it has been fixed.


Updated Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec
Updated SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4263/31434263/netatalk-3.1.11-2.fc30.src.rpm

Comment 13 Kevin Kofler 2019-01-10 01:32:49 UTC
(In reply to Neal Gompa from comment #3)
> Drop the Epoch. It's been out of Fedora long enough that it should be
> removed.

I disagree. This package has been in Fedora with Epoch 5, so it should never be reintroduced with a lower (or no) Epoch. People do skip releases when upgrading, or even keep the package from the EOL release if the newer release no longer provides it but does not force its removal (either deliberately because they still need the package, or accidentally because they just forgot about it – and for the record, I am absolutely against forced obsoletion of retired packages as long as they still work because people may want to keep them deliberately). By dropping the Epoch, you break the upgrade path for the people who still have the F23 or pre-F24-Rawhide package installed for whatever reason, so they may end up still sticking with the obsolete package.

Comment 14 Andrew Bauer 2019-01-13 01:35:47 UTC
(In reply to Kevin Kofler from comment #13)
> I disagree. This package has been in Fedora with Epoch 5, so it should never
> be reintroduced with a lower (or no) Epoch. People do skip releases when
> upgrading, or even keep the package from the EOL release if the newer
> release no longer provides it but does not force its removal (either
> deliberately because they still need the package, or accidentally because
> they just forgot about it – and for the record, I am absolutely against
> forced obsoletion of retired packages as long as they still work because
> people may want to keep them deliberately). By dropping the Epoch, you break
> the upgrade path for the people who still have the F23 or pre-F24-Rawhide
> package installed for whatever reason, so they may end up still sticking
> with the obsolete package.

Good argument. I have placed Epoch back into the specfile.

Updated Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec

Updated SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kni/netatalk/fedora-rawhide-x86_64/00845958-netatalk/netatalk-3.1.12-1.fc30.src.rpm

Comment 15 Scott Talbert 2019-01-29 03:03:28 UTC
I've used netatalk before but not in Fedora, so I'm happy to take this.

Comment 16 Scott Talbert 2019-01-29 03:38:28 UTC
> %global _hardened_build   1

This shouldn't be needed in Fedora anymore according to https://fedoraproject.org/wiki/Changes/Harden_All_Packages.  It sounds like it may be needed for EL7 still though.  Are you planning to maintain a common spec with EL7 or do you plan to maintain EL7 in its own branch?  If you plan to maintain EL7 in its own branch, you can probably get rid of this here (and the ldconfig stuff).

> Source0:           http://download.sourceforge.net/netatalk/netatalk-%{version}.tar.bz2

Use https.

> BuildRequires:     rpm

I don't think you need to BuildRequire rpm.  :-)  grep and sed are probably overkill too but I suppose they can't hurt.

Comment 17 Scott Talbert 2019-01-29 04:05:21 UTC
> %package        devel
> Summary:        Development files for %{name}
> Requires:       %{name}%{?_isa} = %{version}

I think you need to include the epoch here.  I think this is causing this rpmlint warning:
netatalk-devel.x86_64: W: incoherent-version-dependency-on netatalk/netatalk-libs/libnetatalk 3.1.12 5:3.1.12

Also, the package is building fine but fails to install.  I haven't looked into why exactly, but do you see that problem?

Comment 18 Andrew Bauer 2019-01-29 13:52:56 UTC
Scott - Thank you very much to taking on this review. I was beginning to wonder what creative posts I might need to come up with on the devel list, funny jokes, recent declaration of independence, etc to persuade someone to review this for me. I owe you one, should you ever need me to review one of your requests.

> %global _hardened_build   1

> This shouldn't be needed in Fedora anymore

Agreed. I have this included because I plan to build for el7, and hardened builds default to off.

> Source0:           http://download.sourceforge.net/netatalk/netatalk-%{version}.tar.bz2

> Use https.

Will do.

> BuildRequires:     rpm

> I don't think you need to BuildRequire rpm.

Take a look at the pkgver and xslver macros. They call the rpm binary. While I'd call these macros unusual in the way they are created, these predate my involvement so I left them alone. If there is a prettier way to go about creating these macros, I'm certainly willing to look into it.

> Requires:       %{name}%{?_isa} = %{version}

> I think you need to include the epoch here.

You are absolutely right. I forgot the modify this line when I put epoch back in.

I am out of town for my dayjob all week this week. I will add these action items to my to-do list when I return home.  Thanks again for taking on this review.

Comment 19 Scott Talbert 2019-02-03 01:28:19 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Package must BuildRequire: perl-generators instead of setting Requires:
  on perl(IO::Socket::INET6) manually.
- Subpackage must Require: main package with epoch and release.
- %check doesn't appear to be running (all?) the tests
- License tag is incomplete - there are multiple additional licenses other than
  GPLv2+ (see licensecheck output)


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[?]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* GNU General Public License (v2)", "GPL (v2 or
     later)", "GPL (v3 or later)", "Unknown or generated", "GNU General
     Public License", "BSD 3-clause "New" or "Revised" License", "GNU
     Lesser General Public License (v2.1 or later)", "GNU General Public
     License (v2)", "GNU General Public License (v2 or later)", "Expat
     License", "FSF Unlimited License (with Retention) GNU General Public
     License", "FSF Unlimited License (with Retention)", "*No copyright*
     GPL (v2 or later)", "NTP License", "GNU Lesser General Public License
     (v2 or later)", "GNU Lesser General Public License". 431 files have
     unknown license. Detailed output of licensecheck in /home/talbert
     /fedora-review/1658199-netatalk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/dbus-1/system.d,
     /etc/dbus-1
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id/c5(cups-
     filters, libXcomposite, glusterfs, mdadm, coreutils, libglvnd, glibc,
     libvirt-daemon, evolution-ews, compat-ffmpeg28, gnome-software, pam,
     iptables, ebtables, unzip, python3-lazy-object-proxy, kmod-
     VirtualBox-4.19.13-300.fc29.x86_64, libdrm, krb5-devel, libevent,
     util-linux, lzo-minilzo, cups-libs, libgpod, python3-libvirt, gjs,
     python3-systemd, gnome-session, lttng-ust, avahi), /usr/lib/.build-
     id/a1(adwaita-qt4, python3-wxpython4, libyubikey, dbxtool, evolution-
     data-server, gettext, glibc, java-1.8.0-openjdk-headless, emacs-
     common, gawk, pulseaudio, python3-systemd, abrt-addon-coredump-helper,
     libuser, frei0r-plugins, libxcb, brltty, kmod-
     VirtualBox-4.20.3-200.fc29.x86_64, util-linux, pam, libreoffice-core),
     /usr/lib/.build-id/dc(argyllcms, alsa-utils, liblouis, bluez, perl-
     interpreter, clang6.0-libs, device-mapper-multipath, libreoffice-core,
     httpd, glibc, gstreamer1-plugins-base, frei0r-plugins, python2-libs,
     pam, procps-ng, ModemManager, libdb-utils, python3-libs, qemu-audio-
     alsa, evolution-data-server, pulseaudio, NetworkManager-pptp-gnome,
     rygel), /usr/lib/.build-id/dd(libuser, opensp, gnome-shell, dbus-
     daemon, python3-cryptography, libmbim, java-1.8.0-openjdk-headless,
     glibc, libxcrypt, startup-notification, coreutils, frei0r-plugins,
     python2-gobject, groff-base, device-mapper-multipath-libs,
     NetworkManager-wwan, audit, python3-libvirt, valgrind, perl-Unicode-
     UTF8, elfutils, libnl3-cli, samba-client-libs), /usr/lib/.build-id/a6
     (bind-export-libs, libv4l, ImageMagick-libs, glusterfs, perl-
     interpreter, samba-client-libs, libblockdev-nvdimm, frei0r-plugins,
     libiscsi, python3-dbus, cyrus-sasl-plain, mesa-dri-drivers, vo-
     amrwbenc, gawk, dhcp-libs, util-linux, cronie, libtommath, xmlrpc-c,
     e2fsprogs, fuse3, hplip-libs, flatpak), /usr/lib/.build-id(qemu-ui-
     gtk, cups-client, efivar-libs, qemu-block-gluster, rpm-plugin-selinux,
     abrt, libmediaart, libimagequant, giflib, libreoffice-graphicfilter,
     trousers, libdb-utils, tracker-miners, xorg-x11-font-utils,
     PackageKit-command-not-found, OpenEXR-libs, libcom_err, libseccomp,
     p11-kit, libabw, libvirt-daemon-driver-storage-iscsi, libmodman,
     argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs,
     libwebp, libxslt, system-config-printer-udev, perl-Encode, libverto-
     libev, python2-cryptography, libevdev, libgpg-error, libmaxminddb,
     lvm2-libs, perl-Digest-SHA, python3-unbound, libzstd, wxBase,
     libdazzle, avahi, lua-lpeg, symlinks, python3-crypto, libcdr,
     cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs, wxGTK3-webview,
     tpm2-tools, lcms2, qemu-guest-agent, annobin, ntfs-3g, libxcb,
     libyubikey, sssd-common-pac, python3-brlapi, openconnect, xcb-util-
     keysyms, m4, sushi, libgphoto2, cdparanoia, xcb-util, libwmf-lite,
     udisks2-iscsi, python3-coverage, anaconda-widgets, pulseaudio-utils,
     llvm5.0-libs, poco-mongodb, libeot, compat-wxGTK3-gtk2, systemd-
     bootchart, perl-Time-Piece, dbusmenu-qt, ncurses-libs, libidn2,
     checkpolicy, libreport-plugin-logger, gnome-color-manager, fcoe-utils,
     xorg-x11-xkb-utils, ibus-hangul, NetworkManager-openvpn, libxkbfile,
     hplip-libs, libwvstreams, freerdp-libs, xmlrpc-c-client, sane-
     backends-drivers-cameras, python3-hawkey, libwpd, enchant2, libdc1394,
     libvirt-daemon-driver-qemu, perl-Time-HiRes, qemu-block-ssh, libwps,
     gssdp, gnome-calendar, libacl, python2-wxpython4-media, xorg-x11-drv-
     ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi,
     libmusicbrainz5, pptp, sane-backends-drivers-scanners, libXxf86misc,
     foomatic, colord-gtk, libpath_utils, libicu-devel, rpm-build, wodim,
     libvirt-daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit,
     rpm-plugin-systemd-inhibit, freeglut, gstreamer1, gom, gmime30,
     libtomcrypt, ccache, dbus-libs, libreoffice-gtk3, libreoffice-gtk2,
     cairo-gobject, gnome-screenshot, libkkc, gutenprint, usermode, qpdf-
     libs, linux-atm-libs, libedit, openssh, atk, python3-cairo,
     python2-libdnf, accountsservice, isl, hfsplus-tools, perl-IPC-SysV,
     gssproxy, mesa-libGLU, libblockdev-btrfs, libatomic_ops, gupnp-av,
     clang6.0-libs, libmpcdec, gtk-update-icon-cache, tpm2-abrmd, libvirt-
     daemon-driver-interface, NetworkManager, liblangtag, libdatrie, glade-
     libs, setuptool, poco-pagecompiler, guile, pcre-utf16, tree, gvfs-goa,
     pipewire, gnupg, libnsl2, xfsprogs, authselect, libcroco, spice-
     server, telepathy-glib, plymouth-plugin-label, colord-libs,
     gstreamer1-libav, efivar, gpgmepp, libgcab1, libzhuyin, gvnc,
     hypervfcopyd, cronie, libexttextcat, nettle, libcacard, elfutils,
     colord, libpipeline, pkcs11-helper, accountsservice-libs, network-
     scripts, gnome-system-monitor, findutils, popt, python2-xpyb,
     qt5-qtx11extras, libsss_idmap, libraw1394, folks, gnome-clocks,
     python3-dbus, iproute-tc, isomd5sum, spice-glib, poco-net, woff2,
     dotconf, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant,
     libXxf86dga, python2-smartcols, rhash, xdg-user-dirs-gtk, libwayland-
     client, pinentry-gnome3, libsmbios, libXres, mdadm, openblas-threads,
     device-mapper, libXtst, xapian-core-libs, gnome-terminal, GeoIP,
     libsigc++20, libXrandr, sssd-ldap, liba52, hplip, crda, libical,
     sheepdog, qt5-qtdeclarative, vo-amrwbenc, poco-foundation, libXfont2,
     libblockdev-loop, libssh2, NetworkManager-adsl, open-vm-tools-desktop,
     xmlsec1-nss, libXcursor, nftables, iio-sensor-proxy, bridge-utils,
     procps-ng, plymouth-core-libs, telnet, libXpm, xorg-x11-drv-nouveau,
     bluez-obexd, zlib, libpeas, pam_krb5, gutenprint-cups, PackageKit-
     gstreamer-plugin, xdg-desktop-portal-gtk, libselinux, libotf,
     libassuan, expat, cups-filters, iw, clutter-gtk, userspace-rcu,
     wavpack, ibus-libpinyin, setroubleshoot-server, make,
     python3-markupsafe, libnice, libzip, libsoup, glusterfs-api, fuse,
     perl-Net-SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol,
     totem-pl-parser, gzip, autogen-libopts, keyutils, libipa_hbac,
     libfdisk, libdmx, cppunit, openssl-libs, corosynclib, libreport-
     plugin-reportuploader, gavl, libatasmart, ipset, unique, keybinder3,
     deltarpm, fuse-libs, libmediainfo, xorg-x11-xauth, libglvnd-glx,
     tigervnc-server, gtkspell3, libcue, libXrender, json-glib, libX11-xcb,
     libfontenc, libicu, libgsf, xorg-x11-drv-vmware, sssd-common,
     NetworkManager-openconnect, libgtop2, btrfs-progs, tracker,
     python3-pycurl, python2-wxpython-webview, perl-Devel-PPPort, sni-qt,
     mesa-libglapi, bolt, glx-utils, poco-data, libtommath, ykpers,
     PackageKit, perl-MIME-Base64, python3-wxpython4-webview, libass,
     wpa_supplicant, texlive-lib, ppp, python2-crypto, git, perl-Compress-
     Raw-Bzip2, jack-audio-connection-kit, mpg123-libs, opus, ctags, git-
     core, libxklavier, traceroute, PackageKit-gtk3-module, libblockdev-
     crypto, libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr,
     gtksourceview3, pugixml, plymouth, libcanberra-gtk3,
     python2-wxpython4, mtdev, systemd-udev, brasero, libXvMC, check,
     cheese-libs, quota, libXmu, capstone, libreoffice-impress, jasper-
     libs, librbd1, device-mapper-libs, xorg-x11-xinit, gnome-initial-
     setup, libffi, pcre-utf32, diffutils, chrony, time, mpfr, iputils,
     qt5-qtxmlpatterns, numactl-libs, libvirt-daemon-driver-nwfilter, gvfs-
     fuse, tigervnc-server-minimal, gpgme, hypervvssd, xorg-x11-drv-
     openchrome, libmcpp, libibverbs, gdb-headless, dleyna-core, qemu-
     audio-pa, libgovirt, libqmi-utils, libmbim-utils, psacct, lame-libs,
     gnome-bluetooth-libs, VirtualBox, usbredir, ghostscript, libtirpc,
     iptables-libs, cryptsetup-libs, gnome-control-center, syslinux-
     extlinux, bind-libs, lua-posix, libinput, libreport-cli, libpkgconf,
     abrt-gui-libs, libosinfo, libabigail, qt5-qtsvg, libreoffice-calc,
     libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme,
     libbasicobjects, baobab, rdma-core, vte291, libgweather, sssd-krb5,
     qemu-block-iscsi, perl-Devel-Peek, brotli, filezilla, libgrss, httpd,
     libsmbclient, libkcapi, compat-openssl10, opencore-amr, abrt-addon-
     kerneloops, libnftnl, gnome-maps, evolution-data-server, oddjob-
     mkhomedir, python3-wxpython4-media, python3-libvirt, xcb-util-
     renderutil, perl-PerlIO-utf8_strict, libwinpr, sssd-ad, poco-
     encodings, libpinyin, freetype, logrotate, rdist, gnuplot-wx, scl-
     utils, libdnet, ntfsprogs, abrt-libs, efibootmgr, libgdither, samba-
     common-libs, libpsl, wxGTK, libzen, python3-rpm, nautilus-sendto,
     jimtcl, libuser, opensp, lksctp-tools, kexec-tools, boost-date-time,
     wvdial, satyr, pixman, gnome-font-viewer, xorg-x11-drv-vesa,
     libbluray, cifs-utils, libstdc++, libbabeltrace, vpnc, psmisc, net-
     snmp-libs, xorg-x11-drv-libinput, libiodbc, libsss_certmap,
     libblockdev-mpath, cairo, libgcc, gdisk, ilmbase, perl-Compress-Bzip2,
     poppler, libstemmer, poco-mysql, djvulibre-libs, bison, ibus-
     libzhuyin, fftw-libs-double, libconfig, ModemManager, abrt-gui, ibus-
     m17n, qemu-img, qt5-qtbase-gui, rtkit, orc, polkit, libuuid,
     libarchive, libfreehand, ibus-gtk3, ibus-gtk2, xorg-x11-server-Xvfb,
     cryptsetup, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers,
     xz, libXcomposite, rpcbind, mtools, vim-minimal, harfbuzz-icu,
     libplist, gstreamer-tools, xdg-user-dirs, glusterfs-libs, python3
     -lazy-object-proxy, gdk-pixbuf2, gupnp, libreport, libevent, redland,
     liblouis, tcpdump, gnome-characters, libblockdev, librdmacm, lua-
     socket, dconf, xz-libs, dbus-glib, cyrus-sasl-plain, libdvdnav,
     libcap, libvirt-daemon-driver-storage-zfs, libwbclient, libvirt-
     daemon-driver-storage-gluster, numad, mod_http2, libthai, fakeroot,
     gnome-session, adcli, iproute, libsmartcols, gsound, fakeroot-libs,
     orc-compiler, libwpg, os-prober, ethtool, info, vorbis-tools,
     libfprint, systemd-libs, cpio, libknet1, libfdt, util-linux, libburn,
     apr-util-bdb, krb5-libs, gnome-online-accounts, net-tools, enca,
     llvm6.0-libs, libblockdev-part, libpciaccess, clucene-core,
     libsss_autofs, kmod, libxml++, NetworkManager-pptp, libetonyek,
     libcanberra-gtk2, libgs, gnome-user-share, sssd-client, libgxps,
     systemd, webkit2gtk3-jsc, libpagemaker, highlight, libxkbcommon,
     device-mapper-multipath-libs, yajl, lockdev, cups-filters-libs,
     geocode-glib, lpsolve, xorg-x11-server-utils, gnupg2, libvirt-daemon-
     driver-storage-iscsi-direct, marisa, evince-libs, libepubgen, libdnf,
     gnuplot-common, abrt-addon-pstoreoops, gnome-keyring, pulseaudio-libs-
     glib2, egl-utils, lxpolkit, nm-connection-editor, python3-pyparted,
     libudisks2, gstreamer1-plugins-bad-free, python3-setools, clutter,
     zenity, rhythmbox, chkconfig, hostname, iscsi-initiator-utils,
     librados2, source-highlight, subunit, pam, python2-cffi, kmod-
     VirtualBox-4.19.13-300.fc29.x86_64, openldap, evince-nautilus, ipcalc,
     NetworkManager-team, speex, libvirt-daemon-driver-storage-logical,
     neon, rest, libsamplerate, python2-lxml, NetworkManager-vpnc-gnome,
     boost-iostreams, poppler-utils, pakchois, zfs-fuse, libusbmuxd, perl-
     Unicode-Normalize, libimobiledevice, lzop, NetworkManager-wwan,
     polkit-pkla-compat, jbig2dec-libs, libmtp, cyrus-sasl-lib, librevenge,
     nspr, gjs, python3-gobject-base, gnome-settings-daemon, dnsmasq,
     geoclue2-libs, libXfixes, libblkid, libcdio, libsss_sudo, rsync, rpm,
     lua-libs, perl-Params-Util, authselect-libs, soundtouch, xorg-x11-drv-
     evdev, libpeas-gtk, libXinerama, libteam, vim-enhanced, libcmis,
     elfutils-libs, acl, libogg, libkadm5, gupnp-igd, gstreamer-plugins-
     base, libgee, poco-crypto, libXxf86vm, mesa-libEGL, python2-pyxattr,
     systemd-pam, python2-libvirt, emacs, perl-Storable, perl-Digest-MD5,
     libshout, tigervnc-server-module, perl-Sort-Key, python3-pyopengl,
     nss-util, libsemanage, libstorj, mozjs52, systemd-container, libcomps,
     at, file, aisleriot, libblockdev-fs, java-1.8.0-openjdk-headless,
     libblockdev-nvdimm, libnma, gettext, pcre2-utf32, soxr, bakefile,
     libvirt-gobject, libutempter, gnome-remote-desktop, libmetalink,
     slang, openblas-serial, gvfs-afp, usbutils, e2fsprogs, libcdio-
     paranoia, grub2-tools-minimal, cpp, libksba, libwayland-server,
     virglrenderer, gdbm, osinfo-db-tools, libsndfile, libblockdev-vdo,
     libvisio, tk, poco-json, bzip2-libs, openssl-pkcs11, gnutls, device-
     mapper-persistent-data, python2-krbv, webkit2gtk3-plugin-process-gtk2,
     libselinux-utils, perl-Scalar-List-Utils, dosfstools, rng-tools,
     gnome-abrt, libspectre, icedax, keyutils-libs, libproxy, libreoffice-
     math, libtimezonemap, perl-Data-Dumper, glusterfs-fuse, anaconda-core,
     libnfsidmap, mlocate, tmux, libevdev-utils, file-libs, grub2-tools,
     avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack,
     python3-gobject, libev, frei0r-plugins, fprintd-pam, libusbx,
     NetworkManager-openvpn-gnome, qrencode-libs, libICE, libgexiv2, drpm,
     qemu-block-nfs, createrepo_c-libs, grilo, pcaudiolib, perl-Compress-
     Raw-Zlib, speexdsp, upower, libreoffice-x11, nautilus, xcb-util-wm,
     gtk2-devel, libvirt-gconfig, dbxtool, alsa-lib, gstreamer1-plugins-
     good-gtk, libwnck3, x264-libs, python2-gobject, libvirt-daemon-driver-
     storage-disk, brasero-libs, mesa-dri-drivers, sgpio, python3-abrt,
     libffado, gdbm-libs, fribidi, libgnomekbd, libblockdev-kbd, ibus-
     rawcode, pciutils, libini_config, openssh-clients, libX11, gvfs-smb,
     celt051, kyotocabinet-libs, python3-pwquality, gvfs-mtp,
     python3-cryptography, gnome-bluetooth, u2f-hidraw-policy, libnl3,
     libidn, libvirt-daemon-driver-storage-mpath, grubby, openjpeg-libs,
     python3-libreport, epiphany-runtime, libbytesize, libmpeg2, qemu-
     block-rbd, python3-systemd, rpm-ostree-libs, libnl3-cli, ibus-libs,
     python2-pyyaml, audit-libs, bluez, gettext-libs, liborcus, cups,
     libref_array, gvfs-afc, switcheroo-control, fwupd, raptor2, plymouth-
     plugin-two-step, sbc, qt-x11, libsane-hpaio, libhangul, bash, poppler-
     glib, libgpod, seahorse, libblockdev-lvm, ibus-kkc, lvm2, harfbuzz,
     python3-wrapt, dmraid, libva, gvfs-client, NetworkManager-libnm,
     python2-libs, ibus-qt, gnome-boxes, lrzsz, libglvnd-egl, libunwind,
     python3-newt, dhcp-libs, libtalloc, grep, hypervkvpd, perl-Sys-Syslog,
     libepoxy, perl-Variable-Magic, man-db, gedit, libvirt-daemon-driver-
     storage-core, libibumad, mesa-libgbm, boost-locale, timedatex, fltk,
     xdg-desktop-portal, sssd-nfs-idmap, mingw32-gcc-c++, wireless-tools,
     libdb, passwd, cups-pk-helper, gnome-calculator, kmod-libs, SDL,
     libdv, gutenprint-libs, libreoffice-writer, desktop-file-utils,
     libXdamage, xorg-x11-utils, libmwaw, libusal, gcc-gdb-plugin, dleyna-
     connector-dbus, gtkmm30, unbound-libs, clang5.0-libs, gobject-
     introspection, libpwquality, fontconfig, compat-ffmpeg28, libblockdev-
     dm, python3-sip, perl-Math-BigInt-FastCalc, evince-djvu, libkcapi-
     hmaccalc, libtar, libdaemon, mariadb-connector-c, tcl, flatpak,
     cheese, pkgconf, vino, json-c, sed, sssd-ipa, perl-threads-shared,
     glib-networking, kmod-VirtualBox-4.19.10-300.fc29.x86_64, gdm, kpartx,
     libpng, sane-backends-libs, python3-pillow, poco-netssl, cyrus-sasl,
     hardlink, libcollection, libgcrypt, libmad, cairomm, perl-Unicode-
     UTF8, nss-softokn, geoclue2, lsof, at-spi2-atk, cronie-anacron, gnome-
     online-miners, twolame-libs, adwaita-qt4, adwaita-qt5, gnome-shell,
     cups-ipptool, x11vnc, xorg-x11-server-Xorg, usbmuxd, python3-libcomps,
     perl-IO, VirtualBox-server, libverto, glibmm24, realmd, libmspub,
     ncurses, python2-sip, nfs-utils, graphite2, python3-kerberos, perl-
     version, libreport-plugin-kerneloops, ndctl-libs, gmp, sssd-
     krb5-common, fuse3, volume_key-libs, b43-fwcutter, libmodulemd1,
     python2-Cython, libzapojit, alsa-plugins-pulseaudio, perl-interpreter,
     bluez-cups, libcurl, coreutils, gnutls-utils, libcap-ng, gvfs,
     dbus-x11, pinentry, libvirt-daemon-driver-storage-scsi, cracklib,
     librepo, nautilus-extensions, qemu-common, gsm, libuv, boost-
     filesystem, libtevent, libchamplain, libglvnd, gnome-documents-libs,
     gobject-introspection-devel, boost-system, libpcap, wxBase3, snappy,
     clutter-gst3, python2-wxpython4-webview, mozjs60, libdrm, genisoimage,
     pcre2, shotwell, xmlrpc-c, jsoncpp, perl-TermReadKey, espeak-ng, cogl,
     rygel, libpng-devel, daxctl-libs, libvirt-glib, rasqal,
     python2-wxpython, libmspack, perl-Unicode-Collate, libssh, GConf2,
     glibc, hidapi, wxGTK-media, flatpak-libs, fipscheck, mactel-boot, bc,
     gtk-vnc2, gdk-pixbuf2-devel, wget, gnome-autoar, libijs, openssl,
     boost-regex, python2-unbound, libreport-web, libgomp, libexif,
     libvirt-daemon-driver-secret, tigervnc, libgusb, glib2,
     python3-wxpython4, qemu-system-x86-core, ImageMagick-libs, libproxy-
     mozjs, pcre2-utf16, libmnl, gettext-devel, libzmf, libmng, nss, pcre,
     libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1
     -plugins-base, speech-dispatcher, cdrdao, pciutils-libs, libiptcdata,
     libmpc, libXi, file-roller, openjpeg2, flac-libs, libXt, libXv, rpm-
     libs, libreofficekit, libnfnetlink, libiec61883, gstreamer, rpm-sign-
     libs, mediainfo, device-mapper-event, vtable-dumper, libreport-plugin-
     bugzilla, mingw32-cpp, qt5-qtbase, libpskc, weston-libs, ibus, poco-
     sqlite, jwhois, qemu-block-dmg, curl, yelp-libs, cmake, gnutls-dane,
     gnuplot, libdmapsharing, fipscheck-lib, python2-pycurl, dos2unix,
     samba-libs, paps, libstaroffice, abrt-tui, lzo-minilzo, pinfo,
     tpm2-tss, gtk3-devel, abrt-addon-xorg, libdhash, gnome-keyring-pam,
     sssd-proxy, zchunk-libs, totem, gd, gc, python3-cups, libxshmfence,
     libreport-plugin-systemd-journal, gstreamer1-plugins-ugly-free, p11
     -kit-server, unzip, apr-util-openssl, gtk2, gtk3, libwayland-egl,
     libv4l, atkmm, npth, abrt-addon-coredump-helper, libyaml, mercurial,
     libXaw, gspell, xcb-util-image, m17n-lib, libfilezilla, libblockdev-
     mdraid, glusterfs, exiv2-libs, libunistring, dleyna-server,
     qgnomeplatform, gstreamer1-plugins-good, python2-rpm, libasyncns,
     qemu-block-curl, device-mapper-multipath, c-ares, xmlsec1-openssl,
     poco-util, python2-cairo, gfbgraph, NetworkManager-pptp-gnome,
     jansson, bind-utils, librsvg2, firefox, apr, libsss_nss_idmap, gupnp-
     dlna, trousers-lib, poco-debug, libnumbertext, zip, webrtc-audio-
     processing, bcache-tools, startup-notification, libqxp, harfbuzz-
     devel, bubblewrap, gcc-c++, speech-dispatcher-espeak-ng, libtasn1,
     jbigkit-libs, libe-book, freerdp1.2, alsa-utils, sqlite, tar, sudo,
     dhcp-client, wxBase3-devel, fprintd, pinentry-gtk, gcc, sip,
     mingw32-gcc, dwz, xorg-x11-drv-qxl, gcr, oddjob, ebtables, avahi-libs,
     kmod-VirtualBox-4.20.3-200.fc29.x86_64, pigz, python3-pyyaml, libquvi,
     gvfs-archive, libao, poco-odbc, tinyxml2, lz4, kbd, dbus-daemon,
     mingw32-pkg-config, libreoffice-core, wayland-devel, libphodav,
     libwayland-cursor, openvpn, flex, gstreamer1-plugins-ugly, xvidcore,
     libwacom, lzo, pango, libss, krb5-devel, mod_dnssd, polkit-libs, perl-
     threads, perl-Params-Validate, pangomm, mesa-libxatracker, nss-
     sysinit, LibRaw, nss-mdns, python3-cffi, openjade, at-spi2-core,
     libvirt-daemon-driver-network, glibc-common, liblockfile, bind-export-
     libs, ndctl, poco-xml, python3-libxml2, libnfs, libgfortran, stoken-
     libs, gnome-contacts, libiscsi, groff-base, libusb, openssh-askpass,
     mesa-libGL, abrt-addon-ccpp, libldb, python2-gobject-base,
     NetworkManager-vpnc, libvirt-daemon-driver-nodedev, libipt,
     libcanberra, webkit2gtk3-jsc-devel, grub2-tools-efi, python3-evdev,
     libgudev, xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba-
     client-libs, which, boost-chrono, samba-client, libaio, lua-expat,
     emacs-common, python3-cccolutils, libquadmath, qemu-ui-curses, gvfs-
     gphoto2, brlapi, strace, createrepo_c, python2-markupsafe, elinks,
     poco-zip, libreport-gtk, liboauth, lmdb-libs, mingw-binutils-generic,
     xmlsec1, isns-utils-libs, libwsman1, krb5-workstation, perl-libs,
     mcpp, nmap-ncat, libglvnd-opengl, lz4-libs, usb_modeswitch,
     python3-libdnf, mythes, evolution, NetworkManager-wifi, qt, abrt-
     retrace-client, wxGTK-devel, teamd, libvorbis, vconfig, wxGTK3-media,
     pcre-cpp, python3-libselinux, libodfgen, webkit2gtk3-devel,
     mingw32-binutils, libvirt-daemon-driver-storage-rbd, exiv2, iptables,
     lua, libpeas-loader-python3, llvm-libs, gnome-logs, doxygen,
     pulseaudio-module-bluetooth, libvirt-libs, valgrind, portaudio,
     passwdqc, libXft, schroedinger, libattr, hyphen, gnupg2-smime, gnome-
     software, qemu-audio-oss, syslinux, libxcrypt, newt, iptstate,
     glib2-devel, libreport-plugin-ureport, radvd, python3-lxml,
     python3-libs, glusterfs-cli, perl-PathTools, ipset-libs, wxGTK-gl,
     perl-Devel-Size, plymouth-graphics-libs, gnome-menus, glusterfs-
     client-xlators, libreoffice-pyuno, libpaper, libxml2, libgepub,
     libreoffice-ure, python3-pyaudio, iscsi-initiator-utils-iscsiuio,
     cyrus-sasl-gssapi, mpage, libargon2, mousetweaks, libvirt-daemon,
     libsecret, p11-kit-trust, NetworkManager-bluetooth, fuse-sshfs,
     augeas-libs, libsysfs, libxmlb, python3-numpy, audit, wxGTK3-gl, abrt-
     dbus, gnome-desktop3, gdk-pixbuf2-modules, binutils, xen-libs,
     libisofs, vim-common, python2-kerberos, less, brltty, libvpx, evince,
     rpm-build-libs, libnghttp2, ostree-libs, totem-nautilus, libsolv,
     exempi, libxkbcommon-x11, libtdb, python3-gpg, libXdmcp, perl-Socket,
     apr-util, aspell, libatomic, libvisual, python3, python2, gpm-libs,
     xorg-x11-server-Xwayland, perl-DB_File, dbus-tools, shared-mime-info,
     httpd-tools, SDL2, webkit2gtk3, libsigsegv, boost-thread, grilo-
     plugins, dvd+rw-tools, shadow-utils, dbus-glib-devel, libXau,
     mingw32-nsis, netcf-libs, libgdata, libvirt-client, pulseaudio-
     module-x11, dmidecode, qemu-audio-alsa, libmbim, libjpeg-turbo, spice-
     gtk3, fuse3-libs, libmount, spice-vdagent, xorg-x11-drv-wacom-serial-
     support, xorg-x11-drv-fbdev, libqb, libavc1394, lldpad, libtiff,
     python3-libsemanage, libvncserver, sg3_utils-libs, libnotify, ima-evm-
     utils, bind-libs-lite, grub2-tools-extra, qemu-audio-sdl, openssh-
     server, mutter, taglib, libXext, libblockdev-utils, ModemManager-glib,
     dracut, ostree, device-mapper-event-libs, initscripts, hunspell,
     libieee1284, wxGTK3, libndp, pulseaudio, weston, qemu-ui-sdl, bzip2,
     elfutils-libelf, nss-softokn-freebl, open-vm-tools, evolution-ews,
     python3-smartcols, libtool-ltdl, readline, eog, yelp, xorg-x11-drv-
     intel, abrt-java-connector, passwdqc-lib), /usr/lib/.build-
     id/92(python3-wxpython4, poppler-utils, less, gstreamer1-plugins-bad-
     free, rhash, systemd-udev, brasero, libreoffice-core, libicu, libgsf,
     java-1.8.0-openjdk-headless, glibc, ima-evm-utils, iscsi-initiator-
     utils, shadow-utils, tracker-miners, gstreamer1-plugins-ugly, cyrus-
     sasl, gstreamer1-plugins-good, eog, hplip, speech-dispatcher-espeak-
     ng, device-mapper-multipath-libs, clang5.0-libs, libcanberra),
     /usr/lib/.build-id/e0(vino, gstreamer1-plugins-bad-free, qemu-ui-gtk,
     ImageMagick-libs, brasero, libreoffice-core, systemd, libpwquality,
     java-1.8.0-openjdk-headless, glibc, xmlsec1-nss, libibverbs, subunit,
     fipscheck, python3-libs, dhcp-libs, poco-net, libiodbc, evolution-
     data-server, xmlrpc-c, pulseaudio, bind-utils, net-tools, xen-libs),
     /usr/lib/.build-id/e3(corosynclib, systemd-container, efibootmgr,
     java-1.8.0-openjdk-headless, python2-smartcols, qgnomeplatform,
     ImageMagick-libs, python2-wxpython, gstreamer-plugins-base, weston,
     VirtualBox-server, libical, passwdqc-lib, totem, portaudio, lua-
     socket, gnome-software, pango), /usr/lib/.build-id/f7(python3-lxml,
     libreoffice-core, nss, pango, apr-util-openssl, httpd, gstreamer1
     -plugins-good, python3-libs, coreutils, systemd, grub2-tools, brltty,
     libnl3-cli, libgudev, util-linux, pam, avahi-glib), /usr/lib/.build-
     id/e4(iptables, httpd, python3-wxpython4, vorbis-tools, sssd-common,
     elfutils-libs, glibc, libgdither, sudo, totem, libglvnd-egl, glibmm24,
     openssh-askpass, brltty, libnl3-cli, crda, gstreamer1-plugins-bad-
     free, libreoffice-core), /usr/lib/.build-id/08(gnome-online-miners,
     mtools, rhythmbox, libreoffice-core, libpkgconf, sssd-common, open-vm-
     tools-desktop, java-1.8.0-openjdk-headless, libvirt-daemon,
     libetonyek, fontconfig, python2-libs, libsoup, pam, kmod-
     VirtualBox-4.19.13-300.fc29.x86_64, gawk, gdk-pixbuf2-devel, nfs-
     utils, bash, glibc-common, evolution, gutenprint-cups, libqb),
     /usr/lib/.build-id/5b(open-vm-tools, systemd, mingw32-gcc, tpm2-tools,
     ModemManager, libgphoto2, cups-client, libatomic, python2-wxpython,
     dmidecode, colord-libs, tk, brltty, libnl3-cli, gnome-software, samba-
     client-libs, cheese-libs), /usr/lib/.build-id/32(cronie-anacron,
     python2-crypto, colord, less, gstreamer1-plugins-bad-free,
     ImageMagick-libs, python2-Cython, libreoffice-core, xdg-desktop-
     portal, glibc, frei0r-plugins, librados2, tk, iptables, grub2-tools-
     extra, libgphoto2, sni-qt, sane-backends-drivers-scanners, gstreamer1
     -plugins-good, python3-abrt, gutenprint, shotwell, PackageKit, device-
     mapper-multipath-libs, gdk-pixbuf2-modules, rygel, binutils,
     freerdp1.2), /usr/lib/.build-id/d8(gstreamer1-plugins-bad-free,
     ImageMagick-libs, iproute, ppp, libsamplerate, systemd, sssd-common,
     samba-client-libs, btrfs-progs, shadow-utils, VirtualBox-server,
     libnl3, liblangtag, iptables, gstreamer1-plugins-good, mutter, util-
     linux, evolution, elfutils-libs, xorg-x11-xauth, pulseaudio, net-
     tools, libcanberra, libieee1284), /usr/lib/.build-id/ca(xorg-x11
     -server-utils, evolution, libvisio, elfutils-libs, coreutils,
     gstreamer1-plugins-good, gedit, device-mapper, gdm, lame-libs,
     krb5-workstation, zfs-fuse, LibRaw, frei0r-plugins, dleyna-server,
     libreoffice-core, util-linux, gnome-software, pam, binutils,
     gstreamer1-plugins-base), /usr/lib/.build-id/9a(udisks2, xfsprogs,
     gstreamer1-plugins-bad-free, weston-libs, kbd, cups, httpd, samba-
     client-libs, libosinfo, fwupd, raptor2, python3-pillow, iptables,
     mesa-dri-drivers, libglvnd-opengl, sane-backends-drivers-scanners,
     brltty, util-linux, evolution, evolution-data-server, libXaw,
     libselinux, binutils), /usr/lib/.build-id/64(cups-filters, gstreamer-
     plugins-base, deltarpm, VirtualBox-server, gnome-abrt, gnome-software,
     libreoffice-core, httpd, GConf2, libreport-plugin-reportuploader,
     coreutils, make, python2-cryptography, shadow-utils, compat-ffmpeg28,
     frei0r-plugins, xorg-x11-drv-ati, python2-libs, hidapi,
     libtimezonemap, wxGTK3, audit, portaudio, qt5-qtbase-gui, libv4l,
     redland, shotwell, dotconf, pulseaudio, glibc), /usr/lib/.build-
     id/9d(python2-crypto, lcms2, gstreamer1-plugins-bad-free, ImageMagick-
     libs, python2-wxpython, iproute, firefox, isns-utils-libs, java-1.8.0
     -openjdk-headless, glibc, python3-gobject, httpd, pipewire, frei0r-
     plugins, libabigail, pam, fipscheck-lib, iptables, groff-base, psacct,
     bind-utils, fuse-sshfs, genisoimage, augeas-libs, brltty, perl-Net-
     SSLeay, libblockdev-kbd, e2fsprogs, gcc-gdb-plugin, libnl3-cli)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 92160 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Package uses hardened build flags if required to.
     Note: suid files: afppasswd
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
     Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
     echo $version)) missing?

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     netatalk-devel , netatalk-debuginfo , netatalk-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.13 starting (python version = 3.7.2)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.13
INFO: Mock Version: 1.4.13
Finish: chroot init
INFO: installing package(s): /home/talbert/fedora-review/1658199-netatalk/results/netatalk-debugsource-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-debuginfo-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-devel-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-3.1.12-1.fc30.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 30 --disableplugin=local --setopt=deltarpm=False install /home/talbert/fedora-review/1658199-netatalk/results/netatalk-debugsource-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-debuginfo-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-devel-3.1.12-1.fc30.x86_64.rpm /home/talbert/fedora-review/1658199-netatalk/results/netatalk-3.1.12-1.fc30.x86_64.rpm



Rpmlint
-------
Checking: netatalk-3.1.12-1.fc30.x86_64.rpm
          netatalk-devel-3.1.12-1.fc30.x86_64.rpm
          netatalk-debuginfo-3.1.12-1.fc30.x86_64.rpm
          netatalk-debugsource-3.1.12-1.fc30.x86_64.rpm
          netatalk-3.1.12-1.fc30.src.rpm
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755
netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755
netatalk.x86_64: W: no-manual-page-for-binary cnid2_create
netatalk-devel.x86_64: W: incoherent-version-dependency-on netatalk/netatalk-libs/libnetatalk 3.1.12 5:3.1.12
5 packages and 0 specfiles checked; 4 errors, 2 warnings.




Requires
--------
netatalk (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/perl
    /usr/bin/python3
    /usr/sbin/ldconfig
    config(netatalk)
    dbus-python
    dconf
    libacl.so.1()(64bit)
    libacl.so.1(ACL_1.0)(64bit)
    libatalk.so.18()(64bit)
    libattr.so.1()(64bit)
    libavahi-client.so.3()(64bit)
    libavahi-common.so.3()(64bit)
    libc.so.6()(64bit)
    libcom_err.so.2()(64bit)
    libcrack.so.2()(64bit)
    libcrypt.so.2()(64bit)
    libcrypt.so.2(XCRYPT_2.0)(64bit)
    libcrypto.so.1.1()(64bit)
    libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
    libdb-5.3.so()(64bit)
    libdbus-glib-1.so.2()(64bit)
    libdl.so.2()(64bit)
    libevent-2.1.so.6()(64bit)
    libgcrypt.so.20()(64bit)
    libgcrypt.so.20(GCRYPT_1.6)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgpg-error.so.0()(64bit)
    libgssapi_krb5.so.2()(64bit)
    libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit)
    libgthread-2.0.so.0()(64bit)
    libk5crypto.so.3()(64bit)
    libkrb5.so.3()(64bit)
    libkrb5.so.3(krb5_3_MIT)(64bit)
    libldap-2.4.so.2()(64bit)
    libm.so.6()(64bit)
    libmariadb.so.3()(64bit)
    libmariadb.so.3(libmysqlclient_18)(64bit)
    libpam.so.0()(64bit)
    libpam.so.0(LIBPAM_1.0)(64bit)
    libpthread.so.0()(64bit)
    libssl.so.1.1()(64bit)
    libtdb.so.1()(64bit)
    libtdb.so.1(TDB_1.2.1)(64bit)
    libtracker-sparql-2.0.so.0()(64bit)
    libz.so.1()(64bit)
    perl(IO::Socket::INET6)
    rtld(GNU_HASH)
    systemd

netatalk-debuginfo (rpmlib, GLIBC filtered):

netatalk-devel (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libatalk.so.18()(64bit)
    netatalk(x86-64)

netatalk-debugsource (rpmlib, GLIBC filtered):



Provides
--------
netatalk:
    config(netatalk)
    libatalk.so.18()(64bit)
    netatalk
    netatalk(x86-64)

netatalk-debuginfo:
    debuginfo(build-id)
    netatalk-debuginfo
    netatalk-debuginfo(x86-64)

netatalk-devel:
    netatalk-devel
    netatalk-devel(x86-64)

netatalk-debugsource:
    netatalk-debugsource
    netatalk-debugsource(x86-64)



Unversioned so-files
--------------------
netatalk: /usr/lib64/netatalk/uams_clrtxt.so
netatalk: /usr/lib64/netatalk/uams_dhx.so
netatalk: /usr/lib64/netatalk/uams_dhx2.so
netatalk: /usr/lib64/netatalk/uams_dhx2_pam.so
netatalk: /usr/lib64/netatalk/uams_dhx2_passwd.so
netatalk: /usr/lib64/netatalk/uams_dhx_pam.so
netatalk: /usr/lib64/netatalk/uams_dhx_passwd.so
netatalk: /usr/lib64/netatalk/uams_gss.so
netatalk: /usr/lib64/netatalk/uams_guest.so
netatalk: /usr/lib64/netatalk/uams_pam.so
netatalk: /usr/lib64/netatalk/uams_passwd.so
netatalk: /usr/lib64/netatalk/uams_pgp.so
netatalk: /usr/lib64/netatalk/uams_randnum.so

Source checksums
----------------
http://download.sourceforge.net/netatalk/netatalk-3.1.12.tar.bz2 :
  CHECKSUM(SHA256) this package     : 1560f83a3da41be97e0b70a96e2402159b8ddc631d38538360b14784beada5d1
  CHECKSUM(SHA256) upstream package : 1560f83a3da41be97e0b70a96e2402159b8ddc631d38538360b14784beada5d1


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1658199 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++, Perl
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 20 Scott Talbert 2019-02-03 01:29:47 UTC
Created attachment 1526332 [details]
licensecheck output

Comment 21 Andrew Bauer 2019-02-03 16:55:14 UTC
Made the following changes:

- updated source url to use https
- buildrequires perl-generators
- (re)added epoch to devel subpackage requires
- use %make_build instead of make
- added Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
     echo $version))
- added additional licenses to License tag

NOTES: 
Expat license = MIT
Unknown license(s) fall under the license statement pointed to by %license

UPDATED SPEC URL: 
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec

UPDATE SOURCE RPM:
https://kojipkgs.fedoraproject.org//work/tasks/5245/32515245/netatalk-3.1.12-2.fc30.src.rpm

Comment 22 Andrew Bauer 2019-02-03 16:56:16 UTC
rpmlint seems okay (nothing new):

$ rpmlint *.rpm
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755
netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755
netatalk.x86_64: W: no-manual-page-for-binary cnid2_create
5 packages and 0 specfiles checked; 4 errors, 1 warnings.

Comment 23 Scott Talbert 2019-02-05 01:02:31 UTC
So, the package still fails to install on Rawhide:

$ sudo dnf install netatalk-3.1.12-2.fc30.x86_64.rpm
Last metadata expiration check: 2 days, 0:31:49 ago on Sat 02 Feb 2019 07:22:16 PM EST.
Error: 
 Problem: conflicting requests
  - nothing provides /usr/sbin/ldconfig needed by netatalk-5:3.1.12-2.fc30.x86_64

I think it's because of this:

> # rhel <= 7 need to call ldconfig
> %if 0%{?rhel} <= 7
> %global ldconfig /usr/sbin/ldconfig
> %endif

This is going to evaluate to true on Fedora.

Comment 24 Andrew Bauer 2019-02-05 14:51:59 UTC
Well that's interesting. That sure does evaluate to true on Fedora. Despite that, I am able to install the netatalk package on my system because /usr/sbin/ldconfig still exists on the filesystem, even though no package provides it. Chalk that up to multiple Fedora upgrades over the years, I guess.

> $ ls -lh /usr/sbin/ldconfig
> -rwxr-xr-x 1 root root 1.2M Dec 13 18:58 /usr/sbin/ldconfig

> $ dnf whatprovides /usr/sbin/ldconfig
> Last metadata expiration check: 1 day, 20:40:27 ago on Sun 03 Feb 2019 11:35:09 AM CST.
> Error: No Matches found

This dependency has been fixed the latest netatalk build.

Fedora:
> $ rpm -qpR netatalk-3.1.12-2.fc29.x86_64.rpm |grep ldconfig
> $

Rhel:
> $ rpm -qpR netatalk-3.1.12-2.el7.x86_64.rpm |grep ldconfig
> /usr/sbin/ldconfig


I may have to re-evaluate that macro again when rhel 8 is released. I do not know at this time whether rhel 8 will require ldconfig or not, but I will deal with that when the time comes.


Updated SPEC URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec

Update Source RPM:
https://kojipkgs.fedoraproject.org//work/tasks/3501/32553501/netatalk-3.1.12-2.fc30.x86_64.rpm

Comment 25 Scott Talbert 2019-02-05 23:50:32 UTC
> # rhel need to call ldconfig
> %if 0%{?rhel}
> %global ldconfig /usr/sbin/ldconfig
> %endif

Actually, I think the problem is that the actual path is /sbin/ldconfig not /usr/sbin/ldconfig.  The file-based Provides seem to only work for the real path, not symlinked ones.  I don't know how you are able to install it onto your system.  Are you using dnf to install it?

Also, I think you could keep the rhel version check and do something like:
%if 0%{?rhel} && 0%{?rhel} <=7

Comment 26 Andrew Bauer 2019-02-06 00:15:27 UTC
From my el7 server:

> $ type ldconfig
> ldconfig is /usr/sbin/ldconfig

Performing a yum whatprovides /usr/sbin/ldconfig, shows the binary is part of the glibc package:

>$ yum whatprovides /usr/sbin/ldconfig
>Loaded plugins: fastestmirror, langpacks
>Loading mirror speeds from cached hostfile
> * base: mirror.tzulo.com
> * epel: d2lzkl7pfhq30w.cloudfront.net
> * extras: mirror.steadfastnet.com
> * rpmfusion-free-updates: muug.ca
> * rpmfusion-nonfree-updates: muug.ca
> * updates: mirror.tzulo.com
>glibc-2.17-260.el7_6.3.x86_64 : The GNU libc libraries
>Repo        : @updates
>Matched from:
>Filename    : /usr/sbin/ldconfig

For el7, the path to ldconfig is correct. 

For fedora, what we care is about is ensuring that the %ldconfig macro is not defined at all, which is the case with the last change I made.

The netatalk package currently installs on two machines I have running, one f28 the other f29.
It installs on my machines because I do in fact have /usr/sbin/ldconfig present on the filesystem, on both of these machines. It is a mystery why it is present, but that is the reason why I can install the package and you cannot.

Unless we can find some documentation stating definitively whether or not rhel 8 will require calling ldconfig, I'd rather just leave the macro as it is set currently.

Comment 27 Scott Talbert 2019-02-06 00:52:07 UTC
(In reply to Andrew Bauer from comment #26)
> From my el7 server:
> 
> > $ type ldconfig
> > ldconfig is /usr/sbin/ldconfig
> 
> Performing a yum whatprovides /usr/sbin/ldconfig, shows the binary is part
> of the glibc package:

Ah, right.  EL7 still uses yum, I do see the provide for /usr/sbin/ldconfig with yum on EL7.  However it doesn't show up for dnf on EL7.

> For el7, the path to ldconfig is correct. 
> 
> For fedora, what we care is about is ensuring that the %ldconfig macro is
> not defined at all, which is the case with the last change I made.
> 
> The netatalk package currently installs on two machines I have running, one
> f28 the other f29.
> It installs on my machines because I do in fact have /usr/sbin/ldconfig
> present on the filesystem, on both of these machines. It is a mystery why it
> is present, but that is the reason why I can install the package and you
> cannot.

Well, I looked on my systems - it turns out that /usr/sbin/ldconfig is there as well.  It appears that it's a hard link between /sbin/ldconfig.  The presence or absence of /usr/sbin/ldconfig isn't what's causing the installation failure, though.  It's dnf not seeing a Provide for /usr/sbin/ldconfig.  Are you perhaps installing directly with rpm or something?

> Unless we can find some documentation stating definitively whether or not
> rhel 8 will require calling ldconfig, I'd rather just leave the macro as it
> is set currently.

Well, rhel 8 will certainly be using dnf so I think you should probably use the /sbin/ldconfig path that it will find.  That's what the packaging guidelines use, anyway.

Comment 28 Andrew Bauer 2019-02-09 01:48:36 UTC
I have edited the ldconfig macro to point to /sbin/ldconfig, rather than /usr/sbin/ldconfig. 

Note that on Fedora, this change won't make a difference because %ldconfig is not defined. This is by design for fedora >= f28. See: https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_Libraries


Updated SPEC URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec

Update Source RPM:
https://kojipkgs.fedoraproject.org//work/tasks/9806/32679806/netatalk-3.1.12-2.fc30.src.rpm


Observe successful installation of the package on fedora 29:

>$ sudo dnf install netatalk-3.1.12-2.fc29.x86_64.rpm
>Last metadata expiration check: 0:08:08 ago on Fri 08 Feb 2019 07:28:18 PM CST.
>Dependencies resolved.
>================================================================================
> Package                  Arch       Version             Repository        Size
>================================================================================
>Installing:
> netatalk                 x86_64     5:3.1.12-2.fc29     @commandline     534 k
>Installing dependencies:
> dconf                    x86_64     0.30.1-1.fc29       updates           93 k
> perl-Socket6             x86_64     0.29-1.fc29         updates           30 k
> perl-IO-Socket-INET6     noarch     2.72-14.fc29        fedora            28 k
>
>Transaction Summary
>================================================================================
>Install  4 Packages
>
>Total size: 685 k
>Total download size: 151 k
>Installed size: 2.0 M
>Is this ok [y/N]: y
>Downloading Packages:
>(1/3): perl-Socket6-0.29-1.fc29.x86_64.rpm      112 kB/s |  30 kB     00:00    
>(2/3): perl-IO-Socket-INET6-2.72-14.fc29.noarch 103 kB/s |  28 kB     00:00    
>(3/3): dconf-0.30.1-1.fc29.x86_64.rpm           230 kB/s |  93 kB     00:00    
>--------------------------------------------------------------------------------
>Total                                            46 kB/s | 151 kB     00:03     
>Running transaction check
>Transaction check succeeded.
>Running transaction test
>Transaction test succeeded.
>Running transaction
>  Preparing        :                                                        1/1 
>  Installing       : perl-Socket6-0.29-1.fc29.x86_64                        1/4 
>  Installing       : perl-IO-Socket-INET6-2.72-14.fc29.noarch               2/4 
>  Installing       : dconf-0.30.1-1.fc29.x86_64                             3/4 
>  Installing       : netatalk-5:3.1.12-2.fc29.x86_64                        4/4 
>  Running scriptlet: netatalk-5:3.1.12-2.fc29.x86_64                        4/4 
>  Running scriptlet: dconf-0.30.1-1.fc29.x86_64                             4/4 
>  Running scriptlet: netatalk-5:3.1.12-2.fc29.x86_64                        4/4 
>  Verifying        : dconf-0.30.1-1.fc29.x86_64                             1/4 
>  Verifying        : perl-Socket6-0.29-1.fc29.x86_64                        2/4 
>  Verifying        : perl-IO-Socket-INET6-2.72-14.fc29.noarch               3/4 
>  Verifying        : netatalk-5:3.1.12-2.fc29.x86_64                        4/4
>
>Installed:
>  netatalk-5:3.1.12-2.fc29.x86_64    dconf-0.30.1-1.fc29.x86_64                 
>  perl-Socket6-0.29-1.fc29.x86_64    perl-IO-Socket-INET6-2.72-14.fc29.noarch   
>
>Complete!


Also note the latest package has no dependencies on ldconfig when built on Fedora, which is what we want:
>$ rpm -qpR netatalk-3.1.12-2.fc29.x86_64.rpm |grep ldconfig
>$

Comment 29 Scott Talbert 2019-02-12 00:59:39 UTC
Package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* GNU General Public License (v2)", "GPL (v2 or
     later)", "GPL (v3 or later)", "Unknown or generated", "GNU General
     Public License", "BSD 3-clause "New" or "Revised" License", "GNU
     Lesser General Public License (v2.1 or later)", "GNU General Public
     License (v2)", "GNU General Public License (v2 or later)", "Expat
     License", "FSF Unlimited License (with Retention) GNU General Public
     License", "FSF Unlimited License (with Retention)", "*No copyright*
     GPL (v2 or later)", "NTP License", "GNU Lesser General Public License
     (v2 or later)", "GNU Lesser General Public License". 431 files have
     unknown license. Detailed output of licensecheck in /home/talbert
     /fedora-review/1658199-netatalk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/dbus-1/system.d,
     /etc/dbus-1
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 92160 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Package uses hardened build flags if required to.
     Note: suid files: afppasswd
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     netatalk-devel , netatalk-debuginfo , netatalk-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: netatalk-3.1.12-2.fc30.x86_64.rpm
          netatalk-devel-3.1.12-2.fc30.x86_64.rpm
          netatalk-debuginfo-3.1.12-2.fc30.x86_64.rpm
          netatalk-debugsource-3.1.12-2.fc30.x86_64.rpm
          netatalk-3.1.12-2.fc30.src.rpm
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755
netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755
netatalk.x86_64: E: postin-without-ldconfig /usr/lib64/libatalk.so.18.0.0
netatalk.x86_64: E: postun-without-ldconfig /usr/lib64/libatalk.so.18.0.0
netatalk.x86_64: W: no-manual-page-for-binary cnid2_create
5 packages and 0 specfiles checked; 6 errors, 1 warnings.




Rpmlint (debuginfo)
-------------------
Checking: netatalk-debuginfo-3.1.12-2.fc30.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
netatalk (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/perl
    /usr/bin/python3
    config(netatalk)
    dbus-python
    dconf
    libacl.so.1()(64bit)
    libacl.so.1(ACL_1.0)(64bit)
    libatalk.so.18()(64bit)
    libattr.so.1()(64bit)
    libavahi-client.so.3()(64bit)
    libavahi-common.so.3()(64bit)
    libc.so.6()(64bit)
    libcom_err.so.2()(64bit)
    libcrack.so.2()(64bit)
    libcrypt.so.2()(64bit)
    libcrypt.so.2(XCRYPT_2.0)(64bit)
    libcrypto.so.1.1()(64bit)
    libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
    libdb-5.3.so()(64bit)
    libdbus-glib-1.so.2()(64bit)
    libdl.so.2()(64bit)
    libevent-2.1.so.6()(64bit)
    libgcrypt.so.20()(64bit)
    libgcrypt.so.20(GCRYPT_1.6)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgpg-error.so.0()(64bit)
    libgssapi_krb5.so.2()(64bit)
    libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit)
    libgthread-2.0.so.0()(64bit)
    libk5crypto.so.3()(64bit)
    libkrb5.so.3()(64bit)
    libkrb5.so.3(krb5_3_MIT)(64bit)
    libldap-2.4.so.2()(64bit)
    libm.so.6()(64bit)
    libmariadb.so.3()(64bit)
    libmariadb.so.3(libmysqlclient_18)(64bit)
    libpam.so.0()(64bit)
    libpam.so.0(LIBPAM_1.0)(64bit)
    libpthread.so.0()(64bit)
    libssl.so.1.1()(64bit)
    libtdb.so.1()(64bit)
    libtdb.so.1(TDB_1.2.1)(64bit)
    libtracker-sparql-2.0.so.0()(64bit)
    libz.so.1()(64bit)
    perl(:MODULE_COMPAT_5.28.1)
    perl(File::Basename)
    perl(File::Spec)
    perl(File::Temp)
    perl(IO::Socket::INET6)
    perl(IPC::Open2)
    perl(Socket)
    perl(bigint)
    perl(strict)
    perl(vars)
    rtld(GNU_HASH)
    systemd

netatalk-debuginfo (rpmlib, GLIBC filtered):

netatalk-devel (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libatalk.so.18()(64bit)
    netatalk(x86-64)

netatalk-debugsource (rpmlib, GLIBC filtered):



Provides
--------
netatalk:
    config(netatalk)
    libatalk.so.18()(64bit)
    netatalk
    netatalk(x86-64)

netatalk-debuginfo:
    debuginfo(build-id)
    netatalk-debuginfo
    netatalk-debuginfo(x86-64)

netatalk-devel:
    netatalk-devel
    netatalk-devel(x86-64)

netatalk-debugsource:
    netatalk-debugsource
    netatalk-debugsource(x86-64)



Unversioned so-files
--------------------
netatalk: /usr/lib64/netatalk/uams_clrtxt.so
netatalk: /usr/lib64/netatalk/uams_dhx.so
netatalk: /usr/lib64/netatalk/uams_dhx2.so
netatalk: /usr/lib64/netatalk/uams_dhx2_pam.so
netatalk: /usr/lib64/netatalk/uams_dhx2_passwd.so
netatalk: /usr/lib64/netatalk/uams_dhx_pam.so
netatalk: /usr/lib64/netatalk/uams_dhx_passwd.so
netatalk: /usr/lib64/netatalk/uams_gss.so
netatalk: /usr/lib64/netatalk/uams_guest.so
netatalk: /usr/lib64/netatalk/uams_pam.so
netatalk: /usr/lib64/netatalk/uams_passwd.so
netatalk: /usr/lib64/netatalk/uams_pgp.so
netatalk: /usr/lib64/netatalk/uams_randnum.so

Source checksums
----------------
https://download.sourceforge.net/netatalk/netatalk-3.1.12.tar.bz2 :
  CHECKSUM(SHA256) this package     : 1560f83a3da41be97e0b70a96e2402159b8ddc631d38538360b14784beada5d1
  CHECKSUM(SHA256) upstream package : 1560f83a3da41be97e0b70a96e2402159b8ddc631d38538360b14784beada5d1


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1658199 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++, Perl
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 30 Fedora Update System 2019-02-23 14:22:02 UTC
netatalk-3.1.12-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ad5dde4ffd

Comment 31 Fedora Update System 2019-02-23 14:35:57 UTC
netatalk-3.1.12-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-edbd521304

Comment 32 Fedora Update System 2019-02-23 14:39:19 UTC
netatalk-3.1.12-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-bb312c384c

Comment 33 Fedora Update System 2019-02-24 01:54:15 UTC
netatalk-3.1.12-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-edbd521304

Comment 34 Fedora Update System 2019-02-24 02:17:23 UTC
netatalk-3.1.12-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ad5dde4ffd

Comment 35 Fedora Update System 2019-02-24 03:25:41 UTC
netatalk-3.1.12-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-bb312c384c

Comment 36 Fedora Update System 2019-03-03 22:28:22 UTC
netatalk-3.1.12-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-383849801a

Comment 37 Fedora Update System 2019-03-03 22:29:06 UTC
netatalk-3.1.12-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-49af39dbef

Comment 38 Fedora Update System 2019-03-03 22:29:39 UTC
netatalk-3.1.12-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-a8c9558626

Comment 39 Neal Gompa 2019-03-03 22:31:42 UTC
(In reply to Kevin Kofler from comment #13)
> (In reply to Neal Gompa from comment #3)
> > Drop the Epoch. It's been out of Fedora long enough that it should be
> > removed.
> 
> I disagree. This package has been in Fedora with Epoch 5, so it should never
> be reintroduced with a lower (or no) Epoch. People do skip releases when
> upgrading, or even keep the package from the EOL release if the newer
> release no longer provides it but does not force its removal (either
> deliberately because they still need the package, or accidentally because
> they just forgot about it – and for the record, I am absolutely against
> forced obsoletion of retired packages as long as they still work because
> people may want to keep them deliberately). By dropping the Epoch, you break
> the upgrade path for the people who still have the F23 or pre-F24-Rawhide
> package installed for whatever reason, so they may end up still sticking
> with the obsolete package.

That literally does not matter since system upgrades happen with distro-sync, which ignores Epochs. But it's too late now. :(

Comment 40 Fedora Update System 2019-03-04 01:50:35 UTC
netatalk-3.1.12-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-a8c9558626

Comment 41 Fedora Update System 2019-03-04 02:16:13 UTC
netatalk-3.1.12-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-383849801a

Comment 42 Fedora Update System 2019-03-04 02:19:18 UTC
netatalk-3.1.12-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-49af39dbef

Comment 43 Fedora Update System 2019-03-11 01:11:12 UTC
netatalk-3.1.12-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-075ee1a840

Comment 44 Fedora Update System 2019-03-11 01:12:17 UTC
netatalk-3.1.12-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3309bc7797

Comment 45 Fedora Update System 2019-03-11 01:12:45 UTC
netatalk-3.1.12-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-21582c2da7

Comment 46 Fedora Update System 2019-03-11 20:01:04 UTC
netatalk-3.1.12-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3309bc7797

Comment 47 Fedora Update System 2019-03-11 20:48:44 UTC
netatalk-3.1.12-4.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-21582c2da7

Comment 48 Fedora Update System 2019-03-11 22:26:20 UTC
netatalk-3.1.12-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-075ee1a840

Comment 49 Fedora Update System 2019-03-23 02:24:27 UTC
netatalk-3.1.12-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 50 Fedora Update System 2019-03-23 02:56:18 UTC
netatalk-3.1.12-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 51 Fedora Update System 2019-03-27 05:37:20 UTC
netatalk-3.1.12-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 52 Nigel Jewell 2019-05-04 05:36:55 UTC
Hi,

I've just upgraded to fc30 from fc29 and it seems that the netatalk rpm hasn't made it into the fc30 repository.

Is this a concious decision?  I hope support hasn't been dropped already :)

Thanks,
Nige.

Comment 53 Andrew Bauer 2019-05-04 12:25:20 UTC
That's unexpected.... but the package is in rawhide (f31) so go figure.
This must have come down to timing. Packages are supposed to build automatically when a new branch is created.

Comment 54 Scott Talbert 2019-05-05 03:30:40 UTC
The Fedora 30 branch point was on 2019-02-19, so after that point you would have to have performed separate F30 builds.

Comment 55 Andrew Bauer 2019-05-05 12:15:50 UTC
The f30 branch has been created, but it is still blocked, due to the package's previous orphaned status.

I have put in a request to get it unblocked:
https://pagure.io/releng/issue/8326

Comment 56 Fedora Update System 2019-05-06 12:49:42 UTC
netatalk-3.1.12-4.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae0362961e

Comment 57 Fedora Update System 2019-05-06 21:03:57 UTC
netatalk-3.1.12-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae0362961e

Comment 58 Fedora Update System 2019-05-17 01:04:04 UTC
netatalk-3.1.12-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.