Bug 1520393
| Summary: | [RFE] Better error message for file transfer fail while no applicable filename for Windows OS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Radek Duda <rduda> | ||||
| Component: | spice-vdagent-win | Assignee: | Frediano Ziglio <fziglio> | ||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 8.0 | CC: | cfergeau, dblechte, djasa, elima, fziglio, juzhou, lsurette, mtessun, rbalakri, rduda, spice-qe-bugs, srevivo, tpelka, tyan, tzheng, victortoso, xiaodwan | ||||
| Target Milestone: | rc | Keywords: | FutureFeature | ||||
| Target Release: | --- | Flags: | knoel:
mirror+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | spice-vdagent-win-0.10.0-4 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-11-04 03:17:29 UTC | Type: | Feature Request | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Spice | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1817451, 1817471, 1837489 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Radek Duda
2017-12-04 12:15:06 UTC
Merged a patch at https://gitlab.freedesktop.org/spice/win32/vd_agent/commit/e2ced9f094bf676856ae78779f4a791936eb535f. Should we have a release? Close the bug? (In reply to Frediano Ziglio from comment #1) > Merged a patch at > https://gitlab.freedesktop.org/spice/win32/vd_agent/commit/ > e2ced9f094bf676856ae78779f4a791936eb535f. No. Your patched fixed a bug but did not implement the RFE. The RFE is about error message itself, something that we have in the linux agent already with: https://gitlab.freedesktop.org/spice/linux/vd_agent/commit/ca89a0102cd1 > Should we have a release? > Close the bug? After implementing the RFE we want to add it in RHV, with errata, etc. This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1. Looks like this has been implemented already. We can probably close this. @David, could you check? I think we are missing a build (both upstream and downstream) Tag 0.10.0 has been created: https://gitlab.freedesktop.org/spice/win32/vd_agent/commit/58bc1b958054b5e1e1c5d0fd914e30b64c30653e but the build is missing: https://www.spice-space.org/download/windows/vdagent/ Still waiting for reviews This RFE needs changes in spice-protocol, spice-gtk and the agent (this bug). Spice-protocol fix will be included in rebase bug 1817451 * f224422 "vd_agent: Add a new detail for VD_AGENT_FILE_XFER_STATUS_ERROR status" in 2020-03-19 Spice-gtk fix will be included in rebase bug 1817471 * d79b05d "channel-main: Handle some detailed error for VD_AGENT_FILE_XFER_STATUS_ERROR" in 2020-05-15 If all changes needed in upstream windows agent is merged, should be safe to move this one to POST too! (In reply to Victor Toso from comment #11) > This RFE needs changes in spice-protocol, spice-gtk and the agent (this bug). > > Spice-protocol fix will be included in rebase bug 1817451 > * f224422 "vd_agent: Add a new detail for VD_AGENT_FILE_XFER_STATUS_ERROR > status" in 2020-03-19 > > Spice-gtk fix will be included in rebase bug 1817471 > * d79b05d "channel-main: Handle some detailed error for > VD_AGENT_FILE_XFER_STATUS_ERROR" in 2020-05-15 > > If all changes needed in upstream windows agent is merged, should be safe to > move this one to POST too! I would add that unfortunately these are not enough. Currently virt-viewer through away the detailed errors from spice-gtk not showing them. (In reply to Frediano Ziglio from comment #12) > I would add that unfortunately these are not enough. > Currently virt-viewer through away the detailed errors from spice-gtk not > showing them. I could not find a fix in git master upstream, are there any work pending review? We could bring the fix together with bug 1837489 (without the need to open a new bug in virt-viewer just for this backport) Moving to POST, feel free to revert if you don't agree :) Created attachment 1690241 [details]
Error message with multiple file transfer
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (spice-vdagent-win bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:4721 |