Description of problem:
If I transfer any file from rhel client, which has any of following symbols: '",|,<,>,?,*,:,\,/,' then errormessage appears with notice:
"An error caused the following transfers to fail: $filename".
It is not obvious from this message why transfer fails.
I know that in Windows OS are those symbols forbidden for naming files. But in RHEL it is possible to use even those weird symbols. I propose to have some more pleasant and more specific message there.
"An error caused the following transfers to fail: $filename. Bad file name. $forbiddensymbol symbol in file name is not applicable for Windows OS."
Version-Release number of selected component (if applicable):
rhel 7.5 client:
Steps to Reproduce:
1. Drag and drop file the name of which includes any of the symbol: '",|,<,>,?,*,:,\,/,' from client to guest VM with preinstalled Windows OS
2. See error message
Merged a patch at https://gitlab.freedesktop.org/spice/win32/vd_agent/commit/e2ced9f094bf676856ae78779f4a791936eb535f.
Should we have a release?
Close the bug?
(In reply to Frediano Ziglio from comment #1)
> Merged a patch at
No. Your patched fixed a bug but did not implement the RFE.
The RFE is about error message itself, something that we have in the linux agent already with:
> Should we have a release?
> Close the bug?
After implementing the RFE we want to add it in RHV, with errata, etc.
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.
Looks like this has been implemented already. We can probably close this.
@David, could you check?
I think we are missing a build (both upstream and downstream)
Tag 0.10.0 has been created: https://gitlab.freedesktop.org/spice/win32/vd_agent/commit/58bc1b958054b5e1e1c5d0fd914e30b64c30653e
but the build is missing: https://www.spice-space.org/download/windows/vdagent/
Still waiting for reviews
This RFE needs changes in spice-protocol, spice-gtk and the agent (this bug).
Spice-protocol fix will be included in rebase bug 1817451
* f224422 "vd_agent: Add a new detail for VD_AGENT_FILE_XFER_STATUS_ERROR status" in 2020-03-19
Spice-gtk fix will be included in rebase bug 1817471
* d79b05d "channel-main: Handle some detailed error for VD_AGENT_FILE_XFER_STATUS_ERROR" in 2020-05-15
If all changes needed in upstream windows agent is merged, should be safe to move this one to POST too!
(In reply to Victor Toso from comment #11)
> This RFE needs changes in spice-protocol, spice-gtk and the agent (this bug).
> Spice-protocol fix will be included in rebase bug 1817451
> * f224422 "vd_agent: Add a new detail for VD_AGENT_FILE_XFER_STATUS_ERROR
> status" in 2020-03-19
> Spice-gtk fix will be included in rebase bug 1817471
> * d79b05d "channel-main: Handle some detailed error for
> VD_AGENT_FILE_XFER_STATUS_ERROR" in 2020-05-15
> If all changes needed in upstream windows agent is merged, should be safe to
> move this one to POST too!
I would add that unfortunately these are not enough.
Currently virt-viewer through away the detailed errors from spice-gtk not showing them.
(In reply to Frediano Ziglio from comment #12)
> I would add that unfortunately these are not enough.
> Currently virt-viewer through away the detailed errors from spice-gtk not
> showing them.
I could not find a fix in git master upstream, are there any work pending review? We could bring the fix together with bug 1837489 (without the need to open a new bug in virt-viewer just for this backport)
Moving to POST, feel free to revert if you don't agree :)
Created attachment 1690241 [details]
Error message with multiple file transfer
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory (spice-vdagent-win bug fix and enhancement update), and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.