Bug 1520568

Summary: Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function
Product: [Fedora] Fedora Reporter: Robert-André Mauchin 🐧 <eclipseo>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: jplesnik: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-27 20:39:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1520581    

Description Robert-André Mauchin 🐧 2017-12-04 17:47:10 UTC
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/749fc2d/perl-Crypt-MySQL.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00683987-perl-Crypt-MySQL/perl-Crypt-MySQL-0.04-1.fc28.src.rpm

Description: Crypt::MySQL emulates MySQL PASSWORD() SQL function, without
libmysqlclient. You can compare encrypted passwords, without real MySQL
environment.

Fedora Account System Username: eclipseo

Comment 1 Jitka Plesnikova 2017-12-05 16:30:52 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add following buildrequires:
 - perl(DBI) - t/03_dbi.t:6
 - perl(Exporter) - lib/Crypt/MySQL.pm:17
 - perl(strict) - Build.PL:1
 - perl(vars) - lib/Crypt/MySQL.pm:4
 - perl(warnings) - Build.PL:2
 - perl(XSLoader) - lib/Crypt/MySQL.pm:10
FIX: Please add perl-devel and gcc, because it is XS package

$ rpm -qp --requires perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.26()(64bit)
      1 perl(Digest::SHA1)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
FIX: Please add run-requires
 - perl(Exporter)
 - perl(XSLoader)

$ rpm -qp --provides perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Crypt::MySQL) = 0.04
      1 perl-Crypt-MySQL = 0.04-1.fc28
      1 perl-Crypt-MySQL(x86-64) = 0.04-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Crypt-MySQL*
perl-Crypt-MySQL.src: W: spelling-error %description -l en_US libmysqlclient -> clientele
perl-Crypt-MySQL.x86_64: W: spelling-error %description -l en_US libmysqlclient -> clientele
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and provide new spec file.

Package is not approved.

Comment 3 Jitka Plesnikova 2017-12-07 07:43:24 UTC
> BuildRequires
> FIX: Please add following buildrequires:
>  - perl(DBI) - t/03_dbi.t:6
>  - perl(Exporter) - lib/Crypt/MySQL.pm:17
>  - perl(strict) - Build.PL:1
>  - perl(vars) - lib/Crypt/MySQL.pm:4
>  - perl(warnings) - Build.PL:2
>  - perl(XSLoader) - lib/Crypt/MySQL.pm:10
> FIX: Please add perl-devel and gcc, because it is XS package
Ok.

> $ rpm -qp --requires perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
>       1 libc.so.6()(64bit)
>       1 libc.so.6(GLIBC_2.2.5)(64bit)
>       1 libc.so.6(GLIBC_2.3.4)(64bit)
>       1 libc.so.6(GLIBC_2.4)(64bit)
>       1 libperl.so.5.26()(64bit)
>       1 perl(Digest::SHA1)
>       1 perl(:MODULE_COMPAT_5.26.1)
>       1 perl(strict)
>       1 perl(vars)
>       1 rpmlib(CompressedFileNames) <= 3.0.4-1
>       1 rpmlib(FileDigests) <= 4.6.0-1
>       1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>       1 rpmlib(PayloadIsXz) <= 5.2-1
>       1 rtld(GNU_HASH)
> FIX: Please add run-requires
>  - perl(Exporter)
>  - perl(XSLoader)
Ok.
 
Package looks good.
Approved

Comment 4 Gwyn Ciesla 2017-12-07 13:59:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-MySQL. You may commit to the branch "f27" in about 10 minutes.

Comment 5 Fedora Update System 2017-12-08 11:53:06 UTC
perl-Crypt-MySQL-0.04-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-89b5a07821

Comment 6 Fedora Update System 2017-12-08 11:59:00 UTC
perl-Crypt-MySQL-0.04-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0441b79943

Comment 7 Fedora Update System 2017-12-09 07:28:43 UTC
perl-Crypt-MySQL-0.04-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0441b79943

Comment 8 Fedora Update System 2017-12-10 00:33:15 UTC
perl-Crypt-MySQL-0.04-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-89b5a07821

Comment 9 Fedora Update System 2017-12-19 19:47:32 UTC
perl-Crypt-MySQL-0.04-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-12-19 21:34:52 UTC
perl-Crypt-MySQL-0.04-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-02-07 20:38:05 UTC
perl-Crypt-MySQL-0.04-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4abaf72a99

Comment 12 Fedora Update System 2018-02-08 08:41:57 UTC
perl-Crypt-MySQL-0.04-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4abaf72a99

Comment 13 Fedora Update System 2018-02-27 20:39:15 UTC
perl-Crypt-MySQL-0.04-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.