Bug 1520581 - Review Request: perl-Authen-Passphrase - Hashed passwords/passphrases as objects
Summary: Review Request: perl-Authen-Passphrase - Hashed passwords/passphrases as objects
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1520568 1520569 1520572
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-04 18:51 UTC by Robert-André Mauchin 🐧
Modified: 2018-01-16 17:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-16 16:55:19 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2017-12-04 18:51:59 UTC
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/749fc2d/perl-Authen-Passphrase.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684001-perl-Authen-Passphrase/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm

Description: This is the base class for a system of objects that encapsulate
passphrases. An object of this type is a passphrase recogniser: its job is
to recognise whether an offered passphrase is the right one. For security,
such passphrase recognisers usually do not themselves know the passphrase
they are looking for; they can merely recognise it when they see it. There
are many schemes in use to achieve this effect, and the intent of this
class is to provide a consistent interface to them all, hiding the details.

Fedora Account System Username: eclipseo

Comment 3 Petr Pisar 2018-01-03 16:39:36 UTC
Url and Source0 addresses are Ok.
Source archive (SHA-256: 55db4520617d859d88c0ee54965da815b7226d792b8cdc8debf92073559e0463) is original. Ok.
Summary verified from lib/Authen/Passphrase.pm. Ok.

TODO: The Description text is about Authen::Passphrase module only while the perl-Authen-Passphrase package provides all the modules included in the Authen-Passphrase CPAN distribition. I recommend to change the Description text so that it's more representative. E.g.:

  These Perl modules provide a passphrase recognizer. Its job is
  to recognize whether an offered passphrase is the right one. Various
  passphrase encoding schemes are supported.

License verified from lib/Authen/Passphrase, README, and other files. Ok.
No XS code, noarch BuildArch is Ok.

Build-time requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Authen-Passphrase.spec ../SRPMS/perl-Authen-Passphrase-0.008-1.fc28.src.rpm ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm 
perl-Authen-Passphrase.src: W: spelling-error Summary(en_US) passphrases -> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recogniser -> recognizer, recognize
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognise -> recognize, recognition
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognisers -> recognizes
perl-Authen-Passphrase.noarch: W: spelling-error Summary(en_US) passphrases -> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recogniser -> recognizer, recognize
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recognise -> recognize, recognition
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recognisers -> recognizes
2 packages and 1 specfiles checked; 0 errors, 10 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan  3 17:25 /usr/share/doc/perl-Authen-Passphrase
-rw-r--r--    1 root    root                     8780 Feb  4  2012 /usr/share/doc/perl-Authen-Passphrase/Changes
-rw-r--r--    1 root    root                     1411 Feb  4  2012 /usr/share/doc/perl-Authen-Passphrase/README
-rw-r--r--    1 root    root                     7314 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase.3pm.gz
-rw-r--r--    1 root    root                     2771 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::AcceptAll.3pm.gz
-rw-r--r--    1 root    root                     3718 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::BigCrypt.3pm.gz
-rw-r--r--    1 root    root                     4642 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::BlowfishCrypt.3pm.gz
-rw-r--r--    1 root    root                     2674 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::Clear.3pm.gz
-rw-r--r--    1 root    root                     3676 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::Crypt16.3pm.gz
-rw-r--r--    1 root    root                     5134 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::DESCrypt.3pm.gz
-rw-r--r--    1 root    root                     3068 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::EggdropBlowfish.3pm.gz
-rw-r--r--    1 root    root                     3282 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::LANManager.3pm.gz
-rw-r--r--    1 root    root                     3305 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::LANManagerHalf.3pm.gz
-rw-r--r--    1 root    root                     4133 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::MD5Crypt.3pm.gz
-rw-r--r--    1 root    root                     2894 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::MySQL323.3pm.gz
-rw-r--r--    1 root    root                     2841 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::MySQL41.3pm.gz
-rw-r--r--    1 root    root                     3168 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::NTHash.3pm.gz
-rw-r--r--    1 root    root                     3288 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::NetscapeMail.3pm.gz
-rw-r--r--    1 root    root                     3752 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::PHPass.3pm.gz
-rw-r--r--    1 root    root                     2758 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::RejectAll.3pm.gz
-rw-r--r--    1 root    root                     4561 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::SaltedDigest.3pm.gz
-rw-r--r--    1 root    root                     4472 Jan  3 17:25 /usr/share/man/man3/Authen::Passphrase::VMSPurdy.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen
drwxr-xr-x    2 root    root                        0 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase
-rw-r--r--    1 root    root                    18283 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase.pm
-rw-r--r--    1 root    root                     2743 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/AcceptAll.pm
-rw-r--r--    1 root    root                     7874 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/BigCrypt.pm
-rw-r--r--    1 root    root                    10517 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/BlowfishCrypt.pm
-rw-r--r--    1 root    root                     2717 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/Clear.pm
-rw-r--r--    1 root    root                     7850 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/Crypt16.pm
-rw-r--r--    1 root    root                    14666 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/DESCrypt.pm
-rw-r--r--    1 root    root                     5187 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/EggdropBlowfish.pm
-rw-r--r--    1 root    root                     6158 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/LANManager.pm
-rw-r--r--    1 root    root                     5946 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/LANManagerHalf.pm
-rw-r--r--    1 root    root                     8236 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MD5Crypt.pm
-rw-r--r--    1 root    root                     3944 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MySQL323.pm
-rw-r--r--    1 root    root                     3795 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MySQL41.pm
-rw-r--r--    1 root    root                     5695 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/NTHash.pm
-rw-r--r--    1 root    root                     6085 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/NetscapeMail.pm
-rw-r--r--    1 root    root                     9808 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/PHPass.pm
-rw-r--r--    1 root    root                     2769 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/RejectAll.pm
-rw-r--r--    1 root    root                    12257 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/SaltedDigest.pm
-rw-r--r--    1 root    root                    10930 Jan  3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/VMSPurdy.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Authen::DecHpwd) >= 2.003
      1 perl(Authen::Passphrase) >= 0.003
      1 perl(Authen::Passphrase::DESCrypt)
      1 perl(Authen::Passphrase::LANManagerHalf)
      1 perl(Carp)
      1 perl(Crypt::DES)
      1 perl(Crypt::Eksblowfish::Bcrypt) >= 0.008
      1 perl(Crypt::Eksblowfish::Uklblowfish) >= 0.008
      1 perl(Crypt::MySQL) >= 0.03
      1 perl(Crypt::PasswdMD5) >= 1.0
      1 perl(Crypt::UnixCrypt_XS) >= 0.08
      1 perl(Data::Entropy::Algorithms) >= 0.000
      1 perl(Digest) >= 1.00
      1 perl(Digest::MD4) >= 1.2
      1 perl(Digest::MD5) >= 1.99
      1 perl(Digest::SHA)
      1 perl(MIME::Base64) >= 2.21
      1 perl(Module::Runtime) >= 0.011
      1 perl(Params::Classify) >= 0.000
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm | sort -f | uniq -c
      1 perl(Authen::Passphrase) = 0.008
      1 perl(Authen::Passphrase::AcceptAll) = 0.008
      1 perl(Authen::Passphrase::BigCrypt) = 0.008
      1 perl(Authen::Passphrase::BlowfishCrypt) = 0.008
      1 perl(Authen::Passphrase::Clear) = 0.008
      1 perl(Authen::Passphrase::Crypt16) = 0.008
      1 perl(Authen::Passphrase::DESCrypt) = 0.008
      1 perl(Authen::Passphrase::EggdropBlowfish) = 0.008
      1 perl(Authen::Passphrase::LANManager) = 0.008
      1 perl(Authen::Passphrase::LANManagerHalf) = 0.008
      1 perl(Authen::Passphrase::MD5Crypt) = 0.008
      1 perl(Authen::Passphrase::MySQL323) = 0.008
      1 perl(Authen::Passphrase::MySQL41) = 0.008
      1 perl(Authen::Passphrase::NetscapeMail) = 0.008
      1 perl(Authen::Passphrase::NTHash) = 0.008
      1 perl(Authen::Passphrase::PHPass) = 0.008
      1 perl(Authen::Passphrase::RejectAll) = 0.008
      1 perl(Authen::Passphrase::SaltedDigest) = 0.008
      1 perl(Authen::Passphrase::VMSPurdy) = 0.008
      1 perl-Authen-Passphrase = 0.008-1.fc28
Binary provides are Ok.

Package builds in in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=23984147). Ok.

Otherwise the package is in line with Fedora and Perl packaging guide lines.

Please consider fixing the `TODO' item before building this package.
Resolution: Package is APPROVED.

Comment 4 Gwyn Ciesla 2018-01-04 16:29:49 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Authen-Passphrase. You may commit to the branch "f27" in about 10 minutes.

Comment 5 Fedora Update System 2018-01-08 12:53:41 UTC
perl-Authen-Passphrase-0.008-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-00bb7c3794

Comment 6 Fedora Update System 2018-01-08 13:05:41 UTC
perl-Authen-Passphrase-0.008-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f9b99ce4a

Comment 7 Fedora Update System 2018-01-08 17:42:36 UTC
perl-Authen-Passphrase-0.008-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f9b99ce4a

Comment 8 Fedora Update System 2018-01-08 20:30:07 UTC
perl-Authen-Passphrase-0.008-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-00bb7c3794

Comment 9 Fedora Update System 2018-01-16 16:55:19 UTC
perl-Authen-Passphrase-0.008-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-01-16 17:14:58 UTC
perl-Authen-Passphrase-0.008-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.