Bug 1524330

Summary: [host 4.1 on 4.2 engine] After hotplug devices (memory/CPU) the device configuration is cleared - can't hotplug more devices
Product: [oVirt] ovirt-engine Reporter: Israel Pinto <ipinto>
Component: BLL.VirtAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED CURRENTRELEASE QA Contact: Israel Pinto <ipinto>
Severity: high Docs Contact:
Priority: urgent    
Version: 4.2.0CC: bugs, ipinto, michal.skrivanek
Target Milestone: ovirt-4.2.0Keywords: Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:08:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs(engine,vdsm)
none
operation canceled
none
pending changes dialog
none
graphics - spice set to None
none
engine_log none

Description Israel Pinto 2017-12-11 09:39:49 UTC
Created attachment 1365833 [details]
logs(engine,vdsm)

Description of problem:
Setup with:
Engine: Version:4.2.1-0.0.master.20171208150048.git77336e3.el7.centos
Host 4.1: vdsm-4.19.41-1.el7ev
host is at cluster 4.1 on engine with 4.2 version (master in this case)

Steps:
1. Run VM on 4.1 host
2. Hot plug device (like memory)
3. Hot plug again device (like memory)

Results:
Can hot plug more devices, since all the devices configuration are clean
like Graphics protocol which was set to SPICE set to None
See screenshots
Error message:
Cannot edit VM. Illegal number of monitors is provided, max allowed number of monitors is 1 for VNC and the max number in the ValidNumOfMonitors configuration variable for SPICE.

Comment 1 Israel Pinto 2017-12-11 09:40:30 UTC
Created attachment 1365834 [details]
operation canceled

Comment 2 Israel Pinto 2017-12-11 09:41:08 UTC
Created attachment 1365835 [details]
pending changes dialog

Comment 3 Israel Pinto 2017-12-11 09:41:43 UTC
Created attachment 1365837 [details]
graphics - spice set to None

Comment 4 Israel Pinto 2017-12-11 10:02:05 UTC
Created attachment 1365889 [details]
engine_log

Comment 5 Michal Skrivanek 2017-12-11 10:25:38 UTC
did you test with or without the fix for bug 1522901?

Comment 6 Israel Pinto 2017-12-11 12:18:05 UTC
The fix is for 4.20 vdsm, i running the VM on 4.1 host with vdsm 4.19
so the fix will not related to this case.

Comment 7 Michal Skrivanek 2017-12-11 12:31:41 UTC
sorry, I've meant engine-side fix bug 1523415. But it seems it does need one additional patch.

Comment 8 Tomas Jelinek 2017-12-11 14:24:21 UTC
its in now, so please try with that one.

Comment 9 Michal Skrivanek 2017-12-11 15:04:53 UTC
fix part of bug 1523415
keeping around for independent verification

Comment 10 Israel Pinto 2017-12-12 09:47:37 UTC
Recheck it with fix: 
Engine: Software Version:4.2.1-0.0.master.20171211205712.git7b1f4d1.el7.centos	
vdsm 4.1: vdsm-4.19.42-1.el7ev.x86_64	
vdsm 4.2: vdsm-4.20.9-30.gite026991.el7.centos

Tested with 4.1 and 4.2 hosts

Comment 11 Israel Pinto 2017-12-13 08:52:44 UTC
Verify with:
https://bugzilla.redhat.com/show_bug.cgi?id=1524330#c10

Comment 12 Sandro Bonazzola 2017-12-20 11:08:31 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.