Bug 1523415 - Error while executing action Edit VM properties: Internal Engine Error
Summary: Error while executing action Edit VM properties: Internal Engine Error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ovirt-4.2.0
: ---
Assignee: Tomas Jelinek
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-07 23:08 UTC by Evgheni Dereveanchin
Modified: 2017-12-20 11:45 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:45:02 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+
rule-engine: planning_ack+
michal.skrivanek: devel_ack+
lsvaty: testing_ack+

Attachments (Terms of Use)
engine.log during VM edit attempt (19.71 KB, text/plain)
2017-12-07 23:11 UTC, Evgheni Dereveanchin 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 85207 0 master MERGED core: add null check for resume behavior 2020-02-03 19:48:19 UTC
oVirt gerrit 85255 0 ovirt-engine-4.2.0.z ABANDONED core: add null check for resume behavior 2020-02-03 19:48:20 UTC
oVirt gerrit 85278 0 master MERGED core: dont put null resume behavior to ovf 2020-02-03 19:48:19 UTC

Description Evgheni Dereveanchin 2017-12-07 23:08:36 UTC 
Description of problem:
When trying to update VM properties on 4.2, an engine error pops up and the change is not saved

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-1.el7.centos

How reproducible:
always

Steps to Reproduce:
1. upgrade Engine from 4.1 to 4.2 (still on 4.1 cluster level)
2. create new VM
3. try to update VM settings (change RAM/CPU/RNG/etc)

Actual results:
Error while executing action Edit VM properties: Internal Engine Error

Expected results:
changes applied successfully

Additional info:
will paste the stack trace in the next comment
Comment 1 Evgheni Dereveanchin 2017-12-07 23:11:55 UTC 
Created attachment 1364525 [details]
engine.log during VM edit attempt
Comment 2 Evgheni Dereveanchin 2017-12-07 23:19:08 UTC 
Note: this applies to VMs created before 4.2 as well, not just newly created ones.
Comment 3 Evgheni Dereveanchin 2017-12-08 00:19:50 UTC 
I can also confirm that changing cluster and DC compatibility level to 4.2 makes the NPE go away so it is related to engine-4.2 updating VMs in 4.1 compatibility mode only.
Comment 4 Michal Skrivanek 2017-12-08 08:35:17 UTC 
VmBaseDao::createBaseParametersMapper
.addValue("resume_behavior", entity.getResumeBehavior().toString())

plus

entity.setResumeBehavior(resumeBehavior == null ? null : VmResumeBehavior.valueOf(resumeBehavior))

=> bam
Comment 5 Tomas Jelinek 2017-12-11 09:43:04 UTC 
in meanwhile a new branch have appeared, moving back to post until the patch will merged there
Comment 6 Michal Skrivanek 2017-12-11 12:30:33 UTC 
I would include additional patch to fix OVF reader
Comment 7 Tomas Jelinek 2017-12-11 13:22:47 UTC 
there is a small leftover issue that in some case the resume behavior is reported as a changed field requiring to restart the VM even if it did not change. Tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=1524419
Comment 8 Jiri Belka 2017-12-18 14:31:17 UTC 
ok, ovirt-engine-webadmin-portal-4.2.0.2-0.1.el7.noarch
Comment 9 Sandro Bonazzola 2017-12-20 11:45:02 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.