Bug 1525381

Summary: 'pcs constraint location <rsc> prefers|avoids' should not create any constraint unless the whole command is valid
Product: Red Hat Enterprise Linux 7 Reporter: Tomas Jelinek <tojeline>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED WONTFIX QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 7.5CC: cfeist, cluster-maint, idevat, omular, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1673835 (view as bug list) Environment:
Last Closed: 2020-09-17 11:37:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2017-12-13 08:56:49 UTC
Description of problem:
'pcs constraint location <rsc> prefers|avoids' should not create any constraint unless the whole command is valid


Version-Release number of selected component (if applicable):
pcs-0.9.162-1.el7


How reproducible:
always, easily


Steps to Reproduce:
[root@rh74-node1:~]# pcs constraint
Location Constraints:
Ordering Constraints:
Colocation Constraints:
Ticket Constraints:

[root@rh74-node1:~]# pcs constraint location dummy avoids node1 resource-discovery=never
Error: invalid score 'never', use integer or INFINITY or -INFINITY

[root@rh74-node1:~]# echo $?
1

[root@rh74-node1:~]# pcs constraint
Location Constraints:
  Resource: dummy
    Disabled on: node1 (score:-INFINITY)
Ordering Constraints:
Colocation Constraints:
Ticket Constraints:


Actual results:
A constraint is created. An error is reported and pcs returns 1.


Expected results:
No constraint is created. An error is reported and pcs returns 1.

Comment 2 Tomas Jelinek 2020-09-17 11:37:06 UTC
This has been fixed in RHEL 8: bz1673835.
Considering the current RHEL 7 life cycle stage, there will be no fix for RHEL 7.