RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1673835 - 'pcs constraint location <rsc> prefers|avoids' should not create any constraint unless the whole command is valid
Summary: 'pcs constraint location <rsc> prefers|avoids' should not create any constrai...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: pcs
Version: 8.0
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: 8.2
Assignee: Michal Pospisil
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On: 1682129
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-08 09:24 UTC by Tomas Jelinek
Modified: 2020-04-28 15:28 UTC (History)
7 users (show)

Fixed In Version: pcs-0.10.3-1.el8
Doc Type: Bug Fix
Doc Text:
Cause: user configures location constraints with pcs location constraint prefers/avoids and enters invalid node name or score for other than the first node Consequence: command fails but location constraint had been created for all nodes that had valid node names and scores positioned before the invalid name/score in the command Fix: before creating any location constraints, node names and scores are checked Result: no location constraints are created unless all node names and scores are valid
Clone Of: 1525381
Environment:
Last Closed: 2020-04-28 15:27:56 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:1568 0 None None None 2020-04-28 15:28:35 UTC

Description Tomas Jelinek 2019-02-08 09:24:13 UTC
+++ This bug was initially created as a clone of Bug #1525381 +++

Description of problem:
'pcs constraint location <rsc> prefers|avoids' should not create any constraint unless the whole command is valid


Version-Release number of selected component (if applicable):
pcs-0.9.162-1.el7


How reproducible:
always, easily


Steps to Reproduce:
[root@rh74-node1:~]# pcs constraint
Location Constraints:
Ordering Constraints:
Colocation Constraints:
Ticket Constraints:

[root@rh74-node1:~]# pcs constraint location dummy avoids node1 resource-discovery=never
Error: invalid score 'never', use integer or INFINITY or -INFINITY

[root@rh74-node1:~]# echo $?
1

[root@rh74-node1:~]# pcs constraint
Location Constraints:
  Resource: dummy
    Disabled on: node1 (score:-INFINITY)
Ordering Constraints:
Colocation Constraints:
Ticket Constraints:


Actual results:
A constraint is created. An error is reported and pcs returns 1.


Expected results:
No constraint is created. An error is reported and pcs returns 1.

Comment 3 Michal Pospisil 2019-09-06 08:35:17 UTC
Fix merged into upstream master: https://github.com/ClusterLabs/pcs/commit/095113b23216cfb65fdd863d3955566ebb64a79c

ENVIRONMENT PREPARATION:
- a 2 node cluster with nodes: node1, node2
- a dummy resource (pcs resource create dummy ocf:heartbeat:Dummy)

To test this fix, run commands:
# pcs constraint location dummy prefers node1 node2=invalid
# echo $?
1
# pcs constraint location show 
Location Constraints:

# pcs constraint location dummy avoids node1=-50 node2
# echo $?
0
# pcs constraint location show 
Location Constraints:
  Resource: dummy
    Enabled on: node1 (score:50)
    Disabled on: node2 (score:-INFINITY)

Comment 4 Miroslav Lisik 2019-10-23 15:24:54 UTC
After fix:

[root@r81-node-01 ~]# rpm -q pcs
pcs-0.10.3-1.el8.x86_64

[root@r81-node-01 pcs]# pcs constraint location d-01 prefers r81-node-01 r81-node-02=invalid
Error: invalid score 'invalid', use integer or INFINITY or -INFINITY
[root@r81-node-01 pcs]# echo $?
1
[root@r81-node-01 pcs]# pcs constraint location d-01 avoids r81-node-01=-50 r81-node-02
[root@r81-node-01 pcs]# echo $?
0
[root@r81-node-01 pcs]# pcs constraint
Location Constraints:
  Resource: d-01
    Enabled on:
      Node: r81-node-01 (score:50)
    Disabled on:
      Node: r81-node-02 (score:-INFINITY)
Ordering Constraints:
Colocation Constraints:
Ticket Constraints:

Comment 8 errata-xmlrpc 2020-04-28 15:27:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:1568


Note You need to log in before you can comment on or make changes to this bug.