Bug 1525938

Summary:	%check RPM macro used in %changelog needs to be escaped
Product:	[Fedora] Fedora	Reporter:	Kamil Dudka <kdudka>
Component:	acpica-tools	Assignee:	Al Stone (Old account - use ahs3) <ahs3+donotuse>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	27	CC:	ahs3+donotuse, ahs3
Target Milestone:	---	Keywords:	EasyFix
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	acpica-tools-20180105-1.fc26 acpica-tools-20180105-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-18 21:11:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kamil Dudka 2017-12-14 13:25:30 UTC

Description of problem:
The following change log entry contains unescaped RPM macro, which is not allowed:
* Fri Aug 18 2017 Al Stone <ahs3> - 20170728-3
- Completed the big-endian fixes (I think)
- Fix ppc64le.patch that inadvertently broke s390x
- Minor patch refresh
- Re-enable full %check for s390x


Version-Release number of selected component (if applicable):
acpica-tools-20171110-1.fc27


How reproducible:
Easily.


Steps to Reproduce:
1. rpmlint acpica-tools.spec


Actual results:
acpica-tools.spec:212: W: macro-in-%changelog %check
acpica-tools.spec:395: W: macro-in-%changelog %__global_ldflags
acpica-tools.spec:28: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 28)


Additional info:
This causes problems to csmock (a tool for fully automatic static analysis of RPM packages).

Please consider applying the following trivial patch:
--- a/acpica-tools.spec
+++ b/acpica-tools.spec
@@ -209,7 +209,7 @@ fi
 - Completed the big-endian fixes (I think)
 - Fix ppc64le.patch that inadvertently broke s390x
 - Minor patch refresh
-- Re-enable full %check for s390x
+- Re-enable full %%check for s390x

 * Mon Aug 14 2017 Al Stone <ahs3> - 20170728-2
 - Start some long delayed clean-up
@@ -392,7 +392,7 @@ fi
 - Refresh patches
 - Add patch to ensure ASLTS always reports when an error occurs, instead
   of glossing over it.
-- Add use of %__global_ldflags.  Closes BZ#1126134.
+- Add use of %%__global_ldflags.  Closes BZ#1126134.

 * Fri Aug 29 2014 Al Stone <ahs3> - 20140828-1
 - Update to latest upstream.  Closes BZ#1135352.

Comment 1 Fedora Update System 2018-01-10 21:50:22 UTC

acpica-tools-20180105-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1db1c5f9f2

Comment 2 Fedora Update System 2018-01-10 21:50:36 UTC

acpica-tools-20180105-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-298b10875a

Comment 3 Fedora Update System 2018-01-11 23:08:36 UTC

acpica-tools-20180105-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1db1c5f9f2

Comment 4 Fedora Update System 2018-01-11 23:42:25 UTC

acpica-tools-20180105-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-298b10875a

Comment 5 Fedora Update System 2018-01-18 21:11:04 UTC

acpica-tools-20180105-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2018-01-18 21:30:47 UTC

acpica-tools-20180105-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.